Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-13 Thread Konstantin Kolinko
well, I can imagine a scenario that this issue may be seen a) start Tomcat and make a bookmark that includes jsessionid in its path b) reconfigure Tomcat to use a different name for jsessionid parameter c) the bookmark no longer works. Best regar

Re: svn commit: r1022117 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2010-10-13 Thread Konstantin Kolinko
should be final, surely? > There are a lot of non-final fields in ApplicationContext and I think in related classes as well. I do not think making this specific one as final is essential. (Anyway, +1 if anybody wants to do that). Best regards, Konstantin Kolinko

Recycling processors in Http11NioProtocol

2010-10-13 Thread Konstantin Kolinko
-than-verbose logs. log.error(sm.getString("http11protocol.proto.error"), e); } +connections.remove(socket); +processor.recycle(); recycledProcessors.offer(processor); return SocketState.CLOSED; } ]]] Best regards, Konsta

Re: svn commit: r1022117 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2010-10-13 Thread Konstantin Kolinko
2010/10/14 sebb : > On 14 October 2010 00:05, Konstantin Kolinko wrote: >> Re: sebb: >> 2010/10/13 sebb : >>>> -    private Map parameters = null; >>>> +    private Map parameters = >>>> +        new ConcurrentHashMap(); >>> >>>

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread Konstantin Kolinko
2010/10/13 Mark Thomas : > On 13/10/2010 16:57, Konstantin Kolinko wrote: >> 2010/10/6  : >>> Author: markt >>> Date: Wed Oct  6 18:03:03 2010 >>> New Revision: 1005192 >>> >>> URL: http://svn.apache.org/viewvc?rev=1005192&view=rev >

Re: Recycling processors in Http11NioProtocol

2010-10-14 Thread Konstantin Kolinko
2010/10/14 Mark Thomas : > On 14/10/2010 01:01, Konstantin Kolinko wrote: >> Hi! >> >> Looking at the Http11NioProtocol.Http11ConnectionHandler.release(NioChannel >> socket) method in Http11NioProtocol.java,  it looks for me that like >> that method does in al

Re: JmxRemoteLifecycleListener and com.sun.security.auth.module.LdapLoginModule JMX authentification

2010-10-14 Thread Konstantin Kolinko
ay change it. > Should I open a BZ for this one ? I do not see a problem here, but if you are to propose some patch/enhancement then you are welcome, as always. Best regards, Konstantin Kolinko - To unsubscribe, e-mai

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-15 Thread Konstantin Kolinko
2010/10/14 Mark Thomas : > On 14/10/2010 09:02, Konstantin Kolinko wrote: >> OK. Looks that the patch is working.  The snoop.jsp displays the full >> original path as "Request URI" (aka request.getRequestURI()). >> >> Other things there >> 1) Add http:/

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-15 Thread Konstantin Kolinko
this.eden); > +                } >                 this.eden.clear(); >             } >             this.eden.put(key, value); > I think that a ReadWriteLock will be more suitable here, because there will be a thousand of reads for a

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-16 Thread Konstantin Kolinko
peration in get() is a read, and the one in put() is a write. (As for the whole structure, yes, get() updates it). > A ReentrantLock might do a better job than a synchronized block if > there's a real concern about the cost of syncs, but if not a rewrite > of the cache

Re: bugzilla question : bugs fixed in trunk but not yet in tc6

2010-10-22 Thread Konstantin Kolinko
he bug is assigned to: we move it to the one where it is still present: to TC6, then to TC5. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-ma

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-22 Thread Konstantin Kolinko
2010/10/16 Konstantin Kolinko : > 2010/10/16 Tim Whittington : >>>> Modified: >>>>    tomcat/trunk/java/javax/el/BeanELResolver.java >>>>    tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java >>>>    tomcat/trunk/java/org/apache/el/u

Re: bugzilla question : bugs fixed in trunk but not yet in tc6

2010-10-23 Thread Konstantin Kolinko
that it was > fixed in 7.0.3 ?? > http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml (as mentioned on http://tomcat.apache.org/bugreport.html#Recently_fixed_issues ) Best regards, Konstantin Kolinko --

Re: svn commit: r1026723 - in /tomcat/taglibs/standard/trunk: compat/ compat/src/main/java/org/apache/taglibs/standard/tag/compat/core/ impl/src/main/java/org/apache/taglibs/standard/tag/common/core/

2010-10-24 Thread Konstantin Kolinko
on to avoid memory leak from > retained references > > Added: >     > tomcat/taglibs/standard/trunk/compat/src/main/java/org/apache/taglibs/standard/tag/compat/core/OutTag.java svn:eol-style (and svn:keywords) are not set on this OutTag.java and on a number of other files that we

Re: [taglibs] svn properties, was: svn commit: r1026723 - in /tomcat/taglibs/standard/trunk...

2010-10-24 Thread Konstantin Kolinko
rd (I think). Looks good. > I've not set svn:keywords as that is not set on any existing files. Should we > be doing that? Not needed unless the keywords are actually used in those files. Best regards, Konstantin Kolinko > > On Oct 24, 2010, at 4:37 AM, Konstantin Kolinko wro

Re: Is it possible to handle exception on ant build?

2010-10-28 Thread Konstantin Kolinko
ons there. Offtopic: I think that there are a lot of options to solve your problem. E.g.: 1) check return value (aka exit code) of Ant, 2) use failonerror="false" and errorProperty attributes on the javac task Best regards, Konst

Re: Tomcat JDBC Pool in Tomcat 6.0.x / 7.0.x

2010-10-28 Thread Konstantin Kolinko
several candidate builds, but none gathered enough votes. See [VOTE] threads on dev@ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Is it possible to handle exception on ant build?

2010-10-28 Thread Konstantin Kolinko
2010/10/28 pannar : > > I am new to this forum. Please move redirect me to ant users forum with this > thread. > It is not a forum. It is a mailing list. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: svn commit: r1029423 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-11-01 Thread Konstantin Kolinko
es some more pointers [2] http://www.geekpedia.com/Thread27309_How-Do-I-Tell-If-A-DLL-Is-X86-X64-Or-AnyCpu.html [3] http://stackoverflow.com/questions/480696/how-to-find-if-native-dll-is-compiled-as-x64-or-x86 4. We can write a Java class and execute it with javaw.exe System.getProperty(&qu

Re: configtest

2010-11-03 Thread Konstantin Kolinko
args); +if (null==daemon.getServer()) { +System.exit(1); +} +System.exit(0); where load(args) processes command line arguments, parses server.xml and also calls getServer().init(); I like it. My +1 Best regards, Konstantin Kolinko

Re: svn commit: r1029423 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-11-03 Thread Konstantin Kolinko
2010/11/1 Mark Thomas : > On 01/11/2010 06:43, Konstantin Kolinko wrote: >> >> Some thoughts: >> >> 1. We do not need this check at all on a 32-bit OS. > > Yep. Should be possible to avoid this check on a 32-bit OS. > 2010/11/1 William A. Rowe Jr. : > &

Re: svn commit: r1031024 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-11-04 Thread Konstantin Kolinko
sues.apache.org/bugzilla/show_bug.cgi?id=50072 i.e. a slow connection, with a trailer that exceeds the packet size. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Objections about formatting options to time stamp in access log

2010-11-08 Thread Konstantin Kolinko
docs/current/mod/mod_log_forensic.html > Regards, > > Rainer > > [1] http://httpd.apache.org/docs/trunk/mod/mod_log_config.html#formats > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: java.lang.ClassNotFoundException: org.apache.jsp.index_jsp

2010-11-09 Thread Konstantin Kolinko
clude: - the actual message (and tracktrace) that you are observing in _your_ version of Tomcat. - any other error messages from your logs. Is there anything interesting that precedes the error? - your server.xml (remove all XML comments and passwords!) Best regards, Konsta

Re: Objections about formatting options to time stamp in access log

2010-11-10 Thread Konstantin Kolinko
g. > buf.append(Long.toString(...)) won't produce leading zeros > The addElement() in the interface isn't very helpful. If there is a need to change the AccessLogElement interface, I think that can be done. We already changed it betwee

ContainerBase @trunk (Re: r1029527)

2010-11-16 Thread Konstantin Kolinko
that iterates over parents of a context. So the name can belong to a host or an engine. (Though unlikely anyone will name them like that, so actually I do not bother about this). Best regards, Konstantin Kolinko - To unsubscribe, e-

Re: ContainerBase @trunk (Re: r1029527)

2010-11-16 Thread Konstantin Kolinko
2010/11/16 Mark Thomas : > On 16/11/2010 15:44, Konstantin Kolinko wrote: >> I saw the following fragment in ContainerBase.logName(): >> Lines 1277-1278: >> >>       } else if (name.startsWith("##")) { >>          name = "/" + name; >&g

Re: svn commit: r1036021 - /tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java

2010-11-17 Thread Konstantin Kolinko
all that arithmetics should be done inside the manager. Then the manager can be optimized how to store it. E.g., unless someone calls getSessionAverageAliveTime() the value of average = (int) (((average * (numExpired-1)) + timeAlive)/numExpired); is not needed. Also that call can be moved out of

Re: setclasspath vs. setenv

2010-11-17 Thread Konstantin Kolinko
2010/11/17 Thangalin : > Hi, > > Judging by its name alone, I would have thought that "setclasspath" (.bat or > .sh) would be a place to put custom code that sets the classpath before > Tomcat starts, or stops. > Setting CLASSPATH explicitly is a bad idea. The cases when it is needed in Tomcat ar

Re: svn commit: r1036232 - /tomcat/site/trunk/docs/images/tomcat.gif

2010-11-18 Thread Konstantin Kolinko
> Logo with tm. Required a litte bit larger image >> > > > Regards > -- > ^TM > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1037279 [1/10] - in /tomcat/taglibs/standard/trunk/impl: (..)

2010-11-20 Thread Konstantin Kolinko
others to fix it (if anybody wants to do that). It is the only serious code change in this commit. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

License of border-radius.htc in TC7 ROOT webapp

2010-11-22 Thread Konstantin Kolinko
IE7, if I remove it, there are straight square corners and the gradient background is misplaced. I do not like the wrong background, but straight corners are nice. Anyway, it is not a big deal and the page is still usable. Best regards, Konstantin Kolinko

Re: svn commit: r1036981 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/jni/Error.java

2010-11-22 Thread Konstantin Kolinko
This goes as CTR and was not applied to trunk. If voting is needed, count me as +1 for this. 2010/11/19 : > Author: markt > Date: Fri Nov 19 19:01:34 2010 > New Revision: 1036981 > > URL: http://svn.apache.org/viewvc?rev=1036981&view=rev > Log: > Additional info for https://issues.apache.org/bugz

Re: [SECURITY] CVE-2010-4172: Apache Tomcat Manager application XSS vulnerability

2010-11-22 Thread Konstantin Kolinko
27;- -' and the start of lines, and wrapped long lines as well. [1] http://mail-archives.apache.org/mod_mbox/tomcat-announce/201011.mbox/%3c4ceac06f.6030...@apache.org%3e [2] http://markmail.org/message/kem4h34suvkqyv4h Best regards, Konstantin Kolinko -

Re: License of border-radius.htc in TC7 ROOT webapp

2010-11-22 Thread Konstantin Kolinko
2010/11/22 Konstantin Kolinko : > Hi, all! > > The file  /webapps/ROOT/border-radius.htc > in the current trunk does not have the ASL header, nor any other > explicit license. > I removed the file and a reference to it in r1037929 I do not want this to be a hindrance for 7.

Re: Invitation to become a Tomcat committer

2010-11-24 Thread Konstantin Kolinko
Hi, Chris, and others on d...@! 2010/11/24 Christopher Schultz : >> Documentation is always CTR. Besides Documentation there are also several types of code changes that are CTR as well, http://markmail.org/thread/2fgydrrhn4qjye3r Best regards, Konstantin K

Re: svn commit: r1038835 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-11-24 Thread Konstantin Kolinko
2010/11/25 : > Author: markt > Date: Wed Nov 24 21:32:52 2010 > New Revision: 1038835 > > URL: http://svn.apache.org/viewvc?rev=1038835&view=rev > Log: > Proposal > > Modified: >    tomcat/tc6.0.x/trunk/STATUS.txt > > + > +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48837 > +  Extend

Re: [Tomcat Wiki] Update of "TomcatVersions" by TimFunk

2010-11-24 Thread Konstantin Kolinko
usually is > covered by RTC, that this commit was done using C-T-R rule. > + >   Thank you, Tim! Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1038717 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_5: ./ java/org/apache/catalina/core/ java/org/apache/catalina/startup/

2010-11-24 Thread Konstantin Kolinko
py. The above mentioned files have rev. later than their parent. I do not say that anything is broken. It just might be an inconvenience. This tag actually matches r1038713, not r1038654. > Modified: >    tomcat/tc7.0.x/tags/TOMCAT_7_0_5/build.properties.default > > Propcha

Re: fixing subject of Bugzilla issues

2010-11-25 Thread Konstantin Kolinko
ood. > Is there an established rule on this subject (pun intended) ? None. Renames in bugzilla do happen, but otherwise I'd prefer to focus on the changelog file. That is what people read. Best regards, Konstantin Kolinko ---

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Konstantin Kolinko
of JRE might be important. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1040161 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2010-11-29 Thread Konstantin Kolinko
arching for "asyncStateMachine.invalidAsyncState" in that file, there are more errors like that, starting with s/startAsync()/asyncStart()/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Konstantin Kolinko
his commit: (I have not verified this, just a hunch) My understanding is that when Tomcat is started by jsvc, Bootstrap.init(String[]) is called and then jsvc drops privileges and calls Bootstrap.start(), as documented in [1]. So, binding to port 80 should be performed during initialization

Re: My [commit] first to 7.x

2010-12-03 Thread Konstantin Kolinko
2010/12/3 Christopher Schultz : > All, > > Duh, nevermind. > > -chris > > On 12/3/2010 10:37 AM, Christopher Schultz wrote: >> >> Great. It looks like the format is latest-on-top. Since this is a bug, >> it makes sense to use the tag, but it's actually an enhancement >> and not a flaw, so it makes

Re: Adding utility classes

2010-12-03 Thread Konstantin Kolinko
on the classes packed into tomcat-util.jar. Don't forget to set svn:eol-style=native on the added file. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1042029 - in /tomcat: tc6.0.x/trunk/STATUS.txt trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java trunk/webapps/docs/changelog.xml trunk/webapps/docs/config/list

2010-12-03 Thread Konstantin Kolinko
yLeakPreventionListener to load > +  javax.security.auth.login.Configuration to avoid redeployment leak. > +  +1: slaurent > +  -1: You must include patch URL in your proposal. (What are we voting for?) Thus, you usually cannot

Re: svn commit: r1041940 - in /tomcat/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/

2010-12-03 Thread Konstantin Kolinko
> ... ".fbprefs" does not belong to this commit. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1042350 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2010-12-05 Thread Konstantin Kolinko
ration.html >    tomcat/site/trunk/xdocs/migration.xml > migration.html mentions "sessionCookieName" option on in Tomcat 7, but it is not documented in config/context.xml. Best regards, Konstantin Kolinko - To unsu

Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2010-12-05 Thread Konstantin Kolinko
x27; (they will be concatenated at compile time anyway), thought it would make harder to search for them. Usually there is no need to bother. One example are string constants in HTMLManagerServlet. Another is SecurityClassLoad. Best regards, Konstantin Kolinko --

Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/

2010-12-07 Thread Konstantin Kolinko
g) arrangement. > If you have some "long string" that occupies all space up to position 79, forcing some operator after it to stay on the same line effectively increases its length by several chars and will cause the whole string to be placed on the new line. It just

Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/

2010-12-07 Thread Konstantin Kolinko
; number of lines). > My preference is 100 characters per line. IDEs are fine, but long lines are hard to deal with 1) in commit e-mails - they become wrapped 2) in side-by-side diffs Best regards, Konstantin Kolinko - To un

org.apache.catalina.WELCOME_FILES constant (was: svn commit: r1043265)

2010-12-08 Thread Konstantin Kolinko
he attribute from that StandardContext method), b) revert deletion of this constant, and use it in StandardContext. I am OK with a) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1043444 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java AjpMessage.java Constants.java

2010-12-08 Thread Konstantin Kolinko
va/org/apache/coyote/ajp/AjpMessage.java?rev=1043444&r1=1043443&r2=1043444&view=diff > Why are you removing those methods from AjpMessage? That is an utility class that deals with AJP protocol, and those methods look not broken and useful. Best regards, Konstantin Kolinko --

Static reference to a Throwable causing ClassLoader leak

2010-12-11 Thread Konstantin Kolinko
piler.JspDocumentParser. I will add an issue into Bugzilla. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Static reference to a Throwable causing ClassLoader leak

2010-12-11 Thread Konstantin Kolinko
2010/12/12 Konstantin Kolinko : > 2) I found a scenario when such a leak is caused by a field in > org.apache.jasper.compiler.JspDocumentParser. I will add an issue into > Bugzilla. https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 Best regards, Konstanti

Re: Adding annotations to JspC

2010-12-17 Thread Konstantin Kolinko
annotations, or do you list them in web-fragment.xml ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1050682 - /tomcat/trunk/java/org/apache/el/util/MessageFactory.java

2010-12-19 Thread Konstantin Kolinko
ormat#format(Object) uses new FieldPosition(0) there. Anything wrong with just calling the usual static method, MessageFormat.format(pattern, args) ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@t

Re: Tomcat 7 & regex

2010-12-25 Thread Konstantin Kolinko
but forcing a single regex saves too little in performance of RequestFilterValve.process(..) (removes iterating over an array but adds a null check). [OT] Merry X'mas Best regards, Konstantin Kolinko 2010/12/25 Tim Funk : > +0.5 - I wonder if in some cases - it may be preferable to use a

Re: [taglibs] Move to pre-req Java 1.6 for Locale services?

2011-01-02 Thread Konstantin Kolinko
sue with this? > +1 While technically it is possible to implement it differently for 1.5 and 1.6, I think it is not worth our efforts. +1 to go with 1.6+ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@to

Re: Time for 6.0.30?

2011-01-04 Thread Konstantin Kolinko
at boot time. I did not observe it with commons-daemon 1.0.2 that 6.0.29 release is using, but I am not sure that it is absent there. I'd be nice if next release of commons-daemon were available in time for TC 6.0.30 to use it. [1] https://issues.apache.org/jira

Re: ThreadLocal Clear References Problem

2011-01-06 Thread Konstantin Kolinko
quot;major" one if it were). It is also offtopic here on d...@. As [1] says, do not forget to mention what exact version of Tomcat you are using. [1] http://tomcat.apache.org/lists.html Best regards, Konstantin Kolinko --

Re: [PROPOSAL] Remove o.a.catlina.InstanceListener

2011-01-07 Thread Konstantin Kolinko
rc/main/org/jboss/web/tomcat/security/RunAsListener.java My opinion on this proposal is "-1". Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1050249 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java webapps/docs/changelog.xml

2011-01-07 Thread Konstantin Kolinko
Is it worth being ported to 6.0? It looks so, though have not reviewed it in detail yet. 2010/12/17 : > Author: markt > Date: Fri Dec 17 00:17:18 2010 > New Revision: 1050249 > > URL: http://svn.apache.org/viewvc?rev=1050249&view=rev > Log: > Fix massive memory leak in NIO connector. Http11NioPro

Re: svn commit: r1056445 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/changelog.xml

2011-01-08 Thread Konstantin Kolinko
> >> @@ -558,8 +559,17 @@ public class RemoteIpValve extends Valve >>             String remoteIp = null; >>             // In java 6, proxiesHeaderValue should be declared as a >> java.util.Deque >>             LinkedList proxiesHeaderValue = new LinkedList(); >> +    

Re: svn commit: r1056947 - /tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java

2011-01-09 Thread Konstantin Kolinko
ing[] { "GET /MyApp/missing HTTP/1.0" + > +SimpleHttpClient.CRLF + SimpleHttpClient.CRLF }); Is there a reason why Checkstyle does not like "static import"s ? Can it be configured to like them? (or i

Re: [VOTE] Release build 6.0.30

2011-01-10 Thread Konstantin Kolinko
[x] Stable > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1044708 - /tomcat/trunk/java/javax/el/CompositeELResolver.java

2011-01-10 Thread Konstantin Kolinko
.getValue(context, base, property); >                     if (value != null) { The instanceof in the old code works for any class that extends ScopedAttributeELResolver. The new code does not. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1057275 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/config/

2011-01-10 Thread Konstantin Kolinko
unfilteredAppPaths) { > +            if (filter.matcher(appPath).matches()) { > +                log.debug(sm.getString("hostConfig.ignorePath", appPath)); Wrap with log.isDebugEnabled() > +            } else { > +                filteredList.add(appPath); >

Re: svn commit: r1058807 - in /tomcat/site/trunk: docs/download-70.html docs/index.html docs/whichversion.html xdocs/download-70.xml xdocs/index.xml xdocs/whichversion.xml

2011-01-13 Thread Konstantin Kolinko
updated the symlink. Please correct the group ownership for 7.0.5 ones (if we aren't removing them yet). That will be chgrp -R tomcat tomcat-7.0-doc-7.0.5 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsu

Re: svn commit: r1058556 - /tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java

2011-01-13 Thread Konstantin Kolinko
getFile() + "] to [" + > +                                            deployable + "]"); (..) i18n ? It is "error". It will be visible. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Cluster Health Check

2011-01-14 Thread Konstantin Kolinko
2011/1/14 Lingagiri : > > What are all items do we need to monitor Usage questions should be asked on the users@ list, not here. Please read http://tomcat.apache.org/lists.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa

Re: Access log changes in 7.0.6

2011-01-14 Thread Konstantin Kolinko
iven that 7.0.6 is now stable, I think c) is probably too big a change > for 7.0.x but I do think that is the direction it needs to head. > > For 7.0.x, I think b) is probably the way to go along with some > additional documentation that explains the implications of each of the > con

Re: svn commit: r1059346 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/McastServiceImpl.java webapps/docs/changelog.xml webapps/docs/config/cluster-membership.xml

2011-01-15 Thread Konstantin Kolinko
gree that it is ugly, but that resolves the mystery why this "bug" was not noted). So it looks like r1059346 has to be reverted. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1059366 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

2011-01-15 Thread Konstantin Kolinko
n 5.5 it is this.parent=null; thanks to this rev: http://svn.apache.org/viewvc?view=revision&revision=571739 With this kind of code I would expect "if (parent != null)" checks elsewhere, but there are no such checks. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Time for 5.5.32??

2011-01-17 Thread Konstantin Kolinko
2011/1/17 Mark Thomas : > On 17/01/2011 14:02, Jim Jagielski wrote: >> I'd like to look over the remaining STATUS of 5.5 in hopes of >> getting a 5.5.32 out soon... I'll RM. >> >> Comments? > >

Re: Hosting the current Tomcat Maven Plugin from mojo codehaus

2011-01-18 Thread Konstantin Kolinko
t;> vote in the codehaus mojo dev ml). > > +1. Seems like an ideal candidate for /tomcat/modules to me. > > Mark > +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Improving CGIServlet - path and args to the executable

2011-01-18 Thread Konstantin Kolinko
tarting with "1" So cmd /q /c will be written as executable cmd.exe executable-arg-1 /q executable-arg-2 /c What do you think? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Improving CGIServlet - path and args to the executable

2011-01-18 Thread Konstantin Kolinko
arg-2 >>  /c >> >> >> What do you think? > > Ant has a nicer format: > > >     >     >     > That above was a part of web.xml. Maybe you mean "arg-1", "arg-2" etc (instead of "executable-arg-1")? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Need a 6.0.31 release

2011-01-20 Thread Konstantin Kolinko
bout the following issue as well: ? https://issues.apache.org/bugzilla/show_bug.cgi?id=50620 There is a patch available. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additiona

Re: svn commit: r1061442 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2011-01-20 Thread Konstantin Kolinko
2011/1/20 : > Author: markt > Date: Thu Jan 20 18:34:18 2011 > New Revision: 1061442 > > > Modified: >    tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties >    tomcat/trunk/java/org/apache/catalina/connector/Request.java > > --- tomcat/trunk/java/org/apache/catalina/connecto

Re: Current TC 7.0.x/trunk fails to build release

2011-01-21 Thread Konstantin Kolinko
2011/1/21 Christopher Schultz : > $ ant release What is your ant version? 1.8.x is needed. Buildbot runs "ant release" repeatedly, and it succeeds E.g. http://ci.apache.org/builders/tomcat-trunk/builds/1181 -> "3. compile" -> look at stdio file Bes

Re: svn commit: r1061442 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2011-01-21 Thread Konstantin Kolinko
components can be involved there b) endAccess() is not a trivial method to be used in recycle() it would be better to safeguard it. Backporting the fix to 5.5 waits for the third vote. Best regards, Konstantin Kolinko - To u

Re: bug in TC6 ContainerBase class?

2011-01-21 Thread Konstantin Kolinko
but interrupt() has synchronization semantics per Ch.17.4.4. I think that using interrupt() is the reason why no issue have been observed here and why "volatile" is not necessary. (Though I wouldn't object if "volatile" were added to that field.) [1] http://java.

Re: svn commit: r1061433 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ webapps/docs/

2011-01-21 Thread Konstantin Kolinko
resetStatistics() is a synchronized method, i.e. synchronizes on this, but in all other places these linked lists use themselves as the lock: synchronized (sessionCreationTiming) { resetStatistics() is called from JMX only, so it does not concern normal operation. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Konstantin Kolinko
ing whose default value is "false". Please see > BZ for details. > > I propose to make the default for this setting "true" unless > STRICT_SERVLET_COMPLIANCE is set to TRUE. > > Any comments? > Why is it on Connector? Won'

Re: Proposal: set default for Connector.allowCasualMultipartParsing to true

2011-01-21 Thread Konstantin Kolinko
e.printStackTrace(); Use log.debug() or whatever, but not the above. No need for i18n. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-22 Thread Konstantin Kolinko
mcat-5.5.32.zip.md5 2) Regarding version number bump http://svn.apache.org/viewvc?rev=1062211&view=rev s/version.build=31/version.build=32/ is needed. IIRC version.bat/version.sh will display the wrong number. Best regards, Konstantin Kolinko

Re: [VOTE] Release build 6.0.31

2011-01-27 Thread Konstantin Kolinko
.0.30 as well. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release build 6.0.31

2011-01-27 Thread Konstantin Kolinko
2011/1/27 jean-frederic clere : > On 01/27/2011 10:30 AM, Konstantin Kolinko wrote: >> >> 2011/1/25 jean-frederic clere: >>> >>> The candidates binaries are available here: >>> http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ >>> >

Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-27 Thread Konstantin Kolinko
2011/1/22 Jim Jagielski : > [x] Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release build 6.0.31

2011-01-28 Thread Konstantin Kolinko
2011/1/28 Rainer Jung : > On 27.01.2011 21:39, Konstantin Kolinko wrote: >> >> 2011/1/27 jean-frederic clere: >>> >>> On 01/27/2011 10:30 AM, Konstantin Kolinko wrote: >>>> >>>> 2011/1/25 jean-frederic clere: >>>>> >>

Re: [VOTE] Release build 6.0.31

2011-01-28 Thread Konstantin Kolinko
2011/1/28 Konstantin Kolinko : > 2011/1/28 Rainer Jung : >> On 27.01.2011 21:39, Konstantin Kolinko wrote: >>> >>> 2011/1/27 jean-frederic clere: >>>> >>>> On 01/27/2011 10:30 AM, Konstantin Kolinko wrote: >>>>> >>>

Failure of TestFormAuthenticator with NIO in trunk

2011-01-29 Thread Konstantin Kolinko
socket.getPoller().add(socket); } } if (state == SocketState.LONG || state == SocketState.ASYNC_END) { [1] http://svn.apache.org/viewvc?view=revision&revision=1063366 [2] http://ci.apache.org/builders/tserver-tr

Re: Failure of TestFormAuthenticator with NIO in trunk

2011-01-29 Thread Konstantin Kolinko
2011/1/29 Mark Thomas : > On 29/01/2011 18:48, Konstantin Kolinko wrote: >> Hi! >> >> In r1063366 [1] there was a check added to Nttp11NioProtocol class that >> now causes 3 of 5 tests in TestFormAuthenticator to fail with Nio connector. > > That'll be my

[PROPOSAL] Configure Tomcat service to be terminated by java.lang.System.exit() call

2011-02-01 Thread Konstantin Kolinko
sage about that in our catalina.log. Though commons-daemon prints a message to its own log so the users will be able to look there. I tested running with a SecurityManager and there are no problems: it does not prevent java/lang/System#exit() being called from commons-daemon. Any comments

Re: Tagging 7.0.7

2011-02-02 Thread Konstantin Kolinko
ater today. There are plenty of > fixes in the changelog, particularly for Comet, that I think makes this > worthwhile. > +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: [VOTE] Release build 6.0.32

2011-02-02 Thread Konstantin Kolinko
[x] Stable > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.7

2011-02-03 Thread Konstantin Kolinko
roposed 7.0.7 release is: > > [x] Stable - go ahead and release as 7.0.7 Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.8

2011-02-04 Thread Konstantin Kolinko
roposed 7.0.8 release is: > > [x] Stable - go ahead and release as 7.0.8 Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1067734 - /tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java

2011-02-06 Thread Konstantin Kolinko
2011/2/6 : > Author: markt > Date: Sun Feb  6 19:28:48 2011 > New Revision: 1067734 > > URL: http://svn.apache.org/viewvc?rev=1067734&view=rev > Log: > First attempt at a valve to limit session creation by web crawlers. > Docs etc to follow once it is confirmed working. > > Added: >     > tomcat/t

<    5   6   7   8   9   10   11   12   13   14   >