2011/1/9  <[email protected]>:
> Author: markt
> Date: Sun Jan  9 14:52:31 2011
> New Revision: 1056947
>
> URL: http://svn.apache.org/viewvc?rev=1056947&view=rev
> Log:
> Fix checkstyle warnings
>
> Modified:
>    tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java
>
> Modified: 
> tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java?rev=1056947&r1=1056946&r2=1056947&view=diff
> ==============================================================================
> --- tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java 
> (original)
> +++ tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java 
> Sun Jan  9 14:52:31 2011
> @@ -16,8 +16,6 @@
>  */
>  package org.apache.catalina.servlets;
>
> -import static org.apache.catalina.startup.SimpleHttpClient.CRLF;
> -

(...)
> -        client.setRequest(new String[] { "GET /MyApp/missing HTTP/1.0" + CRLF
> -                + CRLF });
> +        client.setRequest(new String[] { "GET /MyApp/missing HTTP/1.0" +
> +                SimpleHttpClient.CRLF + SimpleHttpClient.CRLF });


Is there a reason why Checkstyle does not like "static import"s ?

Can it be configured to like them?
(or it is not worth as you think that with those explicit
"SimpleHttpClient.CRLF" etc. are more readable)?


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to