2011/1/15 Mark Thomas <ma...@apache.org>: > On 15/01/2011 16:33, ma...@apache.org wrote: >> Author: markt >> Date: Sat Jan 15 16:33:05 2011 >> New Revision: 1059366 >> >> URL: http://svn.apache.org/viewvc?rev=1059366&view=rev >> Log: >> Refactor to make clearer what is going on > > Hopefully this is clearer. > >> @@ -585,22 +585,27 @@ public class McastServiceImpl >> >> protected static class RecoveryThread extends Thread { >> static volatile boolean running = false; >> - McastServiceImpl parent = null; >> - public RecoveryThread(McastServiceImpl parent) { >> - this.parent = parent; >> - if (!init(this)) parent = null; >> - } > > I couldn't see what the "if (!init(this)) parent = null;" line was > doing. Even if it were "... this.parent = null;" I still don;t see the > need. Am I missing something?
My guess is that is to prevent this RecoveryThread from being used if recovery is disabled. Actually, as you noticed, in TC 6 that assignment modifies the method argument and thus does nothing. In 5.5 it is this.parent=null; thanks to this rev: http://svn.apache.org/viewvc?view=revision&revision=571739 With this kind of code I would expect "if (parent != null)" checks elsewhere, but there are no such checks. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
