2011/1/7 Mark Thomas <ma...@apache.org>: > All, > > I just stumbled across o.a.catlina.InstanceListener and the associated > classes when I was reviewing the results of the unused code detector. > > It isn't used at all in 7.0.x, nor can I find any sign of it being used > in 6.0.x and 5.5.x. A search of the mail archives doesn't turn up any > uses either. On that basis, I intend to remove it before I tag 7.0.6. > Any objections?
We indeed do not have our own classes that implement InstanceListener, but if you search for o.a.c.InstanceEvent, it is used in a plenty of places (to implement this feature actually). So it is not just throwing away classes, it also removal of many lines of code. Searching the web, it is mentioned e.g. here: http://community.jboss.org/message/288150?tstart=0 See also http://anonsvn.jboss.org/repos/jbossas/tags/JBoss_5_1_0_GA/tomcat/src/main/org/jboss/web/tomcat/security/RunAsListener.java My opinion on this proposal is "-1". Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
