Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-12-04 Thread Konstantin Kolinko
AsyncContextImpl.java:181) It was expected to complete no sooner than in 1000 ms (with error margin of 100). The actual value in the access log was 853. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...

Re: svn commit: r1417201 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-12-04 Thread Konstantin Kolinko
socket != null) { > + > socket.getPoller().cancelledKey(key,SocketStatus.ERROR); > +} > releaseCaches(); > log.error("", oom); > }catch ( Throwable oomt ) { > Best regards, Konstantin

Re: svn commit: r1417199 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-12-04 Thread Konstantin Kolinko
try { > @@ -1620,7 +1621,7 @@ public class AprEndpoint extends Abstrac > } > try { > // Add socket to the poller > - if (addCount > 0) { > +if (addCount.get() > 0) { >

Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml

2012-12-05 Thread Konstantin Kolinko
e of the > > The value of NORM_PRIORITY on Windows 64-bit JDK 7 appears to be 1, not 5. I > haven't checked other versions or platforms. 1 is MIN_PRIORITY. The constants are evaluated at compile time. They cannot be different between systems. (Whether

Re: svn commit: r1417424 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/AccessLogValve.java

2012-12-05 Thread Konstantin Kolinko
2012/12/5 : > Author: rjung > Date: Wed Dec 5 14:00:15 2012 > New Revision: 1417424 > > URL: http://svn.apache.org/viewvc?rev=1417424&view=rev > Log: > - Style > - Fix Javadoc > - Move default setting to the right place. By a quick look: You say "move", but I see only the new code and no removed

Re: auto-undeploy Old Context patch

2012-12-05 Thread Konstantin Kolinko
ented in 7.0.32 ? See release announcement at http://tomcat.apache.org/oldnews.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1417683 - in /tomcat/trunk/java/org/apache/tomcat/websocket: ClientContainerImpl.java PojoServerEndpointConfiguration.java ServerContainerImpl.java WsEndpointPojo.java WsFrame.java Ws

2012-12-06 Thread Konstantin Kolinko
h, String > pathInfo) { > +this.endpointFactory = > +new PojoEndpointFactory(pojo, methodMapping, pathInfo); > +this.servletPath = servletPath; > +} > + (...) Was it intended to make the constructor package-visible? If it is then the class itself

Re: svn commit: r1418074 - in /tomcat/maven-plugin/trunk: tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/ tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner

2012-12-06 Thread Konstantin Kolinko
2012/12/7 : > + * @author Mitch Kyle Use of @author tags is rather discouraged. ASF-released software is collective work, contributed by many people. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsub

Re: auto-undeploy Old Context patch

2012-12-08 Thread Konstantin Kolinko
g issue. DBCP cannot be compiled with Java 7, because of new methods in JDBC classes that it implements. I'd say that your Ant build is using JDK 7 instead of that 1.6.0_34. Best regards, Konstantin Kolinko - To unsubscribe,

Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2012-12-09 Thread Konstantin Kolinko
> > +public int hashCode() { >> > +if (hasHashCode) { >> > +return hashCode; >> > +} >> > +hashCode = hash(); >> > +hasHashCode = true; >> > +return hashCode; > > Or: > > public int hashCode() { >

Re: [VOTE] Release Apache Tomcat 7.0.34

2012-12-09 Thread Konstantin Kolinko
k.AssertionFailedError: null at org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak.testTimerThreadLeak(TestWebappClassLoaderExecutorMemoryLeak.java:72) The failing line is Assert.assertTrue(executorServlet.tpe.isTerminated()); This a failure is not new and is not an i

Re: svn commit: r783570 - /tomcat/current/tc4.1.x/STATUS.txt

2009-06-12 Thread Konstantin Kolinko
2009/6/12 Mark Thomas : > Konstantin Kolinko wrote: >> Thank you for detailed explanation. >> >> My analysis is the following: >> hres.setLocale(locale); >> call ->  o.a.c.Response.setLocale() -> >> o.a.c.connector.ResponseBase.setLocale() >>

Re: Updated procrun binaries

2009-06-12 Thread Konstantin Kolinko
atch applied), and found that our zip and tgz distributions already contain a copy of those 64-bit files. In the /bin folder there is now a /bin/procrun subfolder, that contains /bin/procrun/amd64/ and /bin/procrun/ia64/ subfolders

HostConfig.checkResources()

2009-06-13 Thread Konstantin Kolinko
and the code. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread Konstantin Kolinko
SimpleDateFormat("hh:mm:ss"); > +            } > +        }; > + I wonder, may be we can have a single ThreadLocal that holds some object that stores all the formatters (maybe with lazy initialization), ins

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-19 Thread Konstantin Kolinko
comes from "if (xxx > 1000) {" part, and how many times for each second it is triggered. If it is triggered only once, the performance is better. Best regards, Konstantin Kolinko - To unsubscribe, e-mail:

Re: svn commit: r786530 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-19 Thread Konstantin Kolinko
d there at that time, or maybe that value just slipped in. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r786527 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-19 Thread Konstantin Kolinko
t is worth to update it to "1.5" there. (The only reason I might see for that is to align the code with documentation). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-19 Thread Konstantin Kolinko
l, with StringBuilder took 11360ms It is on WinXP, JRE 6u12, two cores (Centrino Duo), running from within an IDE. The last two lines of the four are implementations using StringBuffer vs. StringBuilder. The difference is negligible (either one or the other i

Re: svn commit: r786530 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-20 Thread Konstantin Kolinko
2009/6/19 Mark Thomas : > Konstantin Kolinko wrote: >>>  * Fix wrong download location of tcnative 1.1.16 >>>   Patch for "build/build.properties.default": >>>   >>> http://people.apache.org/~kkolinko/patches/2009-05-25_fix_tcnative_download.patc

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-22 Thread Konstantin Kolinko
d on the 4.0.40 tag is: > [x] Stable > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r787648 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-23 Thread Konstantin Kolinko
? Also +ByteChunk origName=new ByteChunk(); +ByteChunk origValue=new ByteChunk(); can be 'private' here. The rest of it looks good. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@t

Re: svn commit: r787710 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-23 Thread Konstantin Kolinko
e-winzip.patch In the FindCpuType function: + StrCmp $0 "%PROCESSOR_ARCHITEW6432%" 0 +5 I think it should be StrCmp $0 "%PROCESSOR_ARCHITEW6432%" +5 0 Best regards, Konstantin Kolinko - To unsubscribe, e-

Re: svn commit: r787710 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-24 Thread Konstantin Kolinko
2009/6/23 Mladen Turk : > Konstantin Kolinko wrote: >> >> +  StrCmp $0 "%PROCESSOR_ARCHITEW6432%" 0 +5 >> >> I think it should be >> StrCmp $0 "%PROCESSOR_ARCHITEW6432%" +5 0 >> > > Thanks for spotting that. Updated the patch as wel

Re: svn commit: r787710 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-24 Thread Konstantin Kolinko
2009/6/24 Mladen Turk : > Konstantin Kolinko wrote: >> >> Minor issues: >> >> apache-tomcat-6.0-snapshot.tar.gz >>  has bin/service.bat, >>  while *.zip does not have the file. >> > > Probably missing exclude rule. > >> apache-tomcat-

Re: svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-24 Thread Konstantin Kolinko
is +rctxt.getWrapper(tagFileJarPath +tagFilePath); and few lines later: +rctxt.addWrapper(tagFileJarUrl + tagFilePath, wrapper); The first call uses tagFileJarPath while the second one uses tagFileJarUrl. I found this when comparing your patch agains

Re: [PROPOSAL] Use CTR for anything in the tomcat/archive in svn

2009-06-25 Thread Konstantin Kolinko
ke it easier. > > Unsurprisingly, here is my +1 +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-26 Thread Konstantin Kolinko
h regarding AccessLogValve. I'll write about two other classes later, if I find anything. (By the first glance, I have not noticed any problems there). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread Konstantin Kolinko
Mark Thomas wrote: >Konstantin Kolinko wrote: >> 2. struct.currentDateString is calculated in two different places >> I propose to encapsulate that code into AccessDateStruct >> >> 3. Invocation of getDate() in invoke() (the only place where getDate() >> is called

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-28 Thread Konstantin Kolinko
ExtendedAccessLogValve is broken. See the getDate() function there. "currentDate.getTime()" cannot be called unless this Date instance is local to this thread, but it is not there. Also, that Date object is returned by that function and can be used by other threads wh

Re: svn commit: r790292 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-01 Thread Konstantin Kolinko
quote, only the closing quote > Oh, thank you. I see, why: Those "[" + day + '/' +... sequences that are building the current date string were different. I'll update the patch. Best regards, Konstantin Kolinko

[PROPOSAL] Remove build-webapps-precompile target from dist.xml of TC 6, TC 7. Or enable and fix it?

2009-07-02 Thread Konstantin Kolinko
or tc6 is incomplete: compiled ROOT/index.jsp is not included into the distributives. For trunk that does not matter) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

Minimum Ant version for Tomcat 5.5 (was Re: svn commit: r791159)

2009-07-04 Thread Konstantin Kolinko
that we should support Ant 1.5.x for building TC 5.5, please say so. Though maybe it is already not possible to use it - I have not tried. If so, I would update the docs right away. Best regards, Konstantin Kolinko - To unsubscri

Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java

2009-07-04 Thread Konstantin Kolinko
e you have already done so, but have not committed yet? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java

2009-07-04 Thread Konstantin Kolinko
2009/7/4 Konstantin Kolinko : > 2009/7/4  : >> Author: markt >> Date: Sat Jul  4 15:46:47 2009 >> New Revision: 791139 >> >> URL: http://svn.apache.org/viewvc?rev=791139&view=rev >> Log: >> Fix generics warnings >> >> Modified: >&

Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java

2009-07-05 Thread Konstantin Kolinko
2009/7/5 Mark Thomas : > Konstantin Kolinko wrote: > >> Fixed it myself, in rev.791186. Don't worry. > > Thanks, but I am going to have to revert. Those are spec classes. I > should not have made my original change. > Oh, I see that now. Bes

Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java

2009-07-05 Thread Konstantin Kolinko
ableInfo#scope into account 2. I think that it does not work for tag files that declare variables. Also, 3. Node.UseBean node does not add anything to that set of variable names. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java

2009-07-05 Thread Konstantin Kolinko
2009/7/5 Mark Thomas : > Konstantin Kolinko wrote: >> 2009/7/5  : >>> Author: markt >>> Date: Sun Jul  5 11:30:22 2009 >>> New Revision: 791224 >>> >>> URL: http://svn.apache.org/viewvc?rev=791224&view=rev >>> Log: >>

Re: I find a bug in tomcat 4.1.x or later version(5.x,6.x)

2009-07-05 Thread Konstantin Kolinko
before. I do not see any requirement in the JSP specification to support such tricks. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed

2009-07-05 Thread Konstantin Kolinko
tes* in the new jars. Thus the compilation errors that we are observing. 3) The new ones do not contain *_fr,properties and *_ja.properties files. The servlet.jar from TC 4.1.40 matches the old one of July 2nd. I wonder, what happened with Gump configuration. Have not dug further yet. Best regard

Re: [g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed

2009-07-05 Thread Konstantin Kolinko
2009/7/6 Konstantin Kolinko : > 2009/7/5 Stefan Bodewig : >> To whom it may engage... >> >> This is an automated request, but not an unsolicited one. For >> more information please visit http://gump.apache.org/nagged.html, >> and/or contact the folk at gene...@gump

[PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-06 Thread Konstantin Kolinko
ns to such a change, please write so. I think that having SVN keywords in JavaDoc is not so useful, because - Classes do change often, but their JavaDoc do not so. - You know, to what TC release your JavaDoc corresponds to. Why to need more? Best regards, Konstantin Ko

Re: svn commit: r791670 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-06 Thread Konstantin Kolinko
TC 6.0 and trunk those files are in /.settings/output In TC 5.5 we have 5 projects (build, connectors, container, jasper, servletapi), each of them has in their ".classpath" files and thus its own bin subdirectory. Best regards, Konstantin Kolinko ---

Re: Minimum Ant version for Tomcat 5.5 (was Re: svn commit: r791159)

2009-07-07 Thread Konstantin Kolinko
2009/7/4 Konstantin Kolinko : >> New Revision: 791159 >> URL: http://svn.apache.org/viewvc?rev=791159&view=rev >> Log: >> proposal >> >> + >> +* Document minimum required Ant version to be 1.6.2, instead of 1.5.x >> +  Note, that http://to

Re: svn commit: r792462 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-09 Thread Konstantin Kolinko
wrong. In Windows bat files the tools.jar is always added (in 5.5; with existence check in 6.0), but I won't mind removing it from there, for consistency, and as hardly anyone uses them in production. The exe installer on Windows (I tried the 5.5 one) does not add tools.jar to the classpa

Re: [PROPOSAL] Remove build-webapps-precompile target from dist.xml of TC 6, TC 7. Or enable and fix it?

2009-07-09 Thread Konstantin Kolinko
2009/7/3 Mark Thomas : > Konstantin Kolinko wrote: >> Otherwise I'll propose removal of that "build-webapps-precompile" >> target from dist.xml of 6.0 and trunk. > > +1 to removing it from both > > Mark > There are enough votes in 6.0.x STATUS. R

Re: svn commit: r792872 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/tcp/mbeans-descriptors.xml webapps/docs/changelog.xml

2009-07-10 Thread Konstantin Kolinko
lication when > +        clustering was enabled. (markt) > +       > +       The svn:log message of this commit does not make sense for me. I suppose it is a copy-paste error. Best regards, Konstantin Kolinko - To unsub

Re: svn commit: r793766 - in /tomcat/trunk/modules/jdbc-pool: .classpath java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java

2009-07-13 Thread Konstantin Kolinko
0_14"/> I think the change to .classpath file in this commit was not expected. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r794671 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-07-16 Thread Konstantin Kolinko
pache.org/examples-taglib Though this inconsistency already existed before this patch. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [PROPOSAL] Remove Realm from GenericPrincipal

2009-07-16 Thread Konstantin Kolinko
881#c12 It is to allow a serializable Principal to be written out and read in during replication. Cannot test it, though, as I do not have relevant configuration now. Best regards, Konstantin Kolinko - To unsubscribe, e-mail

Re: svn commit: r795010 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-17 Thread Konstantin Kolinko
  Please only commit for 5.5.28 if you find time to test before Filip > tags later today. I already tested it on my 32-bit WinXP system, and it builds, installs and runs OK. I plan to also test it on Vista 64-bit (x86-64), but I have yet to reach that place. I do not have an IA64 system. Best

Re: svn commit: r795010 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-17 Thread Konstantin Kolinko
2009/7/17 Rainer Jung : > On 17.07.2009 12:01, Konstantin Kolinko wrote: >> If we backport the second part of rev.791699 - the separate zips for >> different windows CPU architectures, there wouldn't be such >> subdirectories, but "i64" will be in the name

Re: svn commit: r796162 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-21 Thread Konstantin Kolinko
runk/java/org/apache/catalina/connector/AsyncContextImpl.java > If you are wondering, this @Override on "methods implementing an interface" is a (not so well known) difference between Java 5 and Java 6. http://blogs.sun.com/ahe/entry/override http://blogs.sun.com/ahe/ent

Bug 47413 - difference in composite ${a}${b} EL expressions between 6.0.18 and 6.0.20

2009-07-22 Thread Konstantin Kolinko
s an a reproducer for this issue. I planned to resolve the issue first before proposing it, but as I am stuck here I will commit it. It will need some cleanup, though, and it is night now, so that will be in ca. 12 hours. Best regards, Konstantin Kolinko -

Re: 5.5.28 release candidate

2009-07-25 Thread Konstantin Kolinko
a duplicate copy of a file). It is true, though, as sebb once wrote, that RELEASE-NOTES contains clearly visible Tomcat version number, and you can see it there, if it is in the root folder, even if you replaced the ROOT webapp. Best regards, Konstantin Kolinko --

Re: Adding thumbs.db to svn:ignore?

2009-07-25 Thread Konstantin Kolinko
as [Tt]humbs.db or, generalizing it, [Tt][Hh][Uu][Mm][Bb][Ss].[Dd][Bb] Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [PROPOSAL] Remove Realm from GenericPrincipal

2009-08-02 Thread Konstantin Kolinko
t is not serializable. At least it means that that field will be transient, and probably that issue 39231 that that commit (with some followups) fixes won't/cannot be fixed for clusters. (I suppose so, though I may be wrong). http://svn.apache.org/viewvc?view=rev&revision=791900 https://iss

Re: svn commit: r803451 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-08-12 Thread Konstantin Kolinko
roupcom files? Early beta of Tribes? I just do not know their history. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Making AJP secret attribute consistent

2009-08-12 Thread Konstantin Kolinko
ml http://tomcat.apache.org/tomcat-6.0-doc/config/http.html (Index > Configuration Reference > AJP , / > HTTP ) I do not really mind renaming all of them to get rid of dots, but that is probably what we should not do. :/ Best regards, Konstantin Kolinko ---

Re: svn re-org complete

2009-08-12 Thread Konstantin Kolinko
27;s not necessary to > download the current trunk again. > > AFAICS, using http://tomcat.apache.org/tomcat-5.5-doc/build.xml is > only necessary if the user does not already have BUILDING.txt > > I can provide a patch. > Note, that there is also http://tomcat.apache.org/tomcat-5.5-doc/building.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: local changes on /www/tomcat.apache.org

2009-08-12 Thread Konstantin Kolinko
26th of March, 2009 is certainly a Tuesday this year, not a Friday. Looks like someone was making corrections in a rush before the event. By the way, "Apache Tomcat - Apache Tomcat" (repeated twice) is a lame title. And we have it on some other pages as well, like Apache Tomcat - Apache Tomcat --

Re: local changes on /www/tomcat.apache.org

2009-08-12 Thread Konstantin Kolinko
2009/8/13 Konstantin Kolinko : > 26th of March, 2009 is certainly a Thursday this year, not a Friday. Thursday > > Looks like someone was making corrections in a rush before the event. > > By the way, "Apache Tomcat - Apache Tomcat" (repeated twice) is a lame > title.

Re: Making AJP secret attribute consistent

2009-08-13 Thread Konstantin Kolinko
not dug into details yet, though. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Making AJP secret attribute consistent

2009-08-13 Thread Konstantin Kolinko
2009/8/13 Mladen Turk : > On 13/08/09 19:43, Konstantin Kolinko wrote: >>> >>> Other option is to use required.secret instead requiredSecret >>> Much easier because requiredSecret isn't document, so one >>> can only find it browsing the source code

Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread Konstantin Kolinko
sing VMWare Player (the free one), and have two different Linux VMs to run with it. Maybe I shouldn't be lazy to fire up one of them next time. Thanks for testing. Best regards, Konstantin Kolinko - To unsubscribe, e

Re: svn commit: r804530 - /tomcat/tc5.5.x/trunk/

2009-08-15 Thread Konstantin Kolinko
Mark, you could put your output into .settings/output, like the 6.0.x project does. ;) Anyway, I do not mind against this svn:ignore. It does no harm. 2009/8/16 : > Author: markt > Date: Sat Aug 15 20:44:01 2009 > New Revision: 804530 > > URL: http://svn.apache.org/viewvc?rev=804530&view=rev >

Eclipse project file for tc5.5.x

2009-08-15 Thread Konstantin Kolinko
resource is a duplicate of servletapi/jsr152/src/share/dtd/jsp_2_0.xsd and was not copied to the output folder jsp_2_0.xsd Path: /tomcat55/servletapi/jsr154/src/share/dtd/jsp_2_0.xsd " Best regards, Konstantin Kolinko

Re: [proposal] remove worker based connector thread pools in trunk

2009-08-15 Thread Konstantin Kolinko
config will not change at all. If you take a 6.0 config, > it would still work. > Furthermore, there is some really cool stuff we can do with executors, such > as even with the BIO connector, we can do keep alives and and still ro

Re: local changes on /www/tomcat.apache.org

2009-08-15 Thread Konstantin Kolinko
2009/8/13 Konstantin Kolinko : > 2009/8/13 Konstantin Kolinko : >> 26th of March, 2009 is certainly a Thursday this year, not a Friday. > Thursday >> >> Looks like someone was making corrections in a rush before the event. >> >> By the way, "Apache Tomc

Regarding JAAS logout patch (for bug 39231)

2009-08-15 Thread Konstantin Kolinko
side effects. (If there were any, this feature would have to be configurable). Though "logout" is a bit too loud name for it. Documentation on implementing LoginModule#logout() is here: http://java.sun.com/javase/6/docs/technotes/guides/security/jaas/JAASLMDevGuide.html#logout

Re: svn commit: r810132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-10-01 Thread Konstantin Kolinko
file name must be encoded as %25. The protocol handler for file: protocol unescapes %-encoded symbols when opening URLConnection to the file, so if the original file name contained '%' symbol, it should have been escaped. (sun.net.www.protocol.file.Handler#openConnection(..)) Best

Re: svn commit: r821411 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-10-03 Thread Konstantin Kolinko
will reuse that named window to show their page. I propose to replace that explicit name with a "_blank". "_blank" is a reserved name [1] and opens a new unnamed window (or tab in FF) [1] http://www.w3.org/TR/html401/types.html#type-frame-target see 6.16 Frame target names B

Re: tcnative in TC5.5: version properties

2009-10-04 Thread Konstantin Kolinko
TC-Native release? And use the same pre-built jar for TC 5.5, 6.0 and 7.0 releases. Is it an optional jar, that can be removed by ones that do not have the native dll/so installed? (In TC 6.0 those classes are in tomcat-coyote.jar now). Best

Re: svn commit: r823351 - in /tomcat/trunk/java/org/apache: coyote/http11/AbstractInputBuffer.java coyote/http11/Http11Processor.java coyote/http11/InternalInputBuffer.java coyote/http11/InternalNio

2009-10-08 Thread Konstantin Kolinko
uot; 2. The AbstractInputBuffer#log to be made non-static and use this.getClass().getName() (and remove Http11Processor#log, #sm and Http11NioProcessor#log, #sm) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-uns

Re: svn commit: r823351 - in /tomcat/trunk/java/org/apache: coyote/http11/AbstractInputBuffer.java coyote/http11/Http11Processor.java coyote/http11/InternalInputBuffer.java coyote/http11/InternalNio

2009-10-10 Thread Konstantin Kolinko
e is no such value in them (and that is right, because using some automatic value for keywords would be wrong) http://apache.org/dev/svn-eol-style.txt http://apache.org/dev/version-control.html#https-svn-config Best regards, Konstantin Kolinko -

Re: svn commit: r830736 - in /tomcat/trunk/java/org/apache/catalina/core: JreMemoryLeakPreventionListener.java LocalStrings.properties

2009-10-28 Thread Konstantin Kolinko
od should be better, in view of possible Java API changes. Also, "dummy.txt" part of the URL is not necessary. It would be sufficient to end the URL with "!/", see syntax here: http://java.sun.com/javase/6/docs/api/java/net/JarURLConnection.html Best regards, Konstantin Kolink

Re: svn commit: r830589 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2009-10-28 Thread Konstantin Kolinko
endpoint.getCurrentThreadsBusy() * 100) > +                    / endpoint.getMaxThreads(); > +        } I think that endpoint.getCurrentThreadsBusy() call is not cheap (and can provide different results between calls). It would be better to cache its result in a local

Re: svn commit: r831069 - in /tomcat/trunk: java/javax/servlet/http/Cookie.java webapps/docs/config/systemprops.xml

2009-10-29 Thread Konstantin Kolinko
ped) Also, "javax.servlet.http.Cookie. STRICT_NAMING" It would be better to name that "org.apache.tomcat.util.http. ServerCookie.STRICT_NAMING" as I think java(x)* property names are reserved by Sun. +org.apache.tomcat.util.http.ServerCookie.STRICT_NAMING. Note that the above line of the doc already uses the *.tomcat.* property name, but everywhere else in the patch the javax.servlet.* name was used. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r831116 - in /tomcat/trunk: java/javax/servlet/http/Cookie.java webapps/docs/config/systemprops.xml

2009-10-29 Thread Konstantin Kolinko
a >    tomcat/trunk/webapps/docs/config/systemprops.xml > Now it is OK for me. Thank you. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r832632 - in /tomcat/tc6.0.x/trunk: STATUS.txt bin/catalina.sh webapps/docs/changelog.xml

2009-11-03 Thread Konstantin Kolinko
2009/11/4 : > Author: markt > Date: Wed Nov  4 00:24:43 2009 > New Revision: 832632 > > URL: http://svn.apache.org/viewvc?rev=832632&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47699 > Better handling of PID files > > Modified: >    tomcat/tc6.0.x/trunk/STATUS.txt >  

Re: svn commit: r832039 - in /tomcat/trunk/java/org/apache/naming: HandlerRef.java ResourceRef.java ServiceRef.java StringManager.java resources/DirContextURLStreamHandler.java

2009-11-04 Thread Konstantin Kolinko
ubset of those 50+ patches, and there will be enough votes, I will be happy to commit it. One benefit would be better alignment of TC 7 and TC 6 code and thus easier backport of patches. The 6.0 -> 5.5 backports will need the StringBuilder -> StringBuffer conversion anyway, so those are unaffe

Re: SSL & Tomcat

2009-11-09 Thread Konstantin Kolinko
ecurity pages. > > Thoughts? > > Mark > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: SSL & Tomcat

2009-11-09 Thread Konstantin Kolinko
2009/11/9 Mark Thomas : > Konstantin Kolinko wrote: >> >> My understanding is that 1.1.17 and later require TC 6.0.21 and 5.5.29 >> and later and vice versa, because of some API changes, and thus won't >> be useful until those versions are released. > > That

Re: SSL & Tomcat

2009-11-09 Thread Konstantin Kolinko
it to our users as "javax.servlet.request.ssl_session" request attribute. Regarding valves (as mentioned in issue 48157): I understand, that that is not sufficient, but if anyone wants to check against malformed headers, they can do so. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r834544 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-11 Thread Konstantin Kolinko
vax.net.ssl.SSLEngine. Something else should be needed there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r880788 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-11-16 Thread Konstantin Kolinko
f not specified, the default value specification compliant + value of false will be used. The rest looks good. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additi

Re: svn commit: r881414 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-11-17 Thread Konstantin Kolinko
If anyone is wondering, the issue that has been fixed there is http://issues.apache.org/jira/browse/POOL-152 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Konstantin Kolinko
2009/11/19 : > Author: markt > Date: Wed Nov 18 23:54:24 2009 > New Revision: 882008 > > +        // If the thread is not bound, return a shared writable context > +        if (initialContext == null) { > +            if (initialContext == null) { > +                synchronized(this) { twice the

Re: svn commit: r882008 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2009-11-18 Thread Konstantin Kolinko
2009/11/19 Mark Thomas : > Konstantin Kolinko wrote: >> >> twice the same condition > > Thanks - I'll fix that. > OK, seen that. On second thought: it is strange to synchronize on "this" to set a static field. That should be synchronized(getCla

Re: svn commit: r883181 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-22 Thread Konstantin Kolinko
Unsigned"? (The original patch calls it "unsigned", but I do not like it. It looks like a reserved word, though it is not on the JLS list of reserved keywords - ch.3.9 of JLS ) Best regards, Konstantin Kolinko - To un

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-04-17 Thread Konstantin Kolinko
est/gump_file/TEST-org.apache.catalina.core.TestAsyncContextImpl.BIO.txt.html I have not investigated the cause. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Konstantin Kolinko
he file sequentially does not use the index and I think it will be slower. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Konstantin Kolinko
y) > - write entire file to temp location > - read required data from file > > New code: > - read file sequentially until we find the bit we want. > > On a reasonably complex app with quite a few JARs the start-up time went > from ~30s to ~12s with

Re: svn commit: r1095686 - in /tomcat/trunk/java/org/apache/jasper: compiler/DefaultErrorHandler.java resources/LocalStrings.properties

2011-04-22 Thread Konstantin Kolinko
ody not allowed for {0} >  jsp.error.jspbody.required=Must use jsp:body to specify tag body for {0} if > jsp:attribute is used. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: External Docroot support for Tomcat

2011-04-28 Thread Konstantin Kolinko
request in Bugzilla http://tomcat.apache.org/bugreport.html#Patches_and_enhancement_requests Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1099394 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml

2011-05-04 Thread Konstantin Kolinko
t;SOFTWARE\JavaSoft\Java Runtime Environment\$2" > "JavaHome" > +    ReadRegStr $3 HKLM "SOFTWARE\JavaSoft\Java Runtime Environment\$2" > "RuntimeLib" > + > +    IfErrors 0 +2 > +    StrCpy $1 "" > +    ClearErrors >   ${EndIf} (...) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: BIO performance issues

2011-05-04 Thread Konstantin Kolinko
+0 for b)..e), as I do not quite get them. An alternative could be to change the default value of maxConnections and calculate it from maxThreads. I wonder, maybe it is time to use the NIO connector as the default one in Tomcat 7. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: BIO performance issues

2011-05-04 Thread Konstantin Kolinko
2011/5/4 Mark Thomas : > On 04/05/2011 12:04, Konstantin Kolinko wrote: >> I do not quite get what happens in 6s. My first understanding from >> reading the scenario was that the threads at 2s are busy because we >> need them to process keep-alive connections. Then I see tha

Re: Why AstValue (part of EL) coerces set value to the target type

2011-05-08 Thread Konstantin Kolinko
c is in ch.2.15. The getType() call there is documented to return Object.class. Implementation of javax.el.ELResolver#getType() in trunk performs a bit differently. BTW, a workaround in your case might be to do assignment in two steps: first assign null, and then assign the actual value. Best reg

Re: svn commit: r1095686 - in /tomcat/trunk/java/org/apache/jasper: compiler/DefaultErrorHandler.java resources/LocalStrings.properties

2011-05-08 Thread Konstantin Kolinko
2011/4/22 Konstantin Kolinko : > 2011/4/21  : >> Author: markt >> Date: Thu Apr 21 12:50:40 2011 >> New Revision: 1095686 >> >> URL: http://svn.apache.org/viewvc?rev=1095686&view=rev >> Log: >> i18n for r1090763 >> >>

<    1   2   3   4   5   6   7   8   9   10   >