2009/6/19 <ma...@apache.org> > http://svn.apache.org/viewvc?rev=785768&view=rev > http://svn.apache.org/viewvc?rev=785859&view=rev > +1: kkolinko > + +1: markt - I don't like commenting out code - if it isn't needed just > delete it > + - This is fine for 6.0.x, for trunk 1.6 is the minimum > -1: O.K, understood.
I will update trunk to default to 1.6, for both EmbeddedServletOptions and JspC. It is funny, that compilerTargetVM value in JspC in 6.0 defaults to "1.4" (that differs from the one in EmbeddedServletOptions), but I do not feel it is worth to update it to "1.5" there. (The only reason I might see for that is to align the code with documentation). Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
