2009/6/24 Mladen Turk <mt...@apache.org>:
> Konstantin Kolinko wrote:
>>
>> Minor issues:
>>
>> apache-tomcat-6.0-snapshot.tar.gz
>>  has bin/service.bat,
>>  while *.zip does not have the file.
>>
>
> Probably missing exclude rule.
>
>> apache-tomcat-6.0-snapshot-windows-x86.zip
>>  has two identical copies of each of bin/tomcat6.exe and
>> bin/tomcat6w.exe  (both copies are in the bin/ folder)
>>
>
> Hmm, zips produced on my side have:
> tomcat6.exe 56K and tomcat6w.exe of 96K.
> for apache-tomcat-6.0-snapshot-windows-x86.zip
>

It has two identical copies of the file.

My zip archiver shows them. Or, using jar -t:
> "C:\Program Files\Java\jdk1.6.0_14\bin\jar" -tf 
> apache-tomcat-6.0-snapshot-windows-x86.zip | find "exe"
apache-tomcat-6.0-snapshot/bin/tomcat6.exe
apache-tomcat-6.0-snapshot/bin/tomcat6w.exe
apache-tomcat-6.0-snapshot/webapps/docs/config/executor.html
apache-tomcat-6.0-snapshot/webapps/examples/jsp/images/execute.gif
apache-tomcat-6.0-snapshot/webapps/examples/servlets/images/execute.gif
apache-tomcat-6.0-snapshot/bin/tomcat6.exe
apache-tomcat-6.0-snapshot/bin/tomcat6w.exe

In dist.xml:
    <zip 
zipfile="${tomcat.release}/v${version}/bin/${final.name}-windows-x86.zip">
..
        <exclude name="bin/i64/"/>
        <exclude name="bin/*.dll"/>
      </zipfileset>
      <zipfileset dir="${tomcat.dist}/bin" prefix="${final.name}/bin">
        <include name="*.dll"/>
        <include name="*.exe"/>
      </zipfileset>
    </zip>

Either
 add "<exclude name="bin/*.exe"/>" to the first zipfileset,
or simpler:
        <exclude name="bin/i64/"/>
      </zipfileset>
    </zip>
- remove "<exclude name="bin/*.dll"/>" and the second zipfileset won't
be needed.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to