Regarding FastCommonAccessLogValve and ExtendedAccessLogValve:

FastCommonAccessLogValve:

>> There is a bug, that sneaked in rev.781753
>> http://svn.apache.org/viewvc?rev=781753&view=rev
>> That is:
>> the timeZoneNoDST field is never assigned and remains null
>> It was ok in 5.5.27.
>
> That is an error in my backport. That line should never have been deleted. 
> I'll
> fix that now.

That backport should be applied to FastCommonAccessLogValve as well.
The bug #46982 is not fixed there yet.


ExtendedAccessLogValve:

The patch for ExtendedAccessLogValve is broken.

See the getDate() function there.
"currentDate.getTime()" cannot be called unless this Date instance is
local to this thread, but it is not there.  Also, that Date object is
returned by that function and can be used by other threads while
getDate() modifies it.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to