Re: Tagging Tomcat 7/8.0

2017-11-30 Thread Konstantin Kolinko
2017-11-30 13:28 GMT+03:00 Mark Thomas : > On 30/11/17 10:24, Konstantin Kolinko wrote: >> 2017-11-30 11:51 GMT+03:00 Violeta Georgieva : >>> Hi, >>> >>> I'm planning to start preparing Tomcat 7/8.0 for a release later today. >>> If you would l

Re: Migrating to git

2017-12-06 Thread Konstantin Kolinko
7;m sure we'll be able to work something out. tomcat-native uses svn:externals link to Tomcat source tree and has a step in release script that checks that this svn:external is up-to-date. All that needs a replacement. mod_jk is OK, does not have such dependency, if I remember correctly. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1817280 [1/2] - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/dbcp/pool2/ java/org/apache/tomcat/dbcp/pool2/impl/ webapps/docs/

2017-12-06 Thread Konstantin Kolinko
2017-12-06 13:33 GMT+03:00 : > Author: markt > Date: Wed Dec 6 10:33:04 2017 > New Revision: 1817280 > > URL: http://svn.apache.org/viewvc?rev=1817280&view=rev > Log: (empty) The log message is empty. - To unsubscribe, e-mail:

Re: [VOTE] Release Apache Tomcat 7.0.83

2017-12-11 Thread Konstantin Kolinko
va 8u152. Generally, it looks OK. 3. There is an issue noted when testing the Async example, I filed it into bugzilla https://bz.apache.org/bugzilla/show_bug.cgi?id=61886 It needs further investigation. I am voting "Broken" bec

Re: [VOTE] Release Apache Tomcat 7.0.83

2017-12-11 Thread Konstantin Kolinko
2017-12-11 15:37 GMT+03:00 Rainer Jung : > Hi Konstantin, > > Am 11.12.2017 um 12:30 schrieb Konstantin Kolinko: > ... >> >> The following test fails with 8u152, regardless of connector: >> org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream >> [[[

Re: svn commit: r1817800 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/security/SecurityClassLoad.java webapps/docs/changelog.xml

2017-12-12 Thread Konstantin Kolinko
2017-12-11 20:47 GMT+03:00 : > Author: markt > Date: Mon Dec 11 17:47:03 2017 > New Revision: 1817800 > > URL: http://svn.apache.org/viewvc?rev=1817800&view=rev > Log: > Pre-load additional classes to prevent SecurityExceptions if the first > request received when running under a security manager

Re: Migrating to git

2017-12-12 Thread Konstantin Kolinko
6.0.x I sometimes observed a delay of ~30 minutes.) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-bio (in module tomcat-8.0.x) failed

2017-12-13 Thread Konstantin Kolinko
, splits it by ';' and concatenates with ${line.separator}. It is as if the original string is delimited with ':' instead of ';' (due to some change in JUnit), or ${line.separator} was changed to be ':' (with a -D or with System.setProperty()). Bes

Re: svn commit: r1817993 - /gump/metadata/project/tomcat-trunk.xml

2017-12-14 Thread Konstantin Kolinko
Hi, Mark! To dev@tomcat, cc: general@gump. The result of this change is that Gump building Tomcat downloads tar.gz for Commons-Daemon from mirrors. The logs [1]: [[[ trydownload: [get] Getting: http://www.apache.org/dyn/closer.lua?action=download&filename=/commons/daemon/source/commons-dae

Re: Tagging 9.0.x and 8.5.x

2018-01-08 Thread Konstantin Kolinko
data, and I think that Tomcat won't ignore a fatal handshake error. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.3

2018-01-15 Thread Konstantin Kolinko
re is Mark's collection closure cleanup patch in discussion. Well, both can be applied to a stable version. It just feels that some review and sweeping are still going / may be pending. Nothing specific on my todo list though. Best regards, Konstantin Kolinko ---

Re: 8.5.25 release build

2018-01-16 Thread Konstantin Kolinko
2018-01-16 16:53 GMT+03:00 Mark Thomas : > > Our friendly Symantec (well, Digicert now) contact has got the issue > fixed. I'll have the 8.5.26 RC out later today. Reviewing the commits for 8.5.25, there is a copy-paste bug in BZ 61916 fix. java/org/apache/catalina/filters/AddDefaultCharsetFilte

Re: Responsive Website for tomcat.apache.org

2018-01-24 Thread Konstantin Kolinko
tion is provided on this site (see the links at the left) and is searchable (see an input box above)." 4. Accessibility. Is it possible to operate the site without having a mouse? If menu is closed, I cannot access the hamburger b

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Konstantin Kolinko
2018-01-25 10:00 GMT+03:00 Violeta Georgieva : > 2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org : >> >> Konstantin, >> >> I'd be happy to make all the necessary corections. >> >> On 1/24/2018 2:44 AM, Konstantin Kolinko wrote: >>> >>> 1.

Re: Responsive Website for tomcat.apache.org

2018-01-25 Thread Konstantin Kolinko
2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org : > Violeta, Konstantin, > > On 1/25/2018 3:57 AM, Konstantin Kolinko wrote: >> >> 2018-01-25 10:00 GMT+03:00 Violeta Georgieva : >>> >>> Here is what I see with Chrome, Firefox and Safari >>> https:/

Re: Responsive Website for tomcat.apache.org

2018-01-26 Thread Konstantin Kolinko
when the hamburger menu icon has focus. > > Here is what I see after applying the patch to the website: > https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822263 > > Regards, > Violeta It looks OK now, after I regenerated the docs - r1822283 . Print view is

Re: svn commit: r1822644 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http2/ java/org/apache/tomcat/util/http/parser/ w

2018-01-30 Thread Konstantin Kolinko
Best regards, Konstantin Kolinko 2018-01-30 16:59 GMT+03:00 : > Author: markt > Date: Tue Jan 30 13:59:11 2018 > New Revision: 1822644 > > URL: http://svn.apache.org/viewvc?rev=1822644&view=rev > Log: > Enable strict host/port validation for all connectors. > > M

Re: svn commit: r1823160 - in /tomcat/tc7.0.x/trunk/webapps/examples/servlets/chat: index.jsp login.jsp post.jsp

2018-02-05 Thread Konstantin Kolinko
2018-02-05 15:38 GMT+03:00 : > Author: kkolinko > Date: Mon Feb 5 12:38:30 2018 > New Revision: 1823160 > > URL: http://svn.apache.org/viewvc?rev=1823160&view=rev > Log: > Remove svn:keywords property. It is unused here, and not compatible with Git. > > svn propdel svn:keywords -R . For a record

Re: svn commit: r1851231 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml

2019-01-14 Thread Konstantin Kolinko
пн, 14 янв. 2019 г. в 11:55, : > > Author: remm > Date: Mon Jan 14 08:55:13 2019 > New Revision: 1851231 > > URL: http://svn.apache.org/viewvc?rev=1851231&view=rev > Log: > 63072: Remove extras > > Modified: > tomcat/trunk/build.xml > tomcat/trunk/webapps/docs/changelog.xml > > Modified: t

Re: Extras

2019-01-14 Thread Konstantin Kolinko
istener [1] (nightly docs build for 9.0) still mentions catalina-jmx-remote.jar. [1] https://ci.apache.org/projects/tomcat/tomcat9/docs/config/listeners.html#JMX_Remote_Lifecycle_Listener_-_org.apache.catalina.mbeans.JmxRemoteLifecycleListener Best regards, Konstantin Kolinko ---

Re: svn commit: r1852848 - in /tomcat/tags/TOMCAT_9_0_15: ./ build.properties.default webapps/docs/changelog.xml

2019-02-04 Thread Konstantin Kolinko
пн, 4 февр. 2019 г. в 11:31, Mark Thomas : > > Sorry for the delay [...] By the way, NSIS can be updated to 3.04 (released in December) https://nsis.sourceforge.io/Main_Page Best regards, Konstantin Kolinko - To unsubscr

Re: POEditor admins

2019-02-04 Thread Konstantin Kolinko
b account. It looks that the name is linked to my @gmail email. Do you see it, and can grant the rights? I updated Russian translations for Manager & Host Manager. Can you pick them up? Best regards, Konstantin Kolinko - To u

Re: [VOTE] Release Apache Tomcat 9.0.16

2019-02-04 Thread Konstantin Kolinko
sponds with 404: 404 - Repository "orgapachetomcat-1202 (staging: open)" [id=orgapachetomcat-1202] exists but is not exposed. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For add

Re: Tag Tomcat 7

2019-02-11 Thread Konstantin Kolinko
пт, 8 февр. 2019 г. в 15:59, Violeta Georgieva : > > Hi, > > I'm planning to tag Tomcat 7 later today or tomorrow. > If you want to include something please reply here. I did what I planned for today. I think it is OK to go. Best regards

Re: Tag Tomcat 7

2019-02-11 Thread Konstantin Kolinko
/bz.apache.org/bugzilla/show_bug.cgi?id=63041 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Confirming that UTF-7 is not a typo in Tomcat docs

2019-02-13 Thread Konstantin Kolinko
5. (Discussion in 414064 cites HTML 5 document and mentions some places where UTF7 was used at that time, in year 2010). https://en.wikipedia.org/wiki/UTF-7 https://bugzilla.mozilla.org/show_bug.cgi?id=414064 Best regards, Konstantin Kolinko --

Re: Tag Tomcat 7

2019-02-16 Thread Konstantin Kolinko
t; I think there might be one more item to back-port from Konstantin, who > > has not yet committed his changes to trunk/8.5. Given the time between > > Tomcat 7 releases, can you maybe delay another 24-48 hours to see if > > he wants to get his patch into Tomcat 7? > > Ok, n.p. I co

Re: [VOTE] Release Apache Tomcat 7.0.93

2019-02-21 Thread Konstantin Kolinko
tly. I filed an issue: https://bz.apache.org/bugzilla/show_bug.cgi?id=63194 Smoke testing with Java 8 and with Java 11 is OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additio

Re: Git migration: new branch/tag naming scheme

2019-02-25 Thread Konstantin Kolinko
hough somebody may call that magic as well. [6] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/cut.html [7] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02 Best regards, Konstantin Kolinko

Re: [tomcat] branch master updated: Remove further remains of the extras package.

2019-02-26 Thread Konstantin Kolinko
tter much, but note that you are not using an @apache.org e-mail in your commit info above. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Git migration read for testing

2019-02-26 Thread Konstantin Kolinko
it mirror for the current site repository and to see whether it is usable. At this point, I think that Subversion is better tool for managing the site. I do not expect much from Git. [1] https://briancoyner.github.io/2013/06/05/git-sparse-checkout.html Best regards, Konstantin Kolinko -

Re: Tomcat Site Redesign

2019-03-07 Thread Konstantin Kolinko
e part of a sentence. How do you read that sentence aloud (in English)? (Actually, the dates should not be in the sentence. They are a separate auxiliary piece of information). 4) Search field (in menu bar): It is too small for any real te

Tagging Tomcat releases with Git

2019-03-08 Thread Konstantin Kolinko
efault - Increment the build number and add "-dev" suffix in build.properties.default - Mark the current version as "vote in progress" and a section for the new version in changelog.xml. 11. Commit and push. Best regards, Konstantin Kolinko ---

Re: Default Number of Test Threads

2019-03-15 Thread Konstantin Kolinko
n at Buildbot to run the coverage tests once a day (scheduled by time). I do not remember whether that configuration is explicitly configured with thread count of 1. It may be that the other configurations a configured with an explicit count of threads, but this one has not been configured.

Re: Wiki migration

2019-03-15 Thread Konstantin Kolinko
also exists the following project, http://jspwiki.apache.org/ if we talk about "our own dog food". Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1856174 [1/29] - in /tomcat/site/trunk: docs/ xdocs/ xdocs/stylesheets/

2019-03-25 Thread Konstantin Kolinko
it to "no" did broke something. (3) Technically, I think it is possible to download a specific version of Apache Xalan and configure the "xslt" task of Apache Ant to use it. https://ant.apache.org/manual-1.9.x/Tasks/st

Re: Tomcat Site Redesign

2019-03-25 Thread Konstantin Kolinko
Sorry that it takes so long, but I am rather overwhelmed nowadays, and I need to set priorities... сб, 9 мар. 2019 г. в 00:15, Igal @ Lucee.org : > > All, > > On 3/7/2019 3:22 AM, Konstantin Kolinko wrote: > > > пн, 4 мар. 2019 г. в 09:02, Igal Sapir : > >> I

Re: Wiki migration

2019-03-25 Thread Konstantin Kolinko
пт, 15 мар. 2019 г. в 21:32, Mark Thomas : > > On 15/03/2019 18:05, Konstantin Kolinko wrote: > > пт, 15 мар. 2019 г. в 20:07, Mark Thomas : > >> > >> All, > >> > >> I am going to attempt the wiki migration. [...] > > > 2. Links used by Con

Re: [tomcat] 01/01: Fix wrong protocol version usage

2019-03-31 Thread Konstantin Kolinko
-1 (veto). This was discussed several years ago, and the decision was to use "HTTP/2.0" https://bz.apache.org/bugzilla/show_bug.cgi?id=58605 вс, 31 мар. 2019 г. в 11:04, : > > This is an automated email from the ASF dual-hosted git repository. > > michaelo pushed a commit to branch wrong-http2-ve

Re: commons-daemon packaging question

2019-04-05 Thread Konstantin Kolinko
> 5. 2) It is referenced by Class-Path attribute of bootstrap.jar/META-INF/MANIFEST.MF (If it is missing, people may ask. If something else is placed under that name, it will be in Tomcat classpath.) Best regards, Konstantin Kolinko ---

Re: [VOTE] Release Apache Tomcat 7.0.94

2019-04-11 Thread Konstantin Kolinko
in the failures above. 4) I did not observe these failures when I tested Tomcat 7.0.93. Buildbot and Gump do not reproduce them either. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-11 Thread Konstantin Kolinko
yteBuffer.mark()" call at Http11InputBuffer.java:726, several lines above the reset() call that fails. This does not cause a test case failure. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@to

Re: buildbot failure in ASF Buildbot on tomcat-8-trunk

2015-05-26 Thread Konstantin Kolinko
nt version of Cobertura, I have not backported r1663472. I mean that the local build likely has not enabled Cobertura. So it is not it.) Maybe the version of Apache Ant? E.g. Ant having junit jars in its lib directory? Or just an old version of Ant? Best regards, Konstantin Kolinko

Re: [RESULT][VOTE] Release Apache Tomcat 8.0.23

2015-05-26 Thread Konstantin Kolinko
The 8.0.23 is already on mirror servers. There have been no announcement yet, nor website update. I added the version number into Bugzilla. Best regards, Konstantin Kolinko 2015-05-22 12:42 GMT+03:00 Mark Thomas : > Closing the vote now so I have a chance to get the release out before &g

Re: svn commit: r1681845 - in /tomcat/site/trunk: docs/images/ACNA2010_120x240_basic.gif xdocs/images/ACNA2010_120x240_basic.gif

2015-05-26 Thread Konstantin Kolinko
2015-05-26 23:24 GMT+03:00 : > Author: markt > Date: Tue May 26 20:24:31 2015 > New Revision: 1681845 > > URL: http://svn.apache.org/r1681845 > Log: > Remove old ApacheCon ad > > Removed: > tomcat/site/trunk/docs/images/ACNA2010_120x240_basic.gif > tomcat/site/trunk/xdocs/images/ACNA2010_1

Re: End of life for 6.0.x

2015-05-29 Thread Konstantin Kolinko
until February 2016 * Debian 7 “Wheezy” from February 2016 to May 2018 * Debian 8 “Jessie“ from May 2018 to April/May 2020" So from that I think that September 2016 is OK. Tomcat 5.5 EOL'ed on 30 September 2012. http://tomcat.apache.org/tomcat-55-eol.html Best regards, Konstantin Ko

Re: svn commit: r1684233 - in /tomcat/trunk: java/org/apache/coyote/http2/ test/org/apache/coyote/http2/

2015-06-09 Thread Konstantin Kolinko
t like this naming. > StreamError.java > ConnectionError.java Those are not instances of java.lang.Error, but ones of java.lang.Exception. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apac

Re: HTTP2 parsing and error handling

2015-06-09 Thread Konstantin Kolinko
s likely to be a > largish commit to switch to this new approach but I'll try and keep that > commit limited to changing the error handling. +1 One bonus from a flag vs. an exception is that it can be sticky. I mean a situation like one fixed by this commit: http://svn

Re: tc-native and multiple certificates for a single virtual host

2015-06-23 Thread Konstantin Kolinko
an ECC key? > > > Using 3 I guess but I don't see a different handling for the different type > of key/cert... Basically it looks like the latest call tells which key/cert > will be used. > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1688911 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2015-07-03 Thread Konstantin Kolinko
gt; false) != null) { OK. The above was a copy-paste fix from extracting common code into as method in r1688909. The error was that socketStatus argument was not used. Best regards, Konstantin Kolinko > Modified: > tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Re: svn commit: r1690035 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/ java/org/apache/catalina/ha/deploy/ webapps/docs/

2015-07-09 Thread Konstantin Kolinko
tion slightly that under normal conditions it will close the stream twice (once in execute() and second in finally()), but closing the same stream twice is allowed in Java. http://docs.oracle.com/javase/6/docs/api/java/io/Closeable.

Re: svn commit: r1690035 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/ java/org/apache/catalina/ha/deploy/ webapps/docs/

2015-07-09 Thread Konstantin Kolinko
2015-07-09 15:29 GMT+03:00 Violeta Georgieva : > Hi, > > 2015-07-09 14:50 GMT+03:00 Konstantin Kolinko : >> >> 2015-07-09 12:06 GMT+03:00 : >> > Author: violetagg >> > Date: Thu Jul 9 09:06:25 2015 >> > New Revision: 1690035 >> > >&

Re: [Bug 57837] add "text/css" to default of compressableMimeType

2015-07-14 Thread Konstantin Kolinko
Comment #9 from Violeta Georgieva --- >> > +1 for javascript >> >> I would like to add text/javascript and application/javascript also as > defaults. >> Do you have any objection? >> > > I'm going to commit this change if there are no objection

Re: Time for a mod_jk release?

2015-07-17 Thread Konstantin Kolinko
w.apachelounge.com/download/ [2] http://www.apachelounge.com/viewtopic.php?t=6586 [3] http://www.apachelounge.com/viewtopic.php?t=6649#31076 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1689346 - in /tomcat/trunk: java/org/apache/catalina/webresources/ test/org/apache/catalina/webresources/ test/webapp/WEB-INF/classes/org/ test/webapp/WEB-INF/classes/org/apache/ test

2015-07-19 Thread Konstantin Kolinko
y such move (I mean lines like "new File("test/webapp/WEB-INF/classes");" below). So I opt for 1) for now. Best regards, Konstantin Kolinko 2015-07-06 12:29 GMT+03:00 : > Author: markt > Date: Mon Jul 6 09:29:44 2015 > New Revision: 1689346 > > URL: http

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2015-07-21 Thread Konstantin Kolinko
g/apache/catalina/ant/TestDeployTask.java:71: cannot find symbol [...] This is not a new error. There have been no (zero) successful builds of TC7 since July 01st when buildbot master was reconfigured. Apparently javac task in "test-compile" target needs s/ includeantruntime="fa

Re: svn commit: r1692057 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/QueryTimeoutInterceptor.java webapps/docs/changelog.xml

2015-07-21 Thread Konstantin Kolinko
2015-07-21 10:01 GMT+03:00 : > Author: kfujino > Date: Tue Jul 21 07:01:44 2015 > New Revision: 1692057 > > URL: http://svn.apache.org/r1692057 > Log: > Fix potential NPE in QueryTimeoutInterceptor. > > Modified: > > tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/

Re: svn commit: r1696390 - /tomcat/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java

2015-08-18 Thread Konstantin Kolinko
2015-08-18 13:48 GMT+03:00 : > Author: markt > Date: Tue Aug 18 10:48:27 2015 > New Revision: 1696390 > > URL: http://svn.apache.org/r1696390 > Log: > Try and make logging available for all tests in a class, not just the first. > > Modified: > tomcat/trunk/test/org/apache/catalina/startup/Logg

Re: svn commit: r1696404 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawMessage.java

2015-08-18 Thread Konstantin Kolinko
2015-08-18 14:44 GMT+03:00 : > Author: markt > Date: Tue Aug 18 11:44:43 2015 > New Revision: 1696404 > > URL: http://svn.apache.org/r1696404 > Log: > Remove unused code > > Modified: > > tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawMessage.java > > Modified: > tomca

Re: svn commit: r1696404 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawMessage.java

2015-08-18 Thread Konstantin Kolinko
2015-08-18 15:39 GMT+03:00 Mark Thomas : > On 18/08/2015 12:58, Konstantin Kolinko wrote: >> 2015-08-18 14:44 GMT+03:00 : >>> Author: markt >>> Date: Tue Aug 18 11:44:43 2015 >>> New Revision: 1696404 >>> >>> URL: http://svn.apache.org/r16

Re: svn commit: r1700900 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/util/RequestUtil.java

2015-09-02 Thread Konstantin Kolinko
>> Modified: >> tomcat/tc6.0.x/trunk/STATUS.txt >> tomcat/tc6.0.x/trunk/java/org/apache/catalina/util/RequestUtil.java > > Bah. I applied the patch as well. > > Any chance of a couple of quick +1's from oth

Re: svn commit: r1702779 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/storeconfig/StoreLoader.java

2015-09-13 Thread Konstantin Kolinko
ogs/stdio https://ci.apache.org/builders/tomcat-trunk/builds/249/steps/compile/logs/stdio So it did not increase the number of javadoc warnings when building with java 8, but it did not decrease their number either. So this change was not justified by javadoc warnings. I have not reviewed the actual javadoc generated by this change. Documentation published by Buildbot does not include javadoc, so I'd need to build it locally. So I do not see any technical issues yet. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1702887 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2015-09-14 Thread Konstantin Kolinko
l() of NioEndpoint etc., so in theory it is possible to call start() on endpoint if it has not been destroy()ed yet. Nulling the reference changes behaviour of such start(). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1702932 - /tomcat/trunk/java/org/apache/el/parser/SimpleCharStream.java

2015-09-14 Thread Konstantin Kolinko
2015-09-14 15:48 GMT+03:00 : > Author: markt > Date: Mon Sep 14 12:48:08 2015 > New Revision: 1702932 > > URL: http://svn.apache.org/r1702932 > Log: > Remove deprecated code > > Modified: > tomcat/trunk/java/org/apache/el/parser/SimpleCharStream.java > > Modified: tomcat/trunk/java/org/apache/

Re: svn commit: r1702765 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/ java/org/apache/tomcat/util/http/res/

2015-09-14 Thread Konstantin Kolinko
as it is bad to rely on deprecated methods. But the reason for deprecation says that the method is ambiguous, not that it is broken. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

2015-02-27 Thread Konstantin Kolinko
aglibs-standard-impl-*.jar has to be added to "tomcat.util.scan.StandardJarScanFilter.jarsToSkip" setting in conf/catalina.properties to exclude it during TLD scanning, as the jar contains no TLDs. That setting already has "jstl.jar" but not the new file name. (The examples app should log a w

Re: [GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2015-02-27 Thread Konstantin Kolinko
2015-02-28 0:41 GMT+03:00 Bill Barker : > To whom it may engage... > > This is an automated request, but not an unsolicited one. For > more information please visit http://gump.apache.org/nagged.html, > and/or contact the folk at gene...@gump.apache.org. > > Project tomcat-trunk-test-nio2 has an is

Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

2015-02-27 Thread Konstantin Kolinko
2015-02-28 6:57 GMT+03:00 Jeremy Boynes : > On Feb 27, 2015, at 6:43 PM, Jeremy Boynes wrote: >> >> On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko >> wrote: >>> >>> 2015-02-27 19:26 GMT+03:00 : >>>> Author: jboynes >>>> Date: Fr

Re: Taglibs sub-site

2015-03-02 Thread Konstantin Kolinko
-native. The site is built with Ant. The code uses different tools.) +1 to move site to Ant. +0.5 for everything else. (I'll see how it goes. It is better to review the actual changes). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Time for Taglibs to be sent to the archive?

2015-03-02 Thread Konstantin Kolinko
hat though as I am not sure whether it is worth to spend time on that. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1663715 - in /tomcat/trunk/java/org/apache/catalina/startup: ExpandWar.java HostConfig.java LocalStrings.properties

2015-03-03 Thread Konstantin Kolinko
n be used to copy a timestamp from another file). One more example: the war and expanded directory are stored in svn or git. Those do not track time stamps of directories. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Tests compilation failed (Was: [GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed)

2015-03-03 Thread Konstantin Kolinko
2015-03-03 22:31 GMT+03:00 Bill Barker : > To whom it may engage... > > > Full details are available at: > > http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html Tests failed to compile. Apparently "final" modifier is needed. > test-compile: > [javac] C

Re: WAR FileSystem for fast nested JAR access?

2015-03-04 Thread Konstantin Kolinko
d as the current implementation that scans the jar, unless the war has zero compression. Also 1. Reading the zip index takes time and would better be cached. That is the issue behind https://bz.apache.org/bugzilla/show_bug.cgi?id=52448 2. It makes sense to cache the list of directories (

Re: svn commit: r1663995 - /tomcat/trunk/webapps/docs/config/valve.xml

2015-03-04 Thread Konstantin Kolinko
2015-03-04 16:57 GMT+03:00 : > Author: markt > Date: Wed Mar 4 13:57:21 2015 > New Revision: 1663995 > > URL: http://svn.apache.org/r1663995 > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=56058 > Add some links to the AccessLogValve to pages on how to configure Tomcat / > reverse pr

Re: [GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2015-03-04 Thread Konstantin Kolinko
2015-03-04 17:55 GMT+03:00 Bill Barker : > To whom it may engage... > > > Full details are available at: > > http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/index.html >[concat] Testsuites with failed tests: >[concat] > TEST-org.apache.catalina.startup.TestH

Re: [Tomcat Wiki] Update of "Security/Ciphers" by markt

2015-03-06 Thread Konstantin Kolinko
2015-03-06 14:46 GMT+03:00 Apache Wiki : > Dear Wiki user, > > You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for > change notification. > > The "Security/Ciphers" page has been changed by markt: > https://wiki.apache.org/tomcat/Security/Ciphers > > Comment: > Create page wit

Re: Time for 7.0.60

2015-03-06 Thread Konstantin Kolinko
ehaviour that I am observing. This is a fresh build of current TC7 (@r1664675), running on java 6u45, Firefox 36.0.1. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additi

Re: Time for 7.0.60

2015-03-10 Thread Konstantin Kolinko
2015-03-06 20:19 GMT+03:00 Konstantin Kolinko : > 2015-03-05 22:39 GMT+03:00 Violeta Georgieva : >> Hi, >> >> I plan to start preparing 7.0.60 for voting. >> >> If you want to add something to this release please reply here. >> > > Testing the examples

Re: Tomcat native 1.1.33 release

2015-03-12 Thread Konstantin Kolinko
etter security options. I agree that we would better wait a bit for 1.0.2a, b, or c. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Standard Taglib 1.2.5

2015-03-13 Thread Konstantin Kolinko
ava 5u20, Security Manager enabled - runs OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 57570] Make processing of chunked encoding trailers an opt-in feature (align with HTTPD 2.4.12)

2015-03-13 Thread Konstantin Kolinko
after the entity has been consumed? > > I have a use case where this might be quite useful and before I write-up > a POC, I'd like to know what to expect. > Yes. See the testcase, that I mentioned in BZ TestChunkedInputFilter$EchoHeaderServlet Best regards, Konstantin K

Re: svn commit: r1666503 - in /tomcat/tc8.0.x/trunk: ./ build.xml test/org/apache/tomcat/util/net/localhost-cert.pem test/org/apache/tomcat/util/net/localhost-key.pem

2015-03-13 Thread Konstantin Kolinko
; --- tomcat/tc8.0.x/trunk/build.xml (original) >> +++ tomcat/tc8.0.x/trunk/build.xml Fri Mar 13 16:26:24 2015 >> @@ -273,6 +273,7 @@ >> >> >> >> + > > This will make checkstyle freak out, since our pem has spaces at the end of >

Re: svn commit: r1664875 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/ test/org/apache/catalina/startup/ test/org/apache/coyote/ajp/ webapps/docs/

2015-03-15 Thread Konstantin Kolinko
private final Map params = > @@ -525,6 +526,20 @@ public abstract class TomcatBaseTest ext > (attribute != null ? attribute : "(null)")); > } > } Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Is it mandatory to create a bug to submit a patch (minor spell changes in the code comments)

2015-03-16 Thread Konstantin Kolinko
t rules: http://tomcat.apache.org/lists.html#tomcat-users - No attachments - Do not top-post. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1665888 - /tomcat/native/branches/1.1.x/native/src/poll.c

2015-03-16 Thread Konstantin Kolinko
(!remove) now = apr_time_now(); Line 379-385 the "else" branch: else { /* Update last active with the current time * after the poll call. */

Re: svn commit: r1667025 - in /tomcat/tags/TOMCAT_NATIVE_1_1_33: ./ native/include/tcn_version.h

2015-03-16 Thread Konstantin Kolinko
2015-03-16 18:05 GMT+03:00 : > Author: markt > Date: Mon Mar 16 15:05:36 2015 > New Revision: 1667025 > > URL: http://svn.apache.org/r1667025 > Log: > Tag 1.1.33 > > Added: > tomcat/tags/TOMCAT_NATIVE_1_1_33/ (props changed) > - copied from r1667024, tomcat/native/branches/1.1.x/ Note

Re: svn commit: r1663784 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/startup/ webapps/docs/config/

2015-03-20 Thread Konstantin Kolinko
1) I see no changelog entry for this new feature. Bugzilla reference: https://bz.apache.org/bugzilla/show_bug.cgi?id=57251#c31 2) A user is asking that this feature is mentioned in Tomcat 7 docs, as if it is already working http://tomcat.apache.org/tomcat-7.0-doc/deployer-howto.html#post_3798 [

Re: [VOTE] Release Apache Tomcat Native 1.1.33

2015-03-23 Thread Konstantin Kolinko
), Tomcat 8 (@r1668559), Tomcat 7 (@r1668555). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.61

2015-03-30 Thread Konstantin Kolinko
ssor. testNon2xxResponseWithExpectation() test Not our fault. All tests pass successfully with Java 7 and Java 8. [1] http://markmail.org/message/fbo4fnyvtqycasfy Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-un

Re: svn commit: r1670287 - /tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java

2015-03-31 Thread Konstantin Kolinko
This is a javax.servlet.* class. I wonder whether this changes class signature. Oracle Javadoc lists a constructor, http://docs.oracle.com/javaee/6/api/javax/servlet/jsp/el/ScopedAttributeELResolver.html 2015-03-31 12:08 GMT+03:00 : > Author: markt > Date: Tue Mar 31 09:08:01 2015 > New Revisi

Re: svn commit: r1670300 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2015-03-31 Thread Konstantin Kolinko
2015-03-31 13:34 GMT+03:00 : > Author: markt > Date: Tue Mar 31 10:34:01 2015 > New Revision: 1670300 > > URL: http://svn.apache.org/r1670300 > Log: > Fix typo > > Modified: > tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml > > Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml > URL:

Re: svn commit: r1670437 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2015-03-31 Thread Konstantin Kolinko
2015-03-31 22:15 GMT+03:00 : > Author: markt > Date: Tue Mar 31 19:15:48 2015 > New Revision: 1670437 > > URL: http://svn.apache.org/r1670437 > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57765 > File.lastModified() has a resolution of 1s (1000ms). The last modified time > has to be

Re: svn commit: r1670437 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2015-03-31 Thread Konstantin Kolinko
2015-04-01 0:09 GMT+03:00 Konstantin Kolinko : > 2015-03-31 22:15 GMT+03:00 : >> Author: markt >> Date: Tue Mar 31 19:15:48 2015 >> New Revision: 1670437 >> >> URL: http://svn.apache.org/r1670437 >> Log: >> Fix https://bz.apache.org/bugzilla/show_

Re: svn commit: r1671809 - in /tomcat/tc8.0.x/trunk/java/org/apache: coyote/ajp/ coyote/http11/ tomcat/util/net/

2015-04-07 Thread Konstantin Kolinko
on, (build.properties.default, build.xml) # NPN support npn.version=8.1.2.v20120308 npn.home=${base.path}/npn-${npn.version} npn.jar=${npn.home}/npn-${npn.version}.jar npn.loc=http://repo1.maven.org/maven2/org/eclipse/jetty/npn/npn-api/${npn.version}/npn-api-${npn.version}.jar etc. Bes

Re: svn commit: r1672047 - /tomcat/tc6.0.x/trunk/STATUS.txt

2015-04-08 Thread Konstantin Kolinko
ecycleListener > + svn cp the following o.a.t.jni classes from 7.0.x: > +Buffer > +LibraryNotFoundError > +Thread > + http://people.apache.org/~markt/patches/2015-04-08-jni-align-tc6-v1.patch > + +1: markt > + -1: I see no point in backporting unused Buffer and Thread cla

Re: svn commit: r1672272 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread Konstantin Kolinko
2015-04-09 13:26 GMT+03:00 Rainer Jung : > Am 09.04.2015 um 11:57 schrieb Konstantin Kolinko: >> >> 2015-04-09 12:24 GMT+03:00 : >>> >>> Author: rjung >>> Date: Thu Apr 9 09:24:49 2015 >>> New Revision: 1672272 >>> >>> URL: htt

Re: svn commit: r1672272 - /tomcat/trunk/bin/catalina.sh

2015-04-09 Thread Konstantin Kolinko
; file and try again." > exit 1 >else > echo "Removing/clearing stale PID file." Maybe provide additional information? a) Information on the process? (ps .. ?) b) Path to the PID file. Best regards, Konstantin Kolinko

Re: Getting the context's session-tracking URI parameter name

2015-04-14 Thread Konstantin Kolinko
g/viewvc?view=revision&revision=r944920 https://bz.apache.org/bugzilla/show_bug.cgi?id=49299 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1676381 - in /tomcat/trunk: java/org/apache/el/parser/AstValue.java test/org/apache/el/TestMethodExpressionImpl.java test/org/apache/el/TesterBeanB.java

2015-04-27 Thread Konstantin Kolinko
d), but if it is not a varargs one then allocating the array should not be necessary, I guess. > +} > + > Object[] dest = new Object[paramCount]; > > for (int i = 0; i < paramCount - 1; i++) { > Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1675198 - in /tomcat/trunk: java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/SSLHostConfig.java webapps/docs/config/http.xml

2015-05-05 Thread Konstantin Kolinko
sslcontext.c of Tomcat-Native 1.1.x: The case of 1) uses ctx = SSL_CTX_new(SSLv23_server_method()); The case of 2) uses ctx = SSL_CTX_new(TLSv1_2_server_method()); ctx = SSL_CTX_new(TLSv1_1_server_method()); ctx = SSL_CTX_new(TLSv1_server_method()); etc. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

<    10   11   12   13   14   15   16   17   18   19   >