2015-06-08 20:57 GMT+03:00  <ma...@apache.org>:
> Author: markt
> Date: Mon Jun  8 17:57:05 2015
> New Revision: 1684233
>
> URL: http://svn.apache.org/r1684233
> Log:
> Rename ErrorCode -> Error
>
> Added:
>     tomcat/trunk/java/org/apache/coyote/http2/Error.java
>       - copied, changed from r1683410, 
> tomcat/trunk/java/org/apache/coyote/http2/ErrorCode.java


This name collides with java.lang.Error class.

It is unlikely that you will use both in the same file, and accessing
an enum value is visually different from a java class, but
nevertheless I do not like this naming.

> StreamError.java
> ConnectionError.java

Those are not instances of java.lang.Error, but ones of java.lang.Exception.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to