Re: Mavenization (M10N) of Tomcat Build Process - Should Tomcat Be Migrated to Maven 2?

2007-10-17 Thread Konstantin Kolinko
Hi, Paul! Just a suggestion how to start (seeing all the opinions around): You may start playing in some sandbox, creating a directory structure there, and pulling branches of tomcat code through the use of svn:externals property. It is called creating a view. Having done that, it will be more e

Re: what happened to the old trunk?

2007-12-07 Thread Konstantin Kolinko
That trunk was moved to sandbox/gdev6x/ See http://svn.apache.org/viewvc?view=rev&revision=573772 Sat Sep 8 02:35:33 2007 UTC (2 months, 4 weeks ago) > I see that in http://svn.apache.org/viewvc?view=rev&revision=593649 a > new trunk was created from 6.0.x/trunk but I don't see what happened to >

tomcat.apache.org serves static pages in UTF-8

2011-10-13 Thread Konstantin Kolinko
be observed on other parts of the website as well. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DO NOT REPLY [Bug 46264] Shutting down tomcat with large number of contexts is slow

2011-10-13 Thread Konstantin Kolinko
here. Do you need Runnable in DeployDescriptor, DeployWar, DeployDirectory? That is new code and it is Callable in other places. It is a bikeshed question though. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@to

juli.OneLineFormatter: use US locale

2011-10-13 Thread Konstantin Kolinko
has to be changed there. I think there is no need for it to be configurable the formatter (nor I know how to make it configurable), so I think that the locale in the Cache can be hardcoded as Locale.US. Are there any objections? Best regards, Konstant

Re: svn commit: r1183142 - in /tomcat/trunk/java/org/apache/catalina/startup: Constants.java ContextConfig.java LocalStrings.properties

2011-10-13 Thread Konstantin Kolinko
s not work if defaultWebXml is absolute. The simple jsp below prints C:\workspace\C:\workspace on JDK 6u26 on WinXP: <%= new java.io.File("C:\\workspace", "C:\\workspace") %> So absolute paths for StandardContext defaultWebXml setting are broken as well. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Publishing zips to the maven repo

2011-10-14 Thread Konstantin Kolinko
2011/10/14 David Blevins : > We've been using plain Tomcat zips for creating TomEE in the OpenEJB maven > build for a while now.  So far that has been done by publishing the Tomcat > zips to a maven repo in svn.  Not the best idea to have them in svn, so we're > trying to get them in the actual

Re: Mail address in security-NN.html pages

2011-10-14 Thread Konstantin Kolinko
attention to the site menu on the >>> left side. >> >> Go fix it :D > > +1. > All done. Please enjoy. Should be online in an hour, as usual. Best regards, Konstantin Kolinko - To unsubscribe, e-mai

Re: Embeded Tomcat using a Connector with a random port (port 0)

2011-10-14 Thread Konstantin Kolinko
tial value for Connector#port as well, and that this value can be used to re-implement the check in http://svn.apache.org/viewvc?view=revision&revision=1147949 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Embeded Tomcat using a Connector with a random port (port 0)

2011-10-14 Thread Konstantin Kolinko
or "-1" value for port number, as I mentioned above, but that would be a separate feature. > I have opened https://issues.apache.org/bugzilla/show_bug.cgi?id=52028 > and will try to propose a patch next week. Best regards, Konstantin Kolinko ---

Re: svn commit: r1183340 [1/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-10-14 Thread Konstantin Kolinko
. > [... 2667 lines stripped ...] again... How can this happen? A file with svn:eol-style=native is stored at the server with LF endings. The subversion client should convert it to LF before sending. How the diff happens to cover every line? What were y

Re: svn commit: r1183340 [1/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-10-14 Thread Konstantin Kolinko
2011/10/14 Mark Thomas : > On 14/10/2011 14:10, Konstantin Kolinko wrote: >> 2011/10/14  : >>> Author: markt >>> Date: Fri Oct 14 12:55:55 2011 >>> New Revision: 1183340 >>> >>> URL: http://svn.apache.org/viewvc?rev=1183340&view=rev >&g

Re: svn commit: r1183340 [1/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-10-14 Thread Konstantin Kolinko
2011/10/14 Mark Thomas : > On 14/10/2011 14:51, Konstantin Kolinko wrote: >> 2011/10/14 Mark Thomas : >>> On 14/10/2011 14:10, Konstantin Kolinko wrote: >>>> 2011/10/14  : >>>>> Author: markt >>>>> Date: Fri Oct 14 12:55:55 2011 >&g

Re: Publishing zips to the maven repo

2011-10-14 Thread Konstantin Kolinko
ld, but he disappeared never showing anything working. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Git and tomcat 7.x

2011-10-15 Thread Konstantin Kolinko
ed those files, so I had to Ctrl+F5). But somehow Github display of it is now empty and says "This repository's default branch is empty!" https://github.com/apache/tomcat70 So I cannot yet confirm that Infra ticket is solved https://issues.apache.org/jira/browse/INFRA-4027 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1183340 [1/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-10-15 Thread Konstantin Kolinko
2011/10/14 Mark Thomas : > On 14/10/2011 15:00, Konstantin Kolinko wrote: >> 2011/10/14 Mark Thomas : > >>>> How?  Some git push (or haw it is called there?) that writes directly >>>> to the repository? >>> >>> git svn dcommit >>> &g

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-10-15 Thread Konstantin Kolinko
tp://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: juli.OneLineFormatter: use US locale

2011-10-16 Thread Konstantin Kolinko
2011/10/17 Rainer Jung : > On 13.10.2011 14:16, Konstantin Kolinko wrote: >> Hi! >> >> I would like to change OneLineFormatter to use US locale for its timestamp. >> >> The timestamp format there is "dd-MMM- HH:mm:ss" and in my case >> the

Unit tests for Tomcat 6

2011-10-17 Thread Konstantin Kolinko
r in sandbox and vote&merge from there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1185205 - /tomcat/maven-plugin/trunk/src/site/site.xml

2011-10-17 Thread Konstantin Kolinko
If there are any interesting resources from those Jenkins builds they can be added to the following page: http://tomcat.apache.org/ci.html Best regards, Konstantin Kolinko > 2011/10/17  : >> Author: kkolinko >> Date: Mon Oct 17 14:29:39 2011 >> New Revision: 1185205 >> >

Re: svn commit: r1186485 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2011-10-20 Thread Konstantin Kolinko
oyote.Constants.STAGE_ENDED ... 1) it looks like AbstractAjpProcessor#asyncDispatch(SocketStatus) needs similar patch: it has "return SocketState.OPEN;" If I understand correctly in Ajp that will be recycle(false) 2) In Http11NioProcessor#event() I do not see nextRequest() calls, b

Re: svn commit: r1186898 - /tomcat/tc7.0.x/trunk/

2011-10-20 Thread Konstantin Kolinko
+++ svn:mergeinfo Thu Oct 20 16:32:12 2011 > @@ -1 +1 @@ > -/(...)б1186479-1186480,1186712,1186743,1186750,1186763 > +/(...),1186479-1186480,1186712,1186743,1186750,1186763,1186891 Best regards, Konstantin Kolinko

Re: svn commit: r1187232 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-10-21 Thread Konstantin Kolinko
derEntries = new ArrayList(); > +        Set classLoaderEntries = new HashSet(); > +        //List classLoaderEntries = new ArrayList( ); Maybe java.util.LinkedHashSet like Tomcat does in org.apache.catalina.startup.ClassLoaderFactory ? So that it will preserve order. (Though I do not

Re: svn commit: r1187232 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-10-21 Thread Konstantin Kolinko
wonder that there is no such code there. I think you can file an enhancement request. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1187387 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/loader/WebappClassLoader.java java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml

2011-10-21 Thread Konstantin Kolinko
+1 to backport WebappClassLoader fix. 2. This committed two revisions: Merged /tomcat/trunk:r1187028,1187381 Where r1187028 was Catalina.java "Remove Java 1.2 error handling" I am OK with that, but maybe you want to update the commit

Remove svn keywords (was: svn commit: r1187018 [1/2] - in /tomcat/trunk)

2011-10-21 Thread Konstantin Kolinko
gt; -   connector.stop(). > \ No newline at end of file > +   connector.stop(). > + > +9. Remove all the static info attributes and associated getters. > + > +10. Remove the svn keywords from all the files. OK for *.java, but let's keep them in *.txt Or

Removing getInfo() methods - JMX needs update as well

2011-10-22 Thread Konstantin Kolinko
(2 matches) mbeans-descriptors.xml - tomcat-8.0.x/java/org/apache/catalina/tribes/membership mbeans-descriptors.xml - tomcat-8.0.x/java/org/apache/catalina/valves (8 matches) That is the only user-visible usage of those getInfo() methods that I know about. Best regards, Konstant

Removing whitespace from *.xsd and *.dtd files

2011-10-22 Thread Konstantin Kolinko
r1187816. More is likely to follow. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Removing whitespace from *.xsd and *.dtd files

2011-10-22 Thread Konstantin Kolinko
2011/10/23 Mark Thomas : > On 22/10/2011 22:54, Konstantin Kolinko wrote: >> Hi! >> >> http://svn.apache.org/viewvc?rev=1187778&view=rev >> affected a number of *.xsd and *.dtd files. >> >> I think we should not touch those without a good reason. &

Re: Removing whitespace from *.xsd and *.dtd files

2011-10-23 Thread Konstantin Kolinko
2011/10/23 Mark Thomas : > On 22/10/2011 23:33, Konstantin Kolinko wrote: >> 2011/10/23 Mark Thomas : >>> On 22/10/2011 22:54, Konstantin Kolinko wrote: >>>> Hi! >>>> >>>> http://svn.apache.org/viewvc?rev=1187778&view=rev >>>> a

Re: Removing whitespace from *.xsd and *.dtd files

2011-10-23 Thread Konstantin Kolinko
2011/10/24 Mark Thomas : > On 23/10/2011 10:39, Konstantin Kolinko wrote: > >> I am -1 on applying trailing whitespaces check on *.java files. >> >> It has no practical value. It does not improve readability. I do not >> see what it can be useful for. It is just usele

Re: svn commit: r1187916 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2011-10-24 Thread Konstantin Kolinko
Old code used stristr. New code uses strncmp. If I understand correctly, the old one is case-insensitive, while the new one is case-sensitive. Best regards, Konstantin Kolinko 2011/10/23 : > Author: rjung > Date: Sun Oct 23 16:19:59 2011 > New Revision: 1187916 > > URL: http:/

Re: svn commit: r1188313 [1/5] - in /tomcat/trunk/java: javax/el/ org/apache/catalina/authenticator/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/catalina/deploy/ org/apache/cat

2011-10-25 Thread Konstantin Kolinko
to find properties that are not mentioned in *.properties files? Best regards, Konstantin Kolinko 2011/10/24 : > Author: markt > Date: Mon Oct 24 19:18:39 2011 > New Revision: 1188313 > > URL: http://svn.apache.org/viewvc?rev=1188313&view=rev > Log: > Remove unused properties

Re: svn commit: r1187916 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2011-10-25 Thread Konstantin Kolinko
compare: will this ever match if >> you use "web-inf" (as below)? > > Duh just saw Konstantin's response. Apologies for the noise. > > I still think the // might be a problem, though. > +while (uri = strchr(uri, '/')) { If uri starts with '/&#x

Re: svn commit: r1188930 - /tomcat/trunk/test/webapp-3.0/welcome-files/sub/.gitignore

2011-10-25 Thread Konstantin Kolinko
Can you add descriptive comment in the file itself and ASL license? 2011/10/26 : > Author: markt > Date: Tue Oct 25 21:34:21 2011 > New Revision: 1188930 > > URL: http://svn.apache.org/viewvc?rev=1188930&view=rev > Log: > Git ignores empty directories and the unit tests require this directory to

Re: svn commit: r1183340 [1/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-10-26 Thread Konstantin Kolinko
2011/10/15 Mark Thomas : > On 15/10/2011 11:02, Konstantin Kolinko wrote: >> How do you run git? Do you use Cygwin, or maybe TortoiseGit? > > http://code.google.com/p/msysgit/downloads/list > >> I think http://wiki.apache.org/general/GitAtApache might need to be updated

Re: svn commit: r1188930 - /tomcat/trunk/test/webapp-3.0/welcome-files/sub/.gitignore

2011-10-26 Thread Konstantin Kolinko
Done in trunk and merged into 7.0. Best regards, Konstantin Kolinko 2011/10/26 Konstantin Kolinko : > Can you add descriptive comment in the file itself and ASL license? > > 2011/10/26  : >> Author: markt >> Date: Tue Oct 25 21:34:21 2011 >> New Revision: 1188930 >&

Re: svn commit: r1187826 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/naming/ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test

2011-10-26 Thread Konstantin Kolinko
    ka = null; The "socket" here is not a local variable, but a field. Is it true that the null check can be removed here? I think it would be safer with null checks. The "synchronized (socket)" that wraps it all is a bit odd with socket=null assignments inside of it, but IIR

Re: svn commit: r1183340 [1/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2011-10-26 Thread Konstantin Kolinko
2011/10/26 Mark Thomas : > On 26/10/2011 11:51, Konstantin Kolinko wrote: >> 2011/10/15 Mark Thomas : >>> On 15/10/2011 11:02, Konstantin Kolinko wrote: >>>> How do you run git? Do you use Cygwin, or maybe TortoiseGit? >>> >>> http://code.google.co

Re: svn commit: r1189436 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-10-26 Thread Konstantin Kolinko
at 7+ you do not need to implement a Lifecycle explicily, but can just overwrite initInternal(). The revisions covered by the patch are: http://svn.apache.org/viewvc?rev=1187027&view=rev http://svn.apache.org/viewvc?rev=1189256&view=rev Huh - I missed a part of r1187027. I'll update

Patching RequestFilterValve

2011-10-26 Thread Konstantin Kolinko
repeating deployment attempt every 10s and printing the error in the logs. Tomcat 6.0 does not attempt redeployment. Nothing seriously wrong with it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: Patching RequestFilterValve

2011-10-27 Thread Konstantin Kolinko
2011/10/27 Rainer Jung : > On 27.10.2011 01:36, Konstantin Kolinko wrote: >> If the valve is added only to conf/*, the XML file deployment fails, >> but Tomcat will later try to deploy the application again from webapps >> folder and this deployment may be successful. >&g

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-10-28 Thread Konstantin Kolinko
alina.util.LifecycleBase.destroy(LifecycleBase.java:292) [junit] ... 30 more (...) [junit] Test org.apache.catalina.comet.TestCometProcessor FAILED ]]] ... [junit] Test org.apache.catalina.filters.TestCsrfPreventionFilter FAILED [junit] Test org.apache.catalina.filters.TestExpi

Re: svn commit: r1189899 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat/util/http/ webapps/docs/ webapps/docs/config/

2011-10-28 Thread Konstantin Kolinko
r.getCharset("ISO-8859-1"); } catch (UnsupportedEncodingException e) { // Should never happen since all JVMs must support ISO-8859-1 } DEFAULT_CHARSET = defaultCharset; } 2) In TestParameters.java in http://svn.apache.org/vi

Re: IDEA settings for Tomcat development?

2011-10-28 Thread Konstantin Kolinko
ubmit a new patch, this "basic" stuff do not raise any > concerns? Take a look at http://tomcat.apache.org/getinvolved.html#Coding_Conventions Most of us use Eclipse IDE. I use "Java conventions" but changed to use spaces instead of tabs. I think there would be something like t

Re: IDEA settings for Tomcat development?

2011-10-28 Thread Konstantin Kolinko
2011/10/28 Francis Galiegue : > On Fri, Oct 28, 2011 at 19:25, Konstantin Kolinko > wrote: >> 2011/10/28 Francis Galiegue : >>> Hello list, >>> >>> I understand some of you use IDEA for developing Tomcat. So do I. Can >>> you share your pro

Re: Improving problem reporting

2011-10-28 Thread Konstantin Kolinko
ccessorImpl.java:57) >    at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >    at java.lang.reflect.Method.invoke(Method.java:616) >    at org.apache.catalina.startup.Bootstrap.start(Bootstrap.jav

Re: svn commit: r1190720 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-10-29 Thread Konstantin Kolinko
ey) if a) returned true It can be replaced by calling b) once and testing whether its result is null. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-10-31 Thread Konstantin Kolinko
t] Tests run: 3, Failures: 1, Errors: 0, Time elapsed: 4.682 sec [junit] Test org.apache.tomcat.util.http.mapper.TestMapper FAILED There are no details wrt what test in TestMapper failed and why. Best regards, Konstantin Kolinko -

Re: svn commit: r1195434 - in /tomcat/jk/trunk/native/common: jk_pool.c jk_pool.h

2011-10-31 Thread Konstantin Kolinko
char *s, const char *a); There is a typo in *.h above: s/strdcat/strcat/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-10-31 Thread Konstantin Kolinko
2011/10/31 Konstantin Kolinko : > 2011/10/31  : >> The Buildbot has detected a new failure on builder tomcat-trunk while >> building ASF Buildbot. >> Full details are available at: >>  http://ci.apache.org/builders/tomcat-trunk/builds/244

Re: svn commit: r1190720 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-10-31 Thread Konstantin Kolinko
r. Replaced with HashMap in trunk in r1195531, will apply to TC7 as well. With performance tests the HashMap works faster for me. The difference is from 2% in short test up to 6% with maximum test size. Best regards, Konstantin Kolinko

Re: svn commit: r1195531 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java

2011-10-31 Thread Konstantin Kolinko
tomcat package may not depend on > o.a.catalina. You should have seen a checkstyle warning for that when > you tried to build it. > Maybe move that Enumerator class into org.apache.tomcat.util.collections ? (Resurrecti

Re: svn commit: r1195531 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java

2011-10-31 Thread Konstantin Kolinko
> There are two copies of Enumerator class now: one in catalina and one in >> jasper. > Jasper will need to keep its own copy as it can't have any external > dependencies. Isn't tomcat-util.jar the place for classes that both Catalina and Jasper depend on?

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
c?view=revision&revision=1195965 Applies to AJP as well. Is it possible to throw a runtime exception from parseParameters() when the limit is reached instead of dropping the parameters, or you think the API does not allow it? 2) http://markmail.org/message/5k4urwimvvmeqees Best regards,

Re: svn commit: r1196077 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2011-11-01 Thread Konstantin Kolinko
sing notification event %s (0x%08x)", 2670(iis_info.filter_notify_event == SF_NOTIFY_AUTH_COMPLETE) ? 2671"SF_NOTIFY_AUTH_COMPLETE" : 2672((iis_info.filter_notify_event == SF_NOTIFY_PREPROC_HEADERS) ? 2673"SF_NOTIFY_PREPROC_HEADERS" : "UNKNOWN"),

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/1 Mark Thomas : > On 01/11/2011 14:16, Konstantin Kolinko wrote: >> >> 1) Re: http://svn.apache.org/viewvc?view=revision&revision=1195965 > >> Is it possible to throw a runtime exception from parseParameters() >> when the limit is reached instead of droppi

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/2 Konstantin Kolinko : > 2011/11/1 Mark Thomas : >> On 01/11/2011 14:16, Konstantin Kolinko wrote: >>> >>> 1) Re: http://svn.apache.org/viewvc?view=revision&revision=1195965 >> >>> Is it possible to throw a runtime exception from parseParamet

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
2011/11/2 Mark Thomas : > On 01/11/2011 22:01, Konstantin Kolinko wrote: >> 2011/11/2 Konstantin Kolinko : >>> 2011/11/1 Mark Thomas : >>>> My current thinking is to add redeployResoucre and reloadResource to >>>> Context and deprecate watchedResource, m

Re: Tagging 7.0.23

2011-11-01 Thread Konstantin Kolinko
ld\webapps\ROOT 27.10.2011 16:29:07 org.apache.coyote.AbstractProtocol start INFO: Starting ProtocolHandler ["http-bio-8080"] 27.10.2011 16:29:07 org.apache.coyote.AbstractProtocol start INFO: Starting ProtocolHandler ["ajp-bio-8009&q

Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-02 Thread Konstantin Kolinko
2011/11/2 : > Konstantin Kolinko wrote: > >>2011/11/2 Mark Thomas : >>> On 01/11/2011 22:39, Mark Thomas wrote: > >>> My first stab at a patch for this is at [1]. Comments welcome. > >>>http://people.apache.org/~markt/patches/2011-11-01-redeploy-trun

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-11-02 Thread Konstantin Kolinko
meouts. The second run (nio) was successful and several times faster: Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 8.673 sec All other tests did run OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail:

[patch] Speed up Tomcat shutdown during test runs

2011-11-02 Thread Konstantin Kolinko
about 11,5 minutes for me with this patch. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [patch] Speed up Tomcat shutdown during test runs

2011-11-03 Thread Konstantin Kolinko
2011/11/3 Konstantin Kolinko : > Hi! > > The patch: > http://people.apache.org/~kkolinko/patches/2011-11-03_tc8_fastShutdown.patch > > It saves 1 second for each Tomcat shutdown during tests, > by skipping a sleep in AbstractEndpoint.pause(). > > I think it is worth

Re: svn commit: r1197310 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/RequestFilterValve.java

2011-11-03 Thread Konstantin Kolinko
t;      * against the specified request property. Good. The 5.5 and 6.0 patches should have this feature already, because they do not have separate init method and do it in start() instead. The only difference is that you assign the string values before calling Pattern.compile(), while in 5.5/6.0 I do assignment only if compilation is successful. I think that this your assignment behaviour is better and I could update the 5.5/6.0 patches to align with it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-05 Thread Konstantin Kolinko
public synchronized void addValve(Valve valve) 3) deployer-howto.xml still mentions "RedeployResource". I'd see where it goes and fix later. PS: I had troubles applying your patch with svn and started a thread on users@subversion referring to it as an example. It does not handl

Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-05 Thread Konstantin Kolinko
ore): I thought that there could be a public method callable through JMX to check whether allowed address is allowed or denied. Something like "test(String)" or "isAllowed(String)". Best regards, Konstantin Kolinko

Re: svn commit: r1198376 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2011-11-06 Thread Konstantin Kolinko
@ -28,6 +28,7 @@ import org.codehaus.plexus.archiver.Arch >  import org.codehaus.plexus.archiver.UnArchiver; >  import org.codehaus.plexus.archiver.manager.ArchiverManager; >  import org.codehaus.plexus.archiver.manager.NoSuchArchiverException; > +import org.codehaus.plexus.archiver.zip.ZipUnArch

Re: svn commit: r1198640 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java

2011-11-07 Thread Konstantin Kolinko
Access to the current name/values, no side effect ( processing ). // You must explicitly call handleQueryParameters and the post methods. Whatever needs handleQueryParameters() call there is not covered by our testsuite. I've already ported this commit to 7.0 - r1198641. Best regards, Konst

Re: Unsubscribe From Mailing List

2011-11-07 Thread Konstantin Kolinko
o confirm unsubscription. If nothing helps, send mail to "list owner" address so that he would unsubscribe you manually. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For add

FailedRequestFilter

2011-11-07 Thread Konstantin Kolinko
trunk implementing this feature: http://svn.apache.org/viewvc?rev=1198696&view=rev http://svn.apache.org/viewvc?rev=1198707&view=rev Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache

Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-07 Thread Konstantin Kolinko
2011/11/6 Konstantin Kolinko : > 2011/11/6 Mark Thomas : >> >> I'm in two minds whether to apply this patch before or after the 7.0.23 >> tag. There are clearly issues here that need fixing but the patch is >> quite invasive. I'm leaning towards tagging af

Re: FailedRequestFilter

2011-11-07 Thread Konstantin Kolinko
2011/11/7 Konstantin Kolinko : > Hi! > > In trunk I committed a new feature: request attribute that is set if > there were problems during parameter parsing and FailedRequestFilter - > filter that rejects requests if that request attribute is set. > > I would like this to

Problem deploying WAR with manager app in trunk

2011-11-07 Thread Konstantin Kolinko
nd call will be ignored. ]]] - In manager webapp the "examples3" webapp is still present! It is not running and cannot be undeployed. I have not tested how TC7 behaves yet. Best regards, Konstantin Kolinko - To unsubscribe, e-m

Re: svn commit: r1198696 - in /tomcat/trunk/java/org/apache: catalina/Globals.java catalina/connector/Request.java catalina/filters/FailedRequestFilter.java tomcat/util/http/Parameters.java

2011-11-07 Thread Konstantin Kolinko
ate the decision what to do to Valves/Filters/Servlets that check the attribute. I do not see anything that can happen at the "native layer". Instead of Request#checkParameterParseFailed() there could be alternative implementation as a new "if(name.equals(...))" branch in Request

Re: svn commit: r1199980 - in /tomcat/trunk/java/org/apache: catalina/core/AprLifecycleListener.java catalina/core/LocalStrings.properties tomcat/jni/SSL.java

2011-11-09 Thread Konstantin Kolinko
tartup sequence continues. I guess that from FIPS PoV the failure to initialize FIPS mode should be more fatal, regardless of its cause. Be it because of native lib returning error code or this tc-native version mismatch. Maybe even throw an error i

Re: svn commit: r1199980 - in /tomcat/trunk/java/org/apache: catalina/core/AprLifecycleListener.java catalina/core/LocalStrings.properties tomcat/jni/SSL.java

2011-11-09 Thread Konstantin Kolinko
; Maybe add explicit FIPS mode status check below the above error handling? Something like: if ("on".equalsIgnoreCase(FIPSMode) && !fipsModeActive) { fail fatally; } Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-11-10 Thread Konstantin Kolinko
00555. > Yes, it is sporadic. Failed 3 or 4 times during the last week. Note, that in the same buildbot run the test occurs twice (bio+nio), but only one fails. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1200582 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-11-10 Thread Konstantin Kolinko
anyway if it is never called it is called again at the top of ManagerBase.getRandomBytes(). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1200582 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-11-10 Thread Konstantin Kolinko
2011/11/11 Rainer Jung : > On 10.11.2011 15:08, Konstantin Kolinko wrote: >> >> 2011/11/11: >>> >>> Author: rjung >>> Date: Thu Nov 10 21:46:32 2011 >>> New Revision: 1200582 >>> >>> URL: http://svn.apache.org/viewvc?rev=120058

Re: TCnative crashes in test suite for trunk and TC 7

2011-11-11 Thread Konstantin Kolinko
1.3.12 OpenSSL 0.9.8r Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Redeploy on context.xml changes (Was: Tagging 7.0.23)

2011-11-13 Thread Konstantin Kolinko
ntextConfig#configureStart() it does: if (ok) { context.setConfigured(true); } else { log.error(sm.getString("contextConfig.unavailable")); context.setConfigured(false); } I mean: - FailedContext class solves a very limi

Re: svn commit: r1202058 - in /tomcat/trunk/bin: catalina.bat catalina.sh configtest.sh digest.sh setclasspath.bat setclasspath.sh shutdown.sh startup.sh version.sh

2011-11-15 Thread Konstantin Kolinko
? >> > > Yes if you use cygwin. > It does some weird ACL settings depending if 775 is set or not > when using cygwin's unzip. > It is useless to set executable bit on the files in source tree. They should not be run from there, but from build/bin. Does Ant preserve executable

Re: svn commit: r1201606 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_pool.c jk_shm.c

2011-11-15 Thread Konstantin Kolinko
1 : 0); > +    fprintf(f, "dyn_size         [%d]\n", (unsigned int)p->dyn_size); > +    fprintf(f, "dyn_pos          [%d]\n", (unsigned int)p->dyn_pos); I think it would be s/%d/%u/ in the previous two lines, like already done above them. It should

Re: svn commit: r1202556 - in /tomcat/jk/trunk/native: README.txt TODO.txt apache-2.0/bldjk.qclsrc apache-2.0/bldjk54.qclsrc build.xml netscape/Makefile.linux

2011-11-16 Thread Konstantin Kolinko
$(PLUGIN_OBJ) 49 $(LD_SHAREDCMD) $(JK_OBJS) $(PLUGIN_OBJ) -o nsapi_redirector.so $(EXTRA_LDDEFINES) I do not 100% understand this file, but it looks like it can be replaced it with JK_OBJECTS. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release build 6.0.34

2011-11-16 Thread Konstantin Kolinko
here is '%' in the value. E.g. "?firstname=hello+world%25" is decoded correctly. It is my fault as well that I missed this. Sorry for inconvenience. Best regards, Konstantin Kolinko - To unsubscribe, e-

Re: svn commit: r1198553 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml webapps/do

2011-11-16 Thread Konstantin Kolinko
periodic JVM crash (access violation) on buffer flush" > I'm not too bothered right now since this won't affect production > systems but I'd like to get to the bottom of it. > > Any thoughts welcome. > Best regards, Konstantin Kolinko --

Re: svn commit: r1198553 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AbstractEndpoint.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml webapps/do

2011-11-17 Thread Konstantin Kolinko
implementation of a specific endpoint. It should be possible to update TomcatBaseTest class to turn off this feature for some tests, or for Apr connector as a whole. That is just regarding this feature. There might be other questions like whether Apr shutdown can be made more r

Re: Change in behavior for Connector maxKeepAliveRequests in 7.0.21+

2011-11-17 Thread Konstantin Kolinko
ectors. It might be that some of them (Bio vs Nio vs Apr) treated "0" differently. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Maintenance Release of Servlet 3.0 (3.0 Rev a)

2011-11-17 Thread Konstantin Kolinko
ight be that some of changes/clarifications listed in [2] need to be implemented. [1] https://wiki.apache.org/tomcat/Specifications [2] http://jcp.org/aboutJava/communityprocess/maintenance/jsr315/servlet3-mr-reva.html Best regards

Re: svn commit: r1203253 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ test/org/apache/catalina/startup/ webapps/docs/config/

2011-11-17 Thread Konstantin Kolinko
in speedup in run 2533 rather than it being random or good time of day. r1203346 removed of unused code in XMLEncodingDetector, but it should not change that much. We will see whether it stays with next runs. Anyway the numbers are good. Best regards, Konstantin Kolinko -

Re: [GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-11-17 Thread Konstantin Kolinko
LED Comet END event not received junit.framework.AssertionFailedError: Comet END event not received at org.apache.catalina.comet.TestCometProcessor.testCometConnectorStop(TestCometProcessor.java:293) ]]] I rerun the test with trunk locally with Nio and Apr and it completed successfully.

Re: [VOTE] Release Apache Tomcat 7.0.23

2011-11-18 Thread Konstantin Kolinko
ot 100% successful. I noted NullPointerException in one of tribes tests. The test itself did not fail. It likely happened during teardown. Filed: https://issues.apache.org/bugzilla/show_bug.cgi?id=52208 Best regards, Konstantin Kolinko -

Re: [VOTE] Release Apache Tomcat 7.0.23 - Take 2

2011-11-20 Thread Konstantin Kolinko
x] Stable - go ahead and release as 7.0.23 Stable Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: How to get the tomcat internal log out?

2011-11-20 Thread Konstantin Kolinko
2011/11/21 Kurt : > Hello all: > >    I compile tomcat 5.5.30 and import it to eclipse as a project, to > research how the tomcat load class , I need to view the running log ,after > reading through this > post(http://tomcat.apache.org/tomcat-5.5-doc/logging.html) and adding below > log.properties

Re: How to get the tomcat internal log out?

2011-11-21 Thread Konstantin Kolinko
t. You are asking some question on how to use it. Thus it belongs to uses@ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Multiple Aliases Problem

2011-11-21 Thread Konstantin Kolinko
engine.addChild()" method is called on the closing "" tag. Best regards, Konstantin Kolinko 2011/11/22 Chatree Srichart : > Any comment? > > On Mon, Nov 21, 2011 at 1:52 PM, Chatree Srichart < > chatree.srich...@gmail.com> wrote: > >> Hi community. >>

Re: tagging 6.0.34 tomorrow?

2011-11-22 Thread Konstantin Kolinko
2011/11/22 Forrest Xia : > Any update on 6.0.34 vote? Geronimo would like to have it in the coming > 2.1.8 release. 6.0.34 is broken. Timing for 6.0.35 is yet to be decided. There is 7.0.23 vote right now. Best regards, Konstantin K

Re: Random Comet unit test failures

2011-11-22 Thread Konstantin Kolinko
readPoolExecutor.java:1110) [junit] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [junit] at java.lang.Thread.run(Thread.java:636) ]]] The above one is from http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0

Re: can only see ROOT webapp

2011-11-23 Thread Konstantin Kolinko
2011/11/23 shadowdancer351 : > > I am using Tomcat 4 on Linux. > 1. Your question is offtopic on dev@ mailing list. 2. There should not be any reason to still use Tomcat 4. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.

  1   2   3   4   5   6   7   8   9   10   >