2011/10/29 Mark Thomas <ma...@apache.org>: >> + - Maybe "if (paramHashValues.containsKey(key))" can be replaced >> + with testing whether result of (paramHashValues.containsKey(key)) >> is null. > Hashtable does not permit null keys or values.
>> + - Maybe "if (paramHashValues.containsKey(key))" can be replaced >> + with testing whether result of (paramHashValues.containsKey(key)) >> is null. >See previous comment re Hashtable. I mean that there are two hashtable lookup operations in a row: a) containsKey(key) b) get(key) if a) returned true It can be replaced by calling b) once and testing whether its result is null. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org