2011/11/16  <mt...@apache.org>:
> Author: mturk
> Date: Wed Nov 16 07:07:10 2011
> New Revision: 1202556
>
> URL: http://svn.apache.org/viewvc?rev=1202556&view=rev
> Log:
> Axe deprecated JNI references from more places
>
> Modified:
>    tomcat/jk/trunk/native/README.txt
>    tomcat/jk/trunk/native/TODO.txt
>    tomcat/jk/trunk/native/apache-2.0/bldjk.qclsrc
>    tomcat/jk/trunk/native/apache-2.0/bldjk54.qclsrc
>    tomcat/jk/trunk/native/build.xml
>    tomcat/jk/trunk/native/netscape/Makefile.linux

Noticed one glitch in this, in Makefile.linux:

> Modified: tomcat/jk/trunk/native/netscape/Makefile.linux
> URL: 
> http://svn.apache.org/viewvc/tomcat/jk/trunk/native/netscape/Makefile.linux?rev=1202556&r1=1202555&r2=1202556&view=diff
> ==============================================================================
> --- tomcat/jk/trunk/native/netscape/Makefile.linux (original)
> +++ tomcat/jk/trunk/native/netscape/Makefile.linux Wed Nov 16 07:07:10 2011
> @@ -37,8 +37,6 @@ VPATH=.:$(JK_DIR)
>
>  JK_SRCS = $(shell \ls $(JK_DIR)/*.c)
>  JK_OBJECTS = $(patsubst $(JK_DIR)/%.c,%.o,$(JK_SRCS))
> -JK_OBJS = $(filter-out $(JK_JNI_OBJECTS),$(JK_OBJECTS))
> -
>  PLUGIN_OBJ = jk_nsapi_plugin.o
>
>  INCLUDE_FLAGS= -I$(JK_DIR) -I$(INCLUDEDIR) -I$(INCLUDEDIR)/base \
>

You axed the whole "JK_OBJS" above,  but it is used below in the file:

48      nsapi_redirector.so: $(JK_OBJS) $(PLUGIN_OBJ)
49      $(LD_SHAREDCMD) $(JK_OBJS) $(PLUGIN_OBJ) -o nsapi_redirector.so
$(EXTRA_LDDEFINES)

I do not 100% understand this file, but it looks like it can be
replaced it with JK_OBJECTS.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to