Re: svn commit: r464632 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ webapps/docs/ webapps/docs/config/

2006-10-16 Thread Filip Hanik - Dev Lists
good idea, Filip Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: fhanik Date: Mon Oct 16 12:23:34 2006 New Revision: 464632 URL: http://svn.apache.org/viewvc?view=rev&rev=464632 Log: Fixed manager registration and how manager names are handled. Make sure the manager has a reference to

Re: svn commit: r464632 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ webapps/docs/ webapps/docs/config/

2006-10-16 Thread Filip Hanik - Dev Lists
overall, could we get rid of the documentation clutter in server.xml, make it readable on one page, with small comments here and there. thoughts? Filip Filip Hanik - Dev Lists wrote: good idea, Filip Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: fhanik Date: Mon Oct 16 12:23:34

SSL Connectors - config proposal

2006-10-17 Thread Filip Hanik - Dev Lists
gents and ladies, currently we are doing SSL a little bit differently between APR and the Java connectors. The APR connector requires an attribute sslEngine="On" to kick in. I believe this attribute to be useful for two reasons: 1. Config should be as consistent as possible. 2. If I use a SS

Re: svn commit: r464958 - /tomcat/tc6.0.x/trunk/conf/server.xml

2006-10-17 Thread Filip Hanik - Dev Lists
knock yourself out :) Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: fhanik Date: Tue Oct 17 09:49:59 2006 New Revision: 464958 URL: http://svn.apache.org/viewvc?view=rev&rev=464958 Log: Cleaned up server.xml, added in documentation references so that a user can navigate from an eleme

Re: SSL Connectors - config proposal

2006-10-17 Thread Filip Hanik - Dev Lists
Jean-frederic Clere wrote: Filip Hanik - Dev Lists wrote: gents and ladies, currently we are doing SSL a little bit differently between APR and the Java connectors. The APR connector requires an attribute sslEngine="On" to kick in. I believe this attribute to be useful for two r

Re: SSL Connectors - config proposal

2006-10-17 Thread Filip Hanik - Dev Lists
Jean-frederic Clere wrote: Filip Hanik - Dev Lists wrote: Jean-frederic Clere wrote: Filip Hanik - Dev Lists wrote: gents and ladies, currently we are doing SSL a little bit differently between APR and the Java connectors. The APR connector requires an attribute sslEngine="On&quo

Re: [VOTE] Tomcat 6 release plan

2006-10-17 Thread Filip Hanik - Dev Lists
[X] +1 [ ] +0 [ ] -1 Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: [EMAIL PROTECTED] wrote: -ssl = endpoint.getSecure(); +ssl = "on".equalsIgnoreCase(endpoint.getSSLEngine()); Like Remy said, anything except "Off" is acceptable. It can be either "On" or "EngineName" (eg, SSLEngine="nuron") that's for APR, because of

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Mladen Turk wrote: [EMAIL PROTECTED] wrote: -ssl = endpoint.getSecure(); +ssl = "on".equalsIgnoreCase(endpoint.getSSLEngine()); Like Remy said, anything except "Off" is acceptable. It can be either "On" or &quo

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Filip Hanik - Dev Lists wrote: Mladen Turk wrote: [EMAIL PROTECTED] wrote: -ssl = endpoint.getSecure(); +ssl = "on".equalsIgnoreCase(endpoint.getSSLEngine()); Like Remy said, anything except "Off" is acceptable. It c

TC 6.0 TCK

2006-10-18 Thread Filip Hanik - Dev Lists
does anyone have these, I assume I wouldn't have to sign another agreement to upgrade TCK, as I already signed the agreement to use TCK with tomcat 5.5 Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: Filip Hanik - Dev Lists wrote: to eager to press send, that way the connector would have only on/off values, while the actual SSLEngine value neuron would be in the APRLifeCycleListener, much cleaner, and all our connectors become consistent on that value Look, no

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: I have two suggestions 1. The SSLEngine attribute should be in the APR lifecycle listener, and not in the connector, since its static, I can't have more than one, so why do I have to define it more than once. This would require doubling directives for enabling SSL, once in

Re: svn commit: r465303 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-18 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Mladen Turk wrote: Filip Hanik - Dev Lists wrote: to eager to press send, that way the connector would have only on/off values, while the actual SSLEngine value neuron would be in the APRLifeCycleListener, much cleaner, and all our

Re: svn commit: r465293 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/tcp/ webapps/docs/

2006-10-18 Thread Filip Hanik - Dev Lists
Hi Peter, with this fix, if I read it correctly, and a node crashes while sending data, the sending thread will be stuck sleeping for 25 seconds (recoverTimeout*recoverCounter)? if that is the case, I suggest that we use recoverCounter=0 as the default value. did I miss something? Filip [E

Re: svn commit: r465418 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

2006-10-18 Thread Filip Hanik - Dev Lists
is this existent in 6.0 as well? [EMAIL PROTECTED] wrote: Author: markt Date: Wed Oct 18 16:32:37 2006 New Revision: 465418 URL: http://svn.apache.org/viewvc?view=rev&rev=465418 Log: Fix bug 38048. memory leak with EL in JSPs. Patch provided by Taras Tielkes. Modified: tomcat/container/t

Re: TC 6.0 TCK

2006-10-18 Thread Filip Hanik - Dev Lists
much thanks! Yoav Shapira wrote: I don't have them. You don't need to sign antoher agreement I think. You do simply need to ask Geir ([EMAIL PROTECTED], our JCP liaison) for a copy, assuming these TCKs already exist, and he will get it for you. Yoav On 10/18/06, Filip Hanik -

Re: svn commit: r465675 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/core/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: [EMAIL PROTECTED] wrote: SSLEngine is an attribute of the APR lifecycle listener to initialize the native SSL layer once per VM. I don't get it, really. :) Did you read my reply about: 1. scheme="https" secure="true" 2. scheme="https" secure="false" 3. scheme="http" secu

Re: svn commit: r465675 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/core/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: Filip Hanik - Dev Lists wrote: The scenario we are trying to achieve is this: How will in that case behave: Let me see if I can explain a) The socket is doing HTTP over TCP, no SSL b) request.getScheme returns https, so if the webapplication uses this to create URLs

Re: svn commit: r465675 - in /tomcat/tc6.0.x/trunk: conf/ java/org/apache/catalina/core/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2006-10-19 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: Remy Maucherat wrote: It is also a good thing to cleanup the SSLEngine initialization, which should indeed be a one per VM call. SSL.initialize is reference counted, so any consecutive call simply returns OK. that wasn't the entire problem though, it wasn't clear to the us

Re: [VOTE] Tomcat 6 release plan

2006-10-19 Thread Filip Hanik - Dev Lists
works for me, Filip Remy Maucherat wrote: Remy Maucherat wrote: Hi, The release plan is located here: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/RELEASE-PLAN-6.0.txt [ ] +1 [ ] +0 [ ] -1 This calls for a first build to be released by friday, and it will use the same release p

Re: svn commit: r465417 - in /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11: Http11NioProcessor.java InternalNioInputBuffer.java

2006-10-19 Thread Filip Hanik - Dev Lists
gentlemen, not sure if you had a chance to look this over, but it is pretty interesting, after some very basic tests, I get the NIO connector to perform better than the blocking io connector the peak data throughput are NIO - 36,000KB/s JIO - 35,000KB/s APR - 24,000KB/s basic connector config,

Re: svn commit: r465417 - in /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11: Http11NioProcessor.java InternalNioInputBuffer.java

2006-10-20 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: gentlemen, not sure if you had a chance to look this over, but it is pretty interesting, after some very basic tests, I get the NIO connector to perform better than the blocking io connector the peak data throughput are NIO - 36,000KB/s JIO

Re: Change in behavior for Connector maxKeepAliveRequests in 7.0.21+

2011-11-17 Thread Filip Hanik - Dev Lists
On 11/17/2011 2:00 AM, Konstantin Kolinko wrote: 2011/11/17 Ryan Morgan: Hey everyone, As part of the HTTP connector refactoring that occurred in 7.0.21 (see http://svn.apache.org/viewvc?diff_format=h&view=revision&revision=1158367) the Connector behavior has changed when maxKeepAliveRequests

Re: svn commit: r1207852 - in /tomcat/trunk/modules/jdbc-pool: ./ doc/changelog.xml

2011-11-29 Thread Filip Hanik Mailing Lists
I can't for the life of me seem to get this right, do you have the right command? Filip - Original Message - From: fha...@apache.org To: dev@tomcat.apache.org Sent: Tuesday, November 29, 2011 5:56:03 AM Subject: svn commit: r1207852 - in /tomcat/trunk/modules/jdbc-pool: ./ doc/changelog

Re: svn commit: r1207856 - /tomcat/tc7.0.x/trunk/modules/

2011-11-29 Thread Filip Hanik Mailing Lists
svn propset svn:externals '^/tomcat/trunk/modules/jdbc-pool@1207712 jdbc-pool' modules does that seem right? - Original Message - From: fha...@apache.org To: dev@tomcat.apache.org Sent: Tuesday, November 29, 2011 6:00:19 AM Subject: svn commit: r1207856 - /tomcat/tc7.0.x/trunk/modules/

Re: [VOTE] Release build 6.0.35

2011-11-29 Thread Filip Hanik Mailing Lists
[X] Stable Filip - Original Message - From: "jean-frederic clere" To: dev@tomcat.apache.org Sent: Monday, November 28, 2011 4:30:37 AM Subject: [VOTE] Release build 6.0.35 The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.35/ According to the r

Re: Proposal: use tomcat-version-number in server.xml element?

2011-12-02 Thread Filip Hanik - Dev Lists
On 12/2/2011 10:11 AM, Konstantin Kolinko wrote: 2011/12/2 Christopher Schultz: All, This may be a waste of time, but it's worth suggesting IMO. We have lots of users who try to upgrade between major versions of Tomcat by simply installing the new Tomcat somewhere, copying their configuration

Re: svn commit: r1080719 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-01-13 Thread Filip Hanik - Dev Lists
I'm looking for a better reason for this change. What was the reasoning behind this limitation, as it breaks years of compatibility. Workaround is to point docBase to a directory. best Filip On 3/11/2011 11:40 AM, ma...@apache.org wrote: Author: markt Date: Fri Mar 11 18:40:13 2011 New Revisi

Re: svn commit: r1183612 [2/2] - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-13 Thread Filip Hanik - Dev Lists
sonal formatting preference for one developer, down the line can make it a lot harder to trace changes for others. Filip On 1/13/2012 3:34 PM, Konstantin Kolinko wrote: 2012/1/14 Filip Hanik - Dev Lists: Commits like this, make it very difficult to trace down changes in the SVN history. I know both

Re: svn commit: r1080719 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-01-16 Thread Filip Hanik - Dev Lists
/01/2012 22:04, Filip Hanik - Dev Lists wrote: I'm looking for a better reason for this change. What was the reasoning behind this limitation, as it breaks years of compatibility. Workaround is to point docBase to a directory. The reasoning was that the documentation said one thing (that

Re: AccessLogValve enhancement

2012-02-17 Thread Filip Hanik - Dev Lists
On 2/16/2012 2:12 PM, Konstantin Kolinko wrote: Do not send attachments to this mailing list ever! The world could implode!! - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@

Re: AccessLogValve enhancement

2012-02-17 Thread Filip Hanik - Dev Lists
On 2/17/2012 8:55 AM, Francis Galiegue wrote: While AccessLogValve is the subject... Any chance we can do away with the default, unparseable timestamp format? With Apache, it is allowed to specify the timestamp using strftime(3)-like format, I'd like to be able to do the same with Tomcat's Acces

Re: WebSocket status

2012-02-28 Thread Filip Hanik - Dev Lists
On 2/28/2012 4:08 AM, Mark Thomas wrote: WebSocket is working with good performance and passing all Autobahn tests on BIO, NIO and APR. Currently, all three connectors using blocking IO throughout so there is a one to one mapping between threads and connections. Therefore, scalability is not wha

Re: [VOTE] Release Apache Tomcat Native 1.1.23

2012-02-28 Thread Filip Hanik - Dev Lists
[+1] Released Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: WebSocket status

2012-02-28 Thread Filip Hanik - Dev Lists
On 2/28/2012 11:39 AM, Mark Thomas wrote: On 28/02/2012 16:58, Filip Hanik - Dev Lists wrote: On 2/28/2012 4:08 AM, Mark Thomas wrote: WebSocket is working with good performance and passing all Autobahn tests on BIO, NIO and APR. Currently, all three connectors using blocking IO throughout so

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
On 3/1/2012 5:33 AM, Mark Thomas wrote: On 01/03/2012 11:31, Mark Thomas wrote: On 28/02/2012 21:29, Mark Thomas wrote: On 28/02/2012 18:53, Filip Hanik - Dev Lists wrote: On 2/28/2012 11:39 AM, Mark Thomas wrote: You may also be able to help with some problems I am having getting non

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
I have a draft patch [1] that seems to fix this. A similar change would be required for the Comet part of Poller.processKey() Thoughts and/or comments? Not knowing the NIO code very well, there might be a better way to achieve the same result that I haven't seen. Mark [1] http://people.apache

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
Mark, what buffer size are you referring to increase for the web socket tests to all pass? Filip On 3/1/2012 9:42 AM, Mark Thomas wrote: On 01/03/2012 15:03, Filip Hanik - Dev Lists wrote: I have a draft patch [1] that seems to fix this. A similar change would be required for the Comet part

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
I see, MessageInbound has hard coded receive buffers. Got it Filip On 3/1/2012 10:13 AM, Filip Hanik - Dev Lists wrote: Mark, what buffer size are you referring to increase for the web socket tests to all pass? Filip On 3/1/2012 9:42 AM, Mark Thomas wrote: On 01/03/2012 15:03, Filip Hanik

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
On 2/28/2012 11:39 AM, Mark Thomas wrote: Thanks for the feedback. You may also be able to help with some problems I am having getting non-blocking behaviour between messages with NIO. I'm not 100% clear what is happening yet, but I think it is something like: - HTTP GET (with upgrade request ar

Re: svn commit: r1295724 - in /tomcat/trunk/webapps/examples/WEB-INF: classes/websocket/EchoMessage.java web.xml

2012-03-01 Thread Filip Hanik - Dev Lists
On 3/1/2012 11:42 AM, Mark Thomas wrote: On 01/03/2012 18:27, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 18:27:56 2012 New Revision: 1295724 URL: http://svn.apache.org/viewvc?rev=1295724&view=rev Log: Allow the examples to configure the buffer on the fly Guess you beat me to it.

Re: WebSocket status

2012-03-01 Thread Filip Hanik - Dev Lists
od for thought :) On 3/1/2012 11:15 AM, Mark Thomas wrote: On 01/03/2012 18:01, Filip Hanik - Dev Lists wrote: Alright, now that I'm all squared away with Autobahn and test cases running. Is there a specific unit test you have to produce this behavior? That would help me for digging

Re: svn commit: r1295978 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11NioProtocol.java upgrade/UpgradeNioProcessor.java

2012-03-01 Thread Filip Hanik - Dev Lists
Thanks for that John, I'll fix that too. Filip On 3/1/2012 4:42 PM, Johno Crawford wrote: On 2/03/2012 12:05 AM, fha...@apache.org wrote: Author: fhanik Date: Thu Mar 1 23:05:51 2012 New Revision: 1295978 URL: http://svn.apache.org/viewvc?rev=1295978&view=rev Log: Fix WebSocket's non blockin

Re: WebSocket status

2012-03-02 Thread Filip Hanik - Dev Lists
On 3/2/2012 2:13 AM, Mark Thomas wrote: You can't register on a selector using another thread. Bingo. That explains it. Is that documented anywhere? I'm not sure if the java.nio documentation says it, I think it does. The Selector object is not thread safe. trying to manipulate interestops and

WebSockets in Tomcat 6

2012-03-14 Thread Filip Hanik Mailing Lists
http://people.apache.org/~fhanik/reports/servers/ Attached is a patch that leverages the Tomcat WebSocket API with minimalistic changes and uses that to implement WebSockets in Tomcat 6.0.x http://people.apache.org/~fhanik/websockets-for-tomcat-6.patch This implementation doesn't touch the endp

Re: WebSocket status

2012-03-14 Thread Filip Hanik - Dev Lists
On 3/14/2012 8:14 AM, Mark Thomas wrote: On 14/03/2012 10:15, Johno Crawford wrote: On 8/03/2012 9:10 PM, Mark Thomas wrote: On 08/03/2012 09:12, Johno Crawford wrote: What's next / left on the TODO list Mark? Anything I can help out with? Porting the generic HTTP upgrade followed by the WebS

Re: WebSockets in Tomcat 6

2012-03-15 Thread Filip Hanik - Dev Lists
On 3/15/2012 6:54 AM, Mark Thomas wrote: On 14/03/2012 17:42, Filip Hanik Mailing Lists wrote: http://people.apache.org/~fhanik/reports/servers/ Attached is a patch that leverages the Tomcat WebSocket API with minimalistic changes and uses that to implement WebSockets in Tomcat 6.0.x http

Re: WebSockets in Tomcat 6

2012-03-16 Thread Filip Hanik Mailing Lists
- Original Message - > From: "Costin Manolache" > > I haven't looked at the tomcat6/tomcat7 interfaces, but I think the > current > hook mechanism used by spdy could be ported with minimal risk and > could be > used by websockets. Tomcat 7 may be a candidate. Tomcat 6, If I was an adm

RE: svn commit: r1302948 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/ main/java/org/apache/tomcat/jdbc/pool/jmx/ test/java/org/apache/tomcat/jdbc/test/

2012-03-20 Thread Filip Hanik (mailing lists)
> -Original Message- > > There is no need in the above clone() method. > It has the same access level (protected) as super one. > > I see that PoolProperties is written as "implements Cloneable". In > such case the clone method is usually redeclared as

RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java

2012-03-20 Thread Filip Hanik (mailing lists)
I need to investigate this, and why my config file is not being picked up by subversion Best Filip > -Original Message- > From: kkoli...@apache.org [mailto:kkoli...@apache.org] > Sent: Tuesday, March 20, 2012 12:39 PM > To: dev@tomcat.apache.org > Subject: svn commit: r1303082 - /tomcat/

RE: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java

2012-03-20 Thread Filip Hanik (mailing lists)
Have we published a check style configuration file? > -Original Message- > From: kkoli...@apache.org [mailto:kkoli...@apache.org] > Sent: Tuesday, March 20, 2012 12:56 PM > To: dev@tomcat.apache.org > Subject: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: > doc/jdbc-pool.xml >

Re: [VOTE] Release Apache Tomcat Connectors 1.2.34

2012-03-21 Thread Filip Hanik Mailing Lists
> [X] Stable, go ahead and release - Original Message - > From: "Henri Gomez" > To: "Tomcat Developers List" > Sent: Wednesday, March 21, 2012 2:33:58 AM > Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.34 > > > The Apache Tomcat Connectors 1.2.34 is > >  [X] Stable, go ahead

RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java

2012-03-21 Thread Filip Hanik (mailing lists)
ject: Re: svn commit: r1303082 - /tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException. > java > > 2012/3/20 Filip Hanik (mailing lists) : > > I need to investigate this, and why my config file is not being picked up by > subversion &g

RE: [VOTE] Release Apache Tomcat Connectors 1.2.35

2012-03-22 Thread Filip Hanik (mailing lists)
[X] Stable, go ahead and release > -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: Thursday, March 22, 2012 10:50 AM > To: Tomcat Developers List > Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.35 > > On 03/22/2012 02:46 PM, Mladen Turk wrote: > > > > T

RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java

2012-03-22 Thread Filip Hanik (mailing lists)
On windows, it wasn't picking up ~/.subversion/config but ~/AppData/Roaming/Subversion/config Filip > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednesday, March 21, 2012 6:17 PM > To: 'Tomcat Developers List'

Re: SPDY support

2012-03-25 Thread Filip Hanik Mailing Lists
Tomcat 7 is a Servlet 3.0 implementation with requirements to support Java 6, wouldn't this break that contract if we do it for NIO/BIO? Could this be done as a extras package for the Java connectors? Why not add this into trunk first, and work with it there, as opposed to an external repository?

RE: svn commit: r1305931 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/pool/ src/main/java/org/apache/tomcat/jdbc/pool/jmx/

2012-03-28 Thread Filip Hanik (mailing lists)
lled". When the actual > interruption happens the exception is created and the flag is > cleared.) > > To propagate the interruption state the code would be > > if (propagate) { > Thread.currentThread().interrupt(); > } [Filip Hanik] You are correct. I will adj

RE: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Filip Hanik (mailing lists)
[+1] Released > -Original Message- > From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy > Boynes > Sent: Sunday, March 25, 2012 11:02 PM > To: Tomcat Developers List > Subject: [VOTE] Release Apache Taglibs Parent POM 3 > > The proposed 3 release of Apache Taglibs Parent P

RE: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Filip Hanik (mailing lists)
we only have one binding vote so far. [Filip Hanik] Add your own :) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-28 Thread Filip Hanik (mailing lists)
> UserConfig.java > > +for (Future result : results) { > +try { > +result.get(); > +} catch (Exception e) { > + > host.getLogger().error(sm.getString("userConfig.deploy.threaded.error"), > e); > +} > +

RE: buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-28 Thread Filip Hanik (mailing lists)
Is it my email client, or are some of these emails empty? > -Original Message- > From: build...@apache.org [mailto:build...@apache.org] > Sent: Wednesday, March 28, 2012 10:00 AM > To: dev@tomcat.apache.org > Subject: buildbot failure in ASF Buildbot on tomcat-trunk > -

RE: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-29 Thread Filip Hanik (mailing lists)
Exception e) { > >> + > >> > host.getLogger().error(sm.getString("userConfig.deploy.threaded.error"), > >> e); > >> +            } > >> +        } > >>      } > > [Filip Hanik] > > If results[0].get() fails, are you not going to wait for the others to > complete? &g

Re: [VOTE] Release Apache Tomcat 7.0.27

2012-04-04 Thread Filip Hanik Mailing Lists
[X] Stable - go ahead and release as 7.0.27 Stable - Original Message - > From: "Mark Thomas" > To: "Tomcat Developers List" > Sent: Saturday, March 31, 2012 11:07:30 AM > Subject: [VOTE] Release Apache Tomcat 7.0.27 > > The proposed Apache Tomcat 7.0.27 release is now available for > v

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Filip Hanik Mailing Lists
- Original Message - > From: ma...@apache.org > To: dev@tomcat.apache.org > Sent: Thursday, March 29, 2012 2:19:18 PM > Subject: svn commit: r1307093 - > /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java > > Author: markt > Date: Th

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Filip Hanik Mailing Lists
onFacade.java > > On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote: > > > > > > - Original Message - > >> From: ma...@apache.org To: dev@tomcat.apache.org Sent: Thursday, > >> March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 - &

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Filip Hanik Mailing Lists
eConnectionFacade.java > > 2012/4/4 Filip Hanik Mailing Lists : > > > > > > - Original Message - > >> From: "Mark Thomas" > >> To: "Tomcat Developers List" > >> Sent: Wednesday, April 4, 2012 11:18:42 AM > >>

RE: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-05 Thread Filip Hanik (mailing lists)
e/tomcat/jdbc/pool/DisposableConnectionFacad > e.java > > 2012/4/4 Filip Hanik Mailing Lists : > >> > >> I know of two places where long lines cause problems: > >> > >> 1. Commit e-mails. > >> > >> Long lines are wrapped and it impacts readability

Re: have Re: MaxQueueSize for Executor and Tomcat 6

2012-04-23 Thread Filip Hanik Mailing Lists
- Original Message - > From: "Rüdiger Plüm, Vodafone Group" > > Ok. As far as I can see the new method > > execute(Runnable command, long timeout, TimeUnit unit); > > of the Executor interface is implemented but not used. > Would it still be an acceptable backport if > > 1. The changes

RE: svn commit: r1333218 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml

2012-05-02 Thread Filip Hanik (mailing lists)
Math.min is the intention here. On a 64 core box, it should still only have 2 pollers, not 64 The comment should read ('from' instead of 'of') > > Very hard for applications to see a performance benefit *from* more than 2 > pollers > -Original Message- > From: Christopher Schultz [mailt

RE: [VOTE] Release Apache Tomcat Connectors 1.2.36

2012-05-11 Thread Filip Hanik (mailing lists)
The Apache Tomcat Connectors 1.2.36 is [X] Stable, go ahead and release [ ] Broken because of ... Filip > -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: Friday, May 11, 2012 3:27 AM > To: dev@tomcat.apache.org > Subject: Re: [VOTE] Release Apache Tomcat Conne

RE: svn commit: r1335546 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java

2012-05-15 Thread Filip Hanik (mailing lists)
Yes we should. I can do it today, unless you beat me to it > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Monday, May 14, 2012 5:55 AM > To: Tomcat Developers List > Subject: Re: svn commit: r1335546 - /tomcat/trunk/modules/jdbc- > pool/src/main/jav

Re: svn commit: r1340215 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-21 Thread Filip Hanik Mailing Lists
- Mensaje original - > De: "Rainer Jung" } > > Was that intentional? I'd say the timestamp should be provided by the > log framework and not by java.sql.Date. But maybe the whole message > is > just a leftover from debugging the issue. > > The same for the TC 7 backport. >

RE: [VOTE] Release Apache Tomcat Connectors 1.2.37

2012-05-30 Thread Filip Hanik (mailing lists)
[X] Stable, go ahead and release > -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: Tuesday, May 29, 2012 3:24 AM > To: Tomcat Developers List > Subject: [VOTE] Release Apache Tomcat Connectors 1.2.37 > > Hi, > > Apache Tomcat Connectors 1.2.37 release candidate i

RE: svn commit: r1342473 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-30 Thread Filip Hanik (mailing lists)
Changing a public API method is something I would do for trunk. I'm not sure about a .28 release that is considered stable. Filip > -Original Message- > From: kkoli...@apache.org [mailto:kkoli...@apache.org] > Sent: Thursday, May 24, 2012 5:02 PM > To: dev@tomcat.apache.org > Subject: sv

RE: svn commit: r1342473 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-30 Thread Filip Hanik (mailing lists)
omcat/util/net/NioEndpoint.java > > 2012/5/30 Filip Hanik (mailing lists) : > > Changing a public API method is something I would do for trunk. I'm > not sure about a .28 release that is considered stable. > > "API Stability" section of RELEASE-NOTES.txt says tho

RE: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Filip Hanik (mailing lists)
Ok, this is back to code discipline. At some point, we'd have to expect that more users will adopt v7 in production (I'm still seeing 80%+ being on v6), at that point, commits like this do nothing except pollute the diffs. Servlet 3.1 has released a draft, where I'd expect that trunk is headed.

RE: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Filip Hanik (mailing lists)
rg/apache/tomcat/util/net/AbstractEndpoint.java > > On 04/06/2012 17:05, Filip Hanik (mailing lists) wrote: > > > > Ok, this is back to code discipline. At some point, we'd have to > > expect that more users will adopt v7 in production (I'm still seeing > > 8

RE: Tomcat 7 code policy (was: Re: svn commit: r1345848)

2012-06-05 Thread Filip Hanik (mailing lists)
> a) the change is too complex, > b) touches many components, > c) touches core pieces of Tomcat. > > > I do not think 7.0 will benefit from slow RTC of Tomcat 6, but there > are some patches that are worth a review, and having a formal STATUS > file approach is better that

Time for 7.0.28?

2012-06-12 Thread Filip Hanik (mailing lists)
Over 2 months since last release Got some critical fixes that I would like to see released - max connections broken - send file in nio broken - jdbc pool can hang during DB failure Filip - To unsubscribe, e-mail: dev-unsubsc

RE: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-12 Thread Filip Hanik (mailing lists)
[X] Stable, go ahead and release - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: "WARNING: Incorrect connection count" when running testsuite for APR/native 1.1.24

2012-06-13 Thread Filip Hanik (mailing lists)
This is one example of counting down twice. There are a lot of places calling destroySocket, the best would have been to pass a SocketWrapper instead of long and keep a AtomicBoolean to track if destroy has been called on it. if (running && !paused) { // Hand this socket off to an appropri

RE: svn commit: r1349984 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-06-13 Thread Filip Hanik (mailing lists)
> } else { > -countDownConnection(); > // Close socket and pool right away > destroySocket(socket); > } > [Filip Hanik] 'running' variable could b

RE: svn commit: r1349984 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-06-13 Thread Filip Hanik (mailing lists)
My suggestion for a 7.0.28 is to have -1 for the default value of maxConnections for APR. This disables maxConnections until we have a better grip on it. Changing it to track closures is quite a surgery, something I would do for trunk, but leave out of 7.0.x. This leaves existing code flow inta

RE: svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet: ./ http/

2012-06-26 Thread Filip Hanik (mailing lists)
vlet.include.request_uri"; > > +    static final String INCLUDE_CONTEXT_PATH = > "javax.servlet.include.context_path"; > > +    static final String INCLUDE_PATH_INFO = > "javax.servlet.include.path_info"; > > +    static final String INCLUDE_SERVLET_PATH = >

RE: Timing for 7.0.29

2012-06-26 Thread Filip Hanik (mailing lists)
+1 > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, June 26, 2012 2:12 PM > To: Tomcat Developers List > Subject: Timing for 7.0.29 > > I'm sure circumstances will conspire against me but I am currently > planning to start the 7.0.29 release process earl

Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
As some of you noticed, I added in the stubs for Servlet 3.1 yesterday. I'm planning on starting on 3.1 features, mainly the non blocking read/writes. In Tomcat, we already have an implementation of this in the sandbox http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/ That works fully, and I'll

RE: Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
th happened with the 3.0 async > API, a complete re-write could still happen. [Filip Hanik] That's ok. Non blocking can be done in many ways. As with the sandbox example, it was done without modifying streams, and still worked. So as long as the underlying implementation supports it, I

RE: Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
with happened with the 3.0 async > API, a complete re-write could still happen. [Filip Hanik] I'd expect this API to change public abstract boolean canWrite(); if this returns true, and then I write 1MB of buffered data, what does the system expect this to be non blocking? T

non blocking API

2012-06-28 Thread Filip Hanik (mailing lists)
I posted some feedback to the expert group: http://java.net/projects/servlet-spec/lists/users/archive/2012-06/message/15 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tom

jdbc-pool build in 7.0.28

2012-06-29 Thread Filip Hanik (mailing lists)
Haven't had time to confirm this yet myself. I helped a user troubleshoot an issue, something that looked like a bug that was already fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=53367 The conversation is at http://tomcat.markmail.org/thread/betq2iim6todqlde and when I gave the user

RE: svn commit: r1355615 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/config/realm.xml

2012-07-01 Thread Filip Hanik (mailing lists)
Thanks for the review and fix > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Sunday, July 01, 2012 6:06 AM > To: Tomcat Developers List > Subject: Re: svn commit: r1355615 - in /tomcat/trunk: > java/org/apache/catalina/realm/JNDIRealm.java > webapps

RE: svn commit: r1356849 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2012-07-03 Thread Filip Hanik (mailing lists)
is.existing = existing; > > +this.asyncSupported = isAsyncSupported(); > > I don't get what the purpose of the above line is given that > asyncSupported is set again without apparently being used a few lines > later. What am I missing? [Filip Hanik] That line will hav

RE: buildbot failure in ASF Buildbot on tomcat-trunk

2012-07-03 Thread Filip Hanik (mailing lists)
Will fix! > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Tuesday, July 03, 2012 12:51 PM > To: Tomcat Developers List > Subject: Re: buildbot failure in ASF Buildbot on tomcat-trunk > > 2012/7/3 : > > The Buildbot has detected a new failure on bui

RE: Unit tests and trunk

2012-07-09 Thread Filip Hanik (mailing lists)
I'm on Windows 7 and see TestOutputBuffer fail inconsistently with Java 7 Most runs are failures. I'll be looking into this this week > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Monday, July 09, 2012 4:33 AM > To: Tomcat Developers List > Subject: Unit test

RE: Unit tests and trunk

2012-07-09 Thread Filip Hanik (mailing lists)
This failure happens when the write blocks, and we enter the Selector for a write operation. filip > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Monday, July 09, 2012 2:23 PM > To: 'Tomcat Developers List' > Subject:

RE: Unit tests and trunk

2012-07-10 Thread Filip Hanik (mailing lists)
Ok, definitely a bug in Java 7/Windows 7. If I turn on ProcMon from sysinternals to try to figure out what is going on, the test succeeds everytime. Shutdown procmon, and it hangs again. The Selector is not registering the OP_WRITE event Filip > -Original Message- > From: Filip

RE: Unit tests and trunk

2012-07-10 Thread Filip Hanik (mailing lists)
data > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Tuesday, July 10, 2012 10:43 AM > To: 'Tomcat Developers List' > Subject: RE: Unit tests and trunk > > Ok, definitely a bug in Java 7/Windows 7. > If I turn on

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, July 11, 2012 2:45 AM > To: Tomcat Developers List > Subject: Re: Unit tests and trunk > > On 11/07/2012 02:27, Filip Hanik (mailing lists) wrote: > > Here's what I

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednesday, July 11, 2012 10:13 AM > To: 'Tomcat Developers List' > Subject: RE: Unit tests and trunk > > > > > -Original Message- > &

<    4   5   6   7   8   9   10   11   12   13   >