Yes we should. I can do it today, unless you beat me to it > -----Original Message----- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Monday, May 14, 2012 5:55 AM > To: Tomcat Developers List > Subject: Re: svn commit: r1335546 - /tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionSta > te.java > > 2012/5/8 <fha...@apache.org>: > > Author: fhanik > > Date: Tue May 8 14:17:43 2012 > > New Revision: 1335546 > > > > URL: http://svn.apache.org/viewvc?rev=1335546&view=rev > > Log: > > When a connection is disconnected, make sure we reset the cached > values. This can happen during a failed validation when reconnect() is > called. > > > > Should we include this change into 7.0.x? It looks OK, but I have not > tested. > > The svn:externals value in 7.0.x has not been updated yet. > > Best regards, > Konstantin Kolinko > > > > > Modified: > > tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionSta > te.java > > > > Modified: tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionSta > te.java > > URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionSta > te.java?rev=1335546&r1=1335545&r2=1335546&view=diff > > > ======================================================================== > ====== > > --- tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionSta > te.java (original) > > +++ tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionSta > te.java Tue May 8 14:17:43 2012 > > @@ -110,6 +110,19 @@ public class ConnectionState extends Jdb > > > > } > > > > + > > + @Override > > + public void disconnected(ConnectionPool parent, PooledConnection > con, boolean finalizing) { > > + //we are resetting, reset our defaults > > + autoCommit = null; > > + transactionIsolation = null; > > + readOnly = null; > > + catalog = null; > > + super.disconnected(parent, con, finalizing); > > + } > > + > > + > > + > > @Override > > public Object invoke(Object proxy, Method method, Object[] args) > throws Throwable { > > String name = method.getName(); > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
