Filip Hanik - Dev Lists wrote:
Filip Hanik - Dev Lists wrote:


Mladen Turk wrote:
[EMAIL PROTECTED] wrote:
- ssl = endpoint.getSecure();
+        ssl = "on".equalsIgnoreCase(endpoint.getSSLEngine());


Like Remy said, anything except "Off" is acceptable.
It can be either "On" or "EngineName" (eg, SSLEngine="nuron")
that's for APR, because of
       if (!"off".equalsIgnoreCase(SSLEngine)) {
           // Initialize SSL
           // FIXME: one per VM call ?
           if ("on".equalsIgnoreCase(SSLEngine)) {
               SSL.initialize(null);
           } else {
               SSL.initialize(SSLEngine);
           }

In the HTTP connector, there is no other engine to initialize, hence the only values are on/off \
btw, if the value for SSLEngine can only be used/initialized once per VM, why not put the actual engine value in the APR listener, and not in the connector
to eager to press send, that way the connector would have only on/off values, while the actual SSLEngine value neuron would be in the APRLifeCycleListener,
much cleaner, and all our connectors become consistent on that value


Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to