[GitHub] [tomcat] markt-asf merged pull request #657: Eliminating duplicate execution of checkFacade logic in ResponseFacade

2023-09-06 Thread via GitHub
markt-asf merged PR #657: URL: https://github.com/apache/tomcat/pull/657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[tomcat] branch main updated: Eliminating duplicate execution of checkFacade logic in ResponseFacade (#657)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6e641be1d7 Eliminating duplicate execution of checkFa

[tomcat] branch 10.1.x updated: Eliminating duplicate execution of checkFacade logic in ResponseFacade (#657)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 6df245d186 Eliminating duplicate execution of che

[tomcat] branch 9.0.x updated: Eliminating duplicate execution of checkFacade logic in ResponseFacade (#657)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 115246c33d Eliminating duplicate execution of check

[tomcat] branch 8.5.x updated: Eliminating duplicate execution of checkFacade logic in ResponseFacade (#657)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b1cdb0927c Eliminating duplicate execution of check

[GitHub] [tomcat] markt-asf commented on a diff in pull request #661: Unify conditional statement format for some constants in http1 package

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #661: URL: https://github.com/apache/tomcat/pull/661#discussion_r1316875467 ## java/org/apache/coyote/http11/filters/ChunkedInputFilter.java: ## @@ -574,7 +574,7 @@ private boolean parseHeader() throws IOException { }

[GitHub] [tomcat] markt-asf commented on a diff in pull request #659: Unify constant delimiters and Refactoring for better readability

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #659: URL: https://github.com/apache/tomcat/pull/659#discussion_r1316887097 ## java/org/apache/coyote/http11/Constants.java: ## @@ -106,7 +106,7 @@ public final class Constants { public static final String KEEP_ALIVE_HEADER_VALUE_TOKEN = "k

[GitHub] [tomcat] markt-asf commented on a diff in pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #660: URL: https://github.com/apache/tomcat/pull/660#discussion_r1316890952 ## java/org/apache/catalina/util/SessionConfig.java: ## @@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) { * @return the parameter na

[GitHub] [tomcat] greeng00se commented on a diff in pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
greeng00se commented on code in PR #660: URL: https://github.com/apache/tomcat/pull/660#discussion_r1316896601 ## java/org/apache/catalina/util/SessionConfig.java: ## @@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) { * @return the parameter n

[GitHub] [tomcat] greeng00se commented on a diff in pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
greeng00se commented on code in PR #660: URL: https://github.com/apache/tomcat/pull/660#discussion_r1316896601 ## java/org/apache/catalina/util/SessionConfig.java: ## @@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) { * @return the parameter n

[GitHub] [tomcat] parkmuhyeun commented on pull request #659: Unify constant delimiters and Refactoring for better readability

2023-09-06 Thread via GitHub
parkmuhyeun commented on PR #659: URL: https://github.com/apache/tomcat/pull/659#issuecomment-1707887311 TransferENCODING wasn't mentioned, so I didn't recognize it. I reverted all the stuff about constant names! -- This is an automated message from the Apache Git Service. To respond to t

Buildbot success in on tomcat-11.0.x

2023-09-06 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/562 Blamelist: xxeol2 Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 6e641be1d7365845b947f9a06ab520aba937b9af Steps: worker_preparatio

[GitHub] [tomcat] markt-asf commented on a diff in pull request #662: Simplify and enhance charset extraction from content type

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #662: URL: https://github.com/apache/tomcat/pull/662#discussion_r1316892872 ## java/org/apache/coyote/Request.java: ## @@ -16,19 +16,8 @@ */ package org.apache.coyote; -import java.io.IOException; -import java.io.UnsupportedEncodingExceptio

[GitHub] [tomcat] apptie opened a new pull request, #663: Refactoring the main method of a Tomcat class to improve readability

2023-09-06 Thread via GitHub
apptie opened a new pull request, #663: URL: https://github.com/apache/tomcat/pull/663 Hello! While learning about Tomcat, I see something that I think I can contribute to, so I write this PR. ## Explanation There are two commits here: - Remove the FQCN when creating

[GitHub] [tomcat] sosow0212 opened a new pull request, #664: Improved code readability

2023-09-06 Thread via GitHub
sosow0212 opened a new pull request, #664: URL: https://github.com/apache/tomcat/pull/664 While seeing the code in the Coyote project, I came across this code snippet: `if (!(chr == Constants.SP || chr == Constants.HT))`. It appears to be challenging to read, so I enhanced its rea

[GitHub] [tomcat] markt-asf commented on a diff in pull request #663: Refactoring the main method of a Tomcat class to improve readability

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #663: URL: https://github.com/apache/tomcat/pull/663#discussion_r1316972689 ## java/org/apache/catalina/startup/Tomcat.java: ## @@ -1303,7 +1303,7 @@ public static void main(String[] args) throws Exception { break;

[GitHub] [tomcat] markt-asf commented on pull request #661: Unify conditional statement format for some constants in http1 package

2023-09-06 Thread via GitHub
markt-asf commented on PR #661: URL: https://github.com/apache/tomcat/pull/661#issuecomment-1707956244 See #663 - a single PR would be preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [tomcat] markt-asf commented on pull request #664: Improved code readability

2023-09-06 Thread via GitHub
markt-asf commented on PR #664: URL: https://github.com/apache/tomcat/pull/664#issuecomment-1707957682 See #661 - a single PR would be preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[Bug 67235] NPE (NullPointerException) occurs in AsyncContextImpl.decrementInProgressAsyncCount after version 10.1.12.

2023-09-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235 bclozel changed: What|Removed |Added CC||bclo...@vmware.com -- You are receiving thi

[GitHub] [tomcat] wonyongChoi05 commented on a diff in pull request #662: Simplify and enhance charset extraction from content type

2023-09-06 Thread via GitHub
wonyongChoi05 commented on code in PR #662: URL: https://github.com/apache/tomcat/pull/662#discussion_r1317009172 ## java/org/apache/coyote/Request.java: ## @@ -853,24 +846,22 @@ public boolean isProcessing() { * @param contentType a content type header */ priva

[tomcat] branch main updated: Code clean-up - no functional change

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 00656b324c Code clean-up - no functional change 00656

[tomcat] branch 10.1.x updated: Code clean-up - no functional change

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new bd2e80c98b Code clean-up - no functional change b

[tomcat] branch 9.0.x updated: Code clean-up - no functional change

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9213e5a57e Code clean-up - no functional change 921

[tomcat] branch 8.5.x updated: Code clean-up - no functional change

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f21a460e40 Code clean-up - no functional change f21

[Bug 67235] NPE (NullPointerException) occurs in AsyncContextImpl.decrementInProgressAsyncCount after version 10.1.12.

2023-09-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235 --- Comment #1 from Mark Thomas --- Are you using HTTP/2 for these requests? I'm guessing not but just wanted to check. -- You are receiving this mail because: You are the assignee for the bug.

[GitHub] [tomcat] iamjooon2 commented on pull request #652: Upgrade Readability by removing brackets and depth

2023-09-06 Thread via GitHub
iamjooon2 commented on PR #652: URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708065150 HI @markt-asf I read codes in apache/coyote I found -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[Bug 67235] NPE (NullPointerException) occurs in AsyncContextImpl.decrementInProgressAsyncCount after version 10.1.12.

2023-09-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Mark Thomas

[GitHub] [tomcat] iamjooon2 commented on pull request #652: Upgrade Readability by removing brackets and depth

2023-09-06 Thread via GitHub
iamjooon2 commented on PR #652: URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708120119 Hello from Korea @markt-asf I unified all of conventions in package apache/coyote 1. unify conditional convention e.g ```java // from if (type == Constants.JK_AJP13_CPI

[Bug 67235] NPE (NullPointerException) occurs in AsyncContextImpl.decrementInProgressAsyncCount after version 10.1.12.

2023-09-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235 --- Comment #3 from brigh...@toss.im --- I did not use HTTP2. This issue occurred when setting up SSE (Server-Sent Events), and it's expected that this could always happen when using an asynchronous servlet. I'm building a server using the Spri

[GitHub] [tomcat] iamjooon2 commented on pull request #652: Upgrade Readability by removing brackets and depth

2023-09-06 Thread via GitHub
iamjooon2 commented on PR #652: URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708163596 My mistake! I rollbacked some codes. I really appreciate for your comment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tomcat] Jaeyoung22 commented on pull request #661: Unify conditional statement format for some constants in http1 package

2023-09-06 Thread via GitHub
Jaeyoung22 commented on PR #661: URL: https://github.com/apache/tomcat/pull/661#issuecomment-1708220046 I've taken note of what you've said. ## 1. remove unnecessary parentheses throughout the package Personally, I find conditional statements with three or more conditions to be mor

[GitHub] [tomcat] markt-asf merged pull request #659: Unify constant delimiters and Refactoring for better readability

2023-09-06 Thread via GitHub
markt-asf merged PR #659: URL: https://github.com/apache/tomcat/pull/659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[tomcat] branch main updated (00656b324c -> 9c908d2c29)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 00656b324c Code clean-up - no functional change add 9c908d2c29 Unify constant delimiters and Refactoring for better

[GitHub] [tomcat] markt-asf commented on pull request #659: Unify constant delimiters and Refactoring for better readability

2023-09-06 Thread via GitHub
markt-asf commented on PR #659: URL: https://github.com/apache/tomcat/pull/659#issuecomment-1708271503 Tx for the PR. I added a commit to remove an unnecessary line of code I spotted while reviewing the PR. -- This is an automated message from the Apache Git Service. To respond to the mes

[tomcat] branch 9.0.x updated: Unify constant delimiters and Refactoring for better readability (#659)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f0ce299b69 Unify constant delimiters and Refactorin

[GitHub] [tomcat] markt-asf commented on a diff in pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #660: URL: https://github.com/apache/tomcat/pull/660#discussion_r1317221552 ## java/org/apache/catalina/util/SessionConfig.java: ## @@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) { * @return the parameter na

[tomcat] branch 10.1.x updated: Unify constant delimiters and Refactoring for better readability (#659)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 33bcb367bc Unify constant delimiters and Refactor

[GitHub] [tomcat] markt-asf merged pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf merged PR #660: URL: https://github.com/apache/tomcat/pull/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[tomcat] branch main updated: Optimize when call getSessionCookieName & getSessionUriParamName (#660)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 65e1c7ddc2 Optimize when call getSessionCookieName &

[tomcat] branch 8.5.x updated: Unify constant delimiters and Refactoring for better readability (#659)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 6a167f4af6 Unify constant delimiters and Refactorin

[GitHub] [tomcat] markt-asf commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1708278473 Tx for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[tomcat] branch 10.1.x updated: Optimize when call getSessionCookieName & getSessionUriParamName (#660)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f818862f36 Optimize when call getSessionCookieNam

[tomcat] branch 9.0.x updated: Optimize when call getSessionCookieName & getSessionUriParamName (#660)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5379510e37 Optimize when call getSessionCookieName

[tomcat] branch 8.5.x updated: Optimize when call getSessionCookieName & getSessionUriParamName (#660)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new cab09fcf75 Optimize when call getSessionCookieName

[GitHub] [tomcat] markt-asf commented on a diff in pull request #662: Simplify and enhance charset extraction from content type

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #662: URL: https://github.com/apache/tomcat/pull/662#discussion_r1317240076 ## java/org/apache/coyote/Request.java: ## @@ -852,25 +854,17 @@ public boolean isProcessing() { * * @param contentType a content type header */ -p

[GitHub] [tomcat] iamjooon2 commented on pull request #652: Upgrade Readability by removing brackets

2023-09-06 Thread via GitHub
iamjooon2 commented on PR #652: URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708308925 I rollbacked some codes. I really appreciate for your comments. Have a good Day -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [tomcat] markt-asf commented on pull request #661: Unify conditional statement format

2023-09-06 Thread via GitHub
markt-asf commented on PR #661: URL: https://github.com/apache/tomcat/pull/661#issuecomment-1708336648 Thanks for the PR. It is so much more efficient to review this sort of change at this sort of scale. Thanks for the De Morgan's law changes. I think those conditions are a lot easie

[GitHub] [tomcat] markt-asf merged pull request #661: Unify conditional statement format

2023-09-06 Thread via GitHub
markt-asf merged PR #661: URL: https://github.com/apache/tomcat/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[tomcat] branch main updated: Unify conditional statement format (#661)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new e34c370a60 Unify conditional statement format (#661)

[tomcat] branch 10.1.x updated: Unify conditional statement format (#661)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 08cb24d124 Unify conditional statement format (#6

[tomcat] branch 9.0.x updated: Unify conditional statement format (#661)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b71907391c Unify conditional statement format (#661

[tomcat] branch 8.5.x updated: Unify conditional statement format (#661)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 7fcb7c9dc9 Unify conditional statement format (#661

[GitHub] [tomcat] ChrissW-R1 opened a new pull request, #665: Update tool-wrapper.bat

2023-09-06 Thread via GitHub
ChrissW-R1 opened a new pull request, #665: URL: https://github.com/apache/tomcat/pull/665 Solved issue with spaces in path. If you install tomcat on windows in a path with spaces, the tool-wrapper.bat could be executed. This PR adds two missing qoutes to solve this issue. -- This

[GitHub] [tomcat] markt-asf commented on pull request #664: Improved code readability

2023-09-06 Thread via GitHub
markt-asf commented on PR #664: URL: https://github.com/apache/tomcat/pull/664#issuecomment-1708352372 Included in #661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf closed pull request #664: Improved code readability

2023-09-06 Thread via GitHub
markt-asf closed pull request #664: Improved code readability URL: https://github.com/apache/tomcat/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[tomcat-connectors] branch main updated: Add additional bounds and error checking when reading AJP messages.

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git The following commit(s) were added to refs/heads/main by this push: new 97da2b17a Add additional bounds and error

[tomcat-connectors] branch main updated: Remove support for implicit mapping (rjung)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git The following commit(s) were added to refs/heads/main by this push: new 0095b6cb8 Remove support for implicit mapp

Tagging mod_jk

2023-09-06 Thread Mark Thomas
Hi all, After a long period of inactivity we have had some bug fixes for mod_jk so I am planning a Tomcat Connectors tag shortly. I need to run through my pre-tag checks and I'll tag after that - hopefully in a couple of hours. If you have any final changes for Tomcat Connectors now is the

[tomcat-connectors] 02/02: Remove reference to deleted file

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit c74414153e43c9886c2e2d44356516f34fed0390 Author: Mark Thomas AuthorDate: Wed Sep 6 16:14:06 2023 +0100 Remo

[tomcat-connectors] branch main updated (0095b6cb8 -> c74414153)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git from 0095b6cb8 Remove support for implicit mapping (rjung) new 20572f572 Add info on 1.2.49 release with estim

[tomcat-connectors] 01/02: Add info on 1.2.49 release with estimated release date

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit 20572f572815ce9d6ceacf666de6212d6964f7eb Author: Mark Thomas AuthorDate: Wed Sep 6 16:07:40 2023 +0100 Add

[tomcat-connectors] branch main updated: Remove references to deleted defines

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git The following commit(s) were added to refs/heads/main by this push: new 34f0d9348 Remove references to deleted def

[tomcat-connectors] branch main updated (34f0d9348 -> b9e035d4f)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git from 34f0d9348 Remove references to deleted defines new 7b13ea4d5 Fix directory paths new 88e806e8b Use t

[tomcat-connectors] 02/03: Use the Tomcat Native solution to fix the CHANGES file

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit 88e806e8bbcac8241da88d148c21dda26b22ddf7 Author: Mark Thomas AuthorDate: Wed Sep 6 17:48:00 2023 +0100 Use

[tomcat-connectors] 03/03: Use UTF-8 consistently

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit b9e035d4fa6728dced13bcae449970075196b8fc Author: Mark Thomas AuthorDate: Wed Sep 6 18:00:07 2023 +0100 Use

[tomcat-connectors] 01/03: Fix directory paths

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit 7b13ea4d579e67d068539c5ac11e7dc1d55c6e5f Author: Mark Thomas AuthorDate: Wed Sep 6 16:51:29 2023 +0100 Fix

[tomcat-connectors] branch main updated: Rename so tooling works

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git The following commit(s) were added to refs/heads/main by this push: new ac0fd4f78 Rename so tooling works ac0fd4f7

[tomcat-connectors] branch main updated: Skip the menu when processing news into text

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git The following commit(s) were added to refs/heads/main by this push: new 3ad622409 Skip the menu when processing ne

[tomcat-connectors] tag JK_1_2_49 created (now 3ad622409)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag JK_1_2_49 in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git at 3ad622409 (commit) No new revisions were added by this update. ---

Re: [tomcat-connectors] tag JK_1_2_49 created (now 3ad622409)

2023-09-06 Thread Mark Thomas
FYI, I'm having issues building the Windows binaries. I am getting what looks like a compilation error. I may need to re-tag. Mark On 06/09/2023 19:22, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag JK_1_2_49 in repo

Re: [tomcat-connectors] tag JK_1_2_49 created (now 3ad622409)

2023-09-06 Thread Rainer Jung
I don't have a windows build setup for mod_jk at hand right now, but if ou want more eyes to look at the error just post it. I am probably responsible for it, because I changes quite a bit if code structure to introduce the logging context. Best regards, Rainer --

Re: [tomcat-connectors] tag JK_1_2_49 created (now 3ad622409)

2023-09-06 Thread Mark Thomas
On 06/09/2023 19:35, Rainer Jung wrote: I don't have a windows build setup for mod_jk at hand right now, but if ou want more eyes to look at the error just post it. I am probably responsible for it, because I changes quite a bit if code structure to introduce the logging context. Thanks ...

Re: [tomcat-connectors] tag JK_1_2_49 created (now 3ad622409)

2023-09-06 Thread Mark Thomas
On 06/09/2023 19:37, Mark Thomas wrote: On 06/09/2023 19:35, Rainer Jung wrote: I don't have a windows build setup for mod_jk at hand right now, but if ou want more eyes to look at the error just post it. I am probably responsible for it, because I changes quite a bit if code structure to intr

[tomcat] branch main updated: Extract out some of the important macros for readability

2023-09-06 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 55aadf3929 Extract out some of the important macros fo

[tomcat] branch main updated: Update description and version

2023-09-06 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 9d204675ef Update description and version 9d204675ef i

svn commit: r63828 - /release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/

2023-09-06 Thread markt
Author: markt Date: Wed Sep 6 19:56:54 2023 New Revision: 63828 Log: Drop old symbols from CDN Removed: release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-con

svn commit: r63829 - in /dev/tomcat/tomcat-connectors/jk: ./ binaries/windows/ binaries/windows/symbols/

2023-09-06 Thread markt
Author: markt Date: Wed Sep 6 20:04:19 2023 New Revision: 63829 Log: Upload Tomcat Connectors 1.2.49 for voting Added: dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.49-windows-i386-symbols.zip (with props) dev/tomcat/tomcat-connectors/jk/binaries/win

[VOTE] Release Apache Tomcat Connectors (JK) 1.2.49

2023-09-06 Thread Mark Thomas
Tag: https://github.com/apache/tomcat-connectors/tree/JK_1_2_49 Source: https://github.com/apache/tomcat-connectors/tree/JK_1_2_49 Dist: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ This is a maintenance release with a handful of bug fixes (compared to 1.2.48) and some c

[GitHub] [tomcat] markt-asf merged pull request #652: Upgrade Readability by removing brackets

2023-09-06 Thread via GitHub
markt-asf merged PR #652: URL: https://github.com/apache/tomcat/pull/652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[tomcat] branch main updated: Upgrade Readability by removing brackets (#652)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new b1fbe2cdbd Upgrade Readability by removing brackets (

[tomcat] branch 10.1.x updated: Upgrade Readability by removing brackets (#652)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new c78beae446 Upgrade Readability by removing bracke

[tomcat] branch 8.5.x updated: Upgrade Readability by removing brackets (#652)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 6cd7182de4 Upgrade Readability by removing brackets

[tomcat] branch 9.0.x updated: Upgrade Readability by removing brackets (#652)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f8e7c14145 Upgrade Readability by removing brackets

[GitHub] [tomcat] markt-asf merged pull request #662: Simplify and enhance charset extraction from content type

2023-09-06 Thread via GitHub
markt-asf merged PR #662: URL: https://github.com/apache/tomcat/pull/662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[tomcat] branch main updated: Simplify and enhance charset extraction from content type (#662)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a2ec03a342 Simplify and enhance charset extraction fr

[tomcat] branch 9.0.x updated: Simplify and enhance charset extraction from content type (#662)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6691ad1b22 Simplify and enhance charset extraction

[tomcat] branch 8.5.x updated: Simplify and enhance charset extraction from content type (#662)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 394643725d Simplify and enhance charset extraction

[tomcat] branch 10.1.x updated: Simplify and enhance charset extraction from content type (#662)

2023-09-06 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 5a94b930ab Simplify and enhance charset extractio

[GitHub] [tomcat] greeng00se commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
greeng00se commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1709145552 @markt-asf thx for good comment XD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [VOTE] Release Apache Tomcat Connectors (JK) 1.2.49

2023-09-06 Thread Christopher Schultz
Mark, On 9/6/23 16:13, Mark Thomas wrote: Tag: https://github.com/apache/tomcat-connectors/tree/JK_1_2_49 Source: https://github.com/apache/tomcat-connectors/tree/JK_1_2_49 Dist: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ This is a maintenance release with a handful

[Bug 67235] NPE (NullPointerException) occurs in AsyncContextImpl.decrementInProgressAsyncCount after version 10.1.12.

2023-09-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67235 --- Comment #4 from Han Li --- It can be reproduced. From my debug observations, it turns out that it's ultimately due to the change of `org.apache.coyote.AsyncStateMachine#asyncError` (Maybe not final reason). Since I'm not very familiar with