markt-asf commented on code in PR #662:
URL: https://github.com/apache/tomcat/pull/662#discussion_r1317240076
##########
java/org/apache/coyote/Request.java:
##########
@@ -852,25 +854,17 @@ public boolean isProcessing() {
*
* @param contentType a content type header
*/
- private static String getCharsetFromContentType(String contentType) {
+ private static String getCharsetFromContentType(String contentType) throws
IOException {
Review Comment:
The PR won't compile because of this addition. Look at how other code (e.g.
in Response) handles the possibility of an IOException. Hint: the method
signature should be unchanged from the original
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
