apptie opened a new pull request, #663:
URL: https://github.com/apache/tomcat/pull/663

   Hello! 
   While learning about Tomcat, I see something that I think I can contribute 
to, so I write this PR.
   
   ## Explanation
   
   There are two commits here:
   
   - Remove the FQCN when creating a Tomcat instance
   - Change the order of equals method calls
   
   ### Remove the FQCN when creating a Tomcat instance
   
   I removed the FQCN when creating the Tomcat instance, because I was creating 
an instance of myself and determined that there were no other Tomcat classes 
inside the org.apache.catalina package.
   
   ### Change the order of equals method calls
   
   Previously, I was comparing strings based on their args(`args[i]`), and I 
thought I could reverse the order to make them a little more readable.
   
   ---
   
   If I've misunderstood something, please let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to