[tomcat] branch main updated: Upgrade Readability by removing brackets (#652)

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new b1fbe2cdbd Upgrade Readability by removing brackets (#652)
b1fbe2cdbd is described below

commit b1fbe2cdbd6066127c9c15ecf1688fea62cbd287
Author: iamjooon2 <iamjoo...@gmail.com>
AuthorDate: Thu Sep 7 05:18:22 2023 +0900

    Upgrade Readability by removing brackets (#652)
    
    Remove needless brackets
---
 java/org/apache/coyote/Request.java                                   | 2 +-
 java/org/apache/coyote/ajp/Constants.java                             | 3 +--
 java/org/apache/coyote/http11/Http11InputBuffer.java                  | 4 ++--
 java/org/apache/coyote/http11/upgrade/UpgradeServletOutputStream.java | 2 +-
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/java/org/apache/coyote/Request.java 
b/java/org/apache/coyote/Request.java
index 0155a6b575..3bbd9fd8a6 100644
--- a/java/org/apache/coyote/Request.java
+++ b/java/org/apache/coyote/Request.java
@@ -867,7 +867,7 @@ public final class Request {
             encoding = encoding.substring(0, end);
         }
         encoding = encoding.trim();
-        if ((encoding.length() > 2) && (encoding.startsWith("\"")) && 
(encoding.endsWith("\""))) {
+        if (encoding.length() > 2 && encoding.startsWith("\"") && 
encoding.endsWith("\"")) {
             encoding = encoding.substring(1, encoding.length() - 1);
         }
 
diff --git a/java/org/apache/coyote/ajp/Constants.java 
b/java/org/apache/coyote/ajp/Constants.java
index bdda943754..f124d8ebcb 100644
--- a/java/org/apache/coyote/ajp/Constants.java
+++ b/java/org/apache/coyote/ajp/Constants.java
@@ -173,8 +173,7 @@ public final class Constants {
 
     static {
         try {
-            int i;
-            for (i = 0; i < SC_RESP_AJP13_MAX; i++) {
+            for (int i = 0; i < SC_RESP_AJP13_MAX; i++) {
                 responseTransMap.put(getResponseHeaderForCode(i), 
Integer.valueOf(0xA001 + i));
             }
         } catch (Exception e) {
diff --git a/java/org/apache/coyote/http11/Http11InputBuffer.java 
b/java/org/apache/coyote/http11/Http11InputBuffer.java
index 9c125aef58..78c9c1463b 100644
--- a/java/org/apache/coyote/http11/Http11InputBuffer.java
+++ b/java/org/apache/coyote/http11/Http11InputBuffer.java
@@ -555,7 +555,7 @@ public class Http11InputBuffer implements InputBuffer, 
ApplicationBufferHandler
                 }
             }
 
-            if ((end - parsingRequestLineStart) > 0) {
+            if (end - parsingRequestLineStart > 0) {
                 request.protocol().setBytes(byteBuffer.array(), 
parsingRequestLineStart, end - parsingRequestLineStart);
                 parsingRequestLinePhase = 7;
             }
@@ -902,7 +902,7 @@ public class Http11InputBuffer implements InputBuffer, 
ApplicationBufferHandler
             }
 
             // chr is next byte of header name. Convert to lowercase.
-            if ((chr >= Constants.A) && (chr <= Constants.Z)) {
+            if (chr >= Constants.A && chr <= Constants.Z) {
                 byteBuffer.put(pos, (byte) (chr - Constants.LC_OFFSET));
             }
         }
diff --git 
a/java/org/apache/coyote/http11/upgrade/UpgradeServletOutputStream.java 
b/java/org/apache/coyote/http11/upgrade/UpgradeServletOutputStream.java
index c1c26607f3..4b6d2a28c9 100644
--- a/java/org/apache/coyote/http11/upgrade/UpgradeServletOutputStream.java
+++ b/java/org/apache/coyote/http11/upgrade/UpgradeServletOutputStream.java
@@ -189,7 +189,7 @@ public class UpgradeServletOutputStream extends 
ServletOutputStream {
             return;
         }
         closed = true;
-        flushInternal((listener == null), false);
+        flushInternal(listener == null, false);
     }
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org