[Bug 57348] New: Basic Authenticator doc mentions Digest Authenticator attributes

2014-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57348 Bug ID: 57348 Summary: Basic Authenticator doc mentions Digest Authenticator attributes Product: Tomcat 6 Version: unspecified Hardware: All URL: http:

[Bug 57348] Basic Authenticator doc mentions Digest Authenticator attributes

2014-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57348 E.D.Adell changed: What|Removed |Added CC||aterrest...@gmail.com -- You are rece

svn commit: r1645440 - /tomcat/trunk/java/javax/el/CompositeELResolver.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 11:52:04 2014 New Revision: 1645440 URL: http://svn.apache.org/r1645440 Log: Code clean-up - no functional change - use longer line length - use 'new' for loops Modified: tomcat/trunk/java/javax/el/CompositeELResolver.java Modified: tomcat/trunk/java/javax/el/C

svn commit: r1645443 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 11:59:43 2014 New Revision: 1645443 URL: http://svn.apache.org/r1645443 Log: instanceof includes a null check Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java URL

svn commit: r1645444 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 12:00:28 2014 New Revision: 1645444 URL: http://svn.apache.org/r1645444 Log: StandardContext doesn't implement authenticator so remove pointless test. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apac

svn commit: r1645445 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 12:01:35 2014 New Revision: 1645445 URL: http://svn.apache.org/r1645445 Log: Trivial clean-up Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java URL: http://svn.ap

svn commit: r1645449 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/ha/authenticator/ java/org/apache/catalina/ha/context/ java/org/apache/catalina/ha/session/ java/org/ap

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 12:32:22 2014 New Revision: 1645449 URL: http://svn.apache.org/r1645449 Log: Remove unnecessary "x != null" tests before "x instanceof ..." tests Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java tomcat/trunk/java/org/apache/catalina/co

svn commit: r1645450 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 12:37:14 2014 New Revision: 1645450 URL: http://svn.apache.org/r1645450 Log: CTR Docs update Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57348 Remove references to DIGEST auth config attributes from BASIC auth docs. Modified: tomcat/tc6.0.x/trunk/weba

[Bug 57348] Basic Authenticator doc mentions Digest Authenticator attributes

2014-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57348 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1645455 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java java/org/apache/catalina/realm/mbeans-descriptors.xml webapps/docs/config/realm.xml

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 13:07:11 2014 New Revision: 1645455 URL: http://svn.apache.org/r1645455 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57209 Add new JNDIRealm configuration userSearchAsUser Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java to

svn commit: r1645456 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/realm/JNDIRealm.java java/org/apache/catalina/realm/mbeans-descriptors.xml webapps/docs/changelog.xml webapps/docs/config/r

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 13:08:57 2014 New Revision: 1645456 URL: http://svn.apache.org/r1645456 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57209 Add new JNDIRealm configuration userSearchAsUser Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/

svn commit: r1645457 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/JNDIRealm.java java/org/apache/catalina/realm/mbeans-descriptors.xml webapps/docs/changelog.xml webapps/docs/config/r

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 13:10:32 2014 New Revision: 1645457 URL: http://svn.apache.org/r1645457 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57209 Add new JNDIRealm configuration userSearchAsUser Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/

[Bug 57209] JNDIRealm userSearch does not work against active directory with roles

2014-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57209 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: svn commit: r1645440 - /tomcat/trunk/java/javax/el/CompositeELResolver.java

2014-12-14 Thread Mark Thomas
On 14/12/2014 11:52, ma...@apache.org wrote: > Author: markt > Date: Sun Dec 14 11:52:04 2014 > New Revision: 1645440 > > URL: http://svn.apache.org/r1645440 > Log: > Code clean-up > - no functional change > - use longer line length > - use 'new' for loops Hmm. This appears to have broken a whole

svn commit: r1645458 - /tomcat/trunk/java/javax/el/CompositeELResolver.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 14:43:36 2014 New Revision: 1645458 URL: http://svn.apache.org/r1645458 Log: Partially revert 1645440. Can't use 'new' for loop here as array is not always full. Modified: tomcat/trunk/java/javax/el/CompositeELResolver.java Modified: tomcat/trunk/java/javax/el

Re: svn commit: r1645444 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread Konstantin Kolinko
2014-12-14 15:00 GMT+03:00 : > Author: markt > Date: Sun Dec 14 12:00:28 2014 > New Revision: 1645444 > > URL: http://svn.apache.org/r1645444 > Log: > StandardContext doesn't implement authenticator so remove pointless test. I think you are wrong here, though I do not know of a use case. Maybe it

Re: svn commit: r1645444 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread Mark Thomas
On 14/12/2014 15:25, Konstantin Kolinko wrote: > 2014-12-14 15:00 GMT+03:00 : >> Author: markt >> Date: Sun Dec 14 12:00:28 2014 >> New Revision: 1645444 >> >> URL: http://svn.apache.org/r1645444 >> Log: >> StandardContext doesn't implement authenticator so remove pointless test. > > I think you

Re: svn commit: r1645444 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread Konstantin Kolinko
2014-12-14 18:33 GMT+03:00 Mark Thomas : > On 14/12/2014 15:25, Konstantin Kolinko wrote: >> 2014-12-14 15:00 GMT+03:00 : >>> Author: markt >>> Date: Sun Dec 14 12:00:28 2014 >>> New Revision: 1645444 >>> >>> URL: http://svn.apache.org/r1645444 >>> Log: >>> StandardContext doesn't implement authen

svn commit: r1645465 - in /tomcat/trunk: java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java test/org/apache/catalina/mbeans/TestRe

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 16:10:10 2014 New Revision: 1645465 URL: http://svn.apache.org/r1645465 Log: Don't hard-code domain of StoreConfig MBean to 'Catalina' but use the domain name configured for the associated server. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardSer

svn commit: r1645466 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java test/org/apache/catalina/mb

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 16:14:07 2014 New Revision: 1645466 URL: http://svn.apache.org/r1645466 Log: Don't hard-code domain of StoreConfig MBean to 'Catalina' but use the domain name configured for the associated server. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8

[Bug 57344] [PATCH] Provide sha1 checksum files for Tomcat downloads

2014-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57344 --- Comment #7 from Konstantin Kolinko --- Created attachment 32287 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32287&action=edit 2014-12-14_tc6_57344_sha1.patch Patch for Tomcat 6. Add sha1 checksums. I am not backporting G

svn commit: r1645467 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-12-14 Thread kkolinko
Author: kkolinko Date: Sun Dec 14 16:15:42 2014 New Revision: 1645467 URL: http://svn.apache.org/r1645467 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1645467&r1=164546

Re: svn commit: r1645466 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java test/org/apache/catalin

2014-12-14 Thread Konstantin Kolinko
2014-12-14 19:14 GMT+03:00 : > Author: markt > Date: Sun Dec 14 16:14:07 2014 > New Revision: 1645466 > > URL: http://svn.apache.org/r1645466 > Log: > Don't hard-code domain of StoreConfig MBean to 'Catalina' but use the domain > name configured for the associated server. > > Modified: > tomc

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-12-14 Thread Bill Barker
it-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141214-native-src.tar.gz -Dexamples.sources.skip=true

Re: svn commit: r1645466 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java test/org/apache/catalin

2014-12-14 Thread Mark Thomas
On 14/12/2014 16:31, Konstantin Kolinko wrote: > 2014-12-14 19:14 GMT+03:00 : >> Author: markt >> Date: Sun Dec 14 16:14:07 2014 >> New Revision: 1645466 >> >> URL: http://svn.apache.org/r1645466 >> Log: >> Don't hard-code domain of StoreConfig MBean to 'Catalina' but use the domain >> name confi

svn commit: r1645469 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardServer.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 17:04:50 2014 New Revision: 1645469 URL: http://svn.apache.org/r1645469 Log: Consistently handle missing StoreConfig MBean for Server and Context case. Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties tomcat/trunk/java/org/apache/

svn commit: r1645471 - in /tomcat/trunk/java/org/apache/catalina/manager: LocalStrings.properties ManagerServlet.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 17:09:45 2014 New Revision: 1645471 URL: http://svn.apache.org/r1645471 Log: When using the (currently undocumented) save command, go direct to the StoreConfig MBean because: - It removes the dependency on StandardServer. - It enables the Manager Servlet to detect i

svn commit: r1645473 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/manager/ java/org/apache/catalina/storeconfig/ test/org/apache/catalina/mbeans/

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 17:17:09 2014 New Revision: 1645473 URL: http://svn.apache.org/r1645473 Log: Partial revert of r1645465 since StoreConfig is at the Server/JVM level so there is only ever one of them. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

svn commit: r1645475 - in /tomcat/trunk/java/org/apache/catalina/storeconfig: LocalStrings.properties StoreConfigLifecycleListener.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 17:25:39 2014 New Revision: 1645475 URL: http://svn.apache.org/r1645475 Log: No need to restrict StoreConfigListener to StandardServer. Log a warning it it is added to anything other than a Server Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/Local

svn commit: r1645480 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/manager/ java/org/apache/catalina/storeconfig/ test/org/apache/catalina/mbeans/ webapps/docs

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 18:02:24 2014 New Revision: 1645480 URL: http://svn.apache.org/r1645480 Log: Back-port various StoreConfig improvements: - Consistently handle missing StoreConfig MBean for Server and Context case. - Improve integration with Manager application - Partial revert of r1

svn commit: r1645481 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 18:06:00 2014 New Revision: 1645481 URL: http://svn.apache.org/r1645481 Log: Whoops. That utility method isn't available in 8.0.x Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java Modified: tomcat/tc8.0.x/tr

svn commit: r1645486 - in /tomcat/trunk/test/org/apache/catalina: startup/TomcatBaseTest.java valves/rewrite/TestRewriteValve.java

2014-12-14 Thread rjung
Author: rjung Date: Sun Dec 14 18:29:12 2014 New Revision: 1645486 URL: http://svn.apache.org/r1645486 Log: Add new RequestDescriptor class which contains parsed data returned from the SnoopServlet. Adjust TestRewriteValve to use RequestDescriptor. Modified: tomcat/trunk/test/org/apache/cata

svn commit: r1645487 - in /tomcat/trunk: java/org/apache/catalina/manager/ManagerServlet.java webapps/docs/config/listeners.xml webapps/docs/manager-howto.xml

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 18:31:54 2014 New Revision: 1645487 URL: http://svn.apache.org/r1645487 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57267 Add the following for the manager's save command: - basic description in Manager Javadoc - document the StoreConfigLifecycleListe

svn commit: r1645488 - in /tomcat/trunk/test/org/apache/coyote/ajp: SimpleAjpClient.java TestAbstractAjpProcessor.java TesterAjpMessage.java

2014-12-14 Thread rjung
Author: rjung Date: Sun Dec 14 18:32:42 2014 New Revision: 1645488 URL: http://svn.apache.org/r1645488 Log: Add more thorough tests for AJP. Unfortunately request attributes as sent by mod_jk JkEnvVars can not be tested, because request.getAttributeNames() does not return the names of Coyote requ

svn commit: r1645533 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/manager/ManagerServlet.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml webapps/docs/manager-howto.xml

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 22:38:14 2014 New Revision: 1645533 URL: http://svn.apache.org/r1645533 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57267 Add the following for the manager's save command: - basic description in Manager Javadoc - document the StoreConfigLifecycleListe

[Bug 57267] Document /save command in ManagerServlet and StoreConfig feature

2014-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57267 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1645536 - /tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java

2014-12-14 Thread markt
Author: markt Date: Sun Dec 14 22:50:07 2014 New Revision: 1645536 URL: http://svn.apache.org/r1645536 Log: Fix typo. Doesn't change test but reduces confusion. Modified: tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java Modified: tomcat/trunk/test/org/apache/coyot