2014-12-14 18:33 GMT+03:00 Mark Thomas <ma...@apache.org>: > On 14/12/2014 15:25, Konstantin Kolinko wrote: >> 2014-12-14 15:00 GMT+03:00 <ma...@apache.org>: >>> Author: markt >>> Date: Sun Dec 14 12:00:28 2014 >>> New Revision: 1645444 >>> >>> URL: http://svn.apache.org/r1645444 >>> Log: >>> StandardContext doesn't implement authenticator so remove pointless test. >> >> I think you are wrong here, though I do not know of a use case. Maybe >> it makes sense for some embedded scenario? > > Possibly. > >> StandardContext class is not final, and Authenticator is an interface. >> Some derived class may be an authenticator. >> >> Javadoc for Authenticator says >> "An <b>Authenticator</b> is a component (usually a Valve or Container)". > > Then in that somewhat unusual case, the sub-class can override > getAuthenticator().
Good point. For some reason I was looking at Tomcat 6 sources, where Authenticator is a marker interface without any methods. In Tomcat 7 and later Authenticator has methods, and Context interface has getAuthenticator() method that classes must implement. > Also: > - working from the Authenticator Javadoc I'd expect getAuthentcator() to > appear on Container. > - why special handling like this for Authenticator but not Manager, > Loader, Realm etc? > Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
