On 14/12/2014 16:31, Konstantin Kolinko wrote:
> 2014-12-14 19:14 GMT+03:00 <ma...@apache.org>:
>> Author: markt
>> Date: Sun Dec 14 16:14:07 2014
>> New Revision: 1645466
>>
>> URL: http://svn.apache.org/r1645466
>> Log:
>> Don't hard-code domain of StoreConfig MBean to 'Catalina' but use the domain
>> name configured for the associated server.
>>
>> Modified:
>> tomcat/tc8.0.x/trunk/ (props changed)
>> tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/StandardServer.java
>>
>> tomcat/tc8.0.x/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
>>
>> tomcat/tc8.0.x/trunk/test/org/apache/catalina/mbeans/TestRegistration.java
>> tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
>
> A similar change have already been reverted once:
> r1443872
>
> http://markmail.org/thread/uvd7pxmgwuoewqr4
Thanks. I had completely forgotten that.
> By the way, the <Server> element does not allow to configure a domain,
> and used services[0].getDomain(). If that is not available, then
> LifecycleMBeanBase.getDomain() does fallback to the default name
> ("Catalina").
>
> If you are saying "but use the domain name configured for the
> associated server." it actually uses the name of the first configured
> service, not of the server.
>
> What is a use case for changing domain name of StoreConfig MBean?
> Multiple embedded Tomcat servers in the same JVM?
I'm not sure there is a use case. There is an assumption that there is a
1-1 mapping from Server to JVM.
I'll revert that change and add some comments.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
