2014-12-14 15:00 GMT+03:00 <ma...@apache.org>: > Author: markt > Date: Sun Dec 14 12:00:28 2014 > New Revision: 1645444 > > URL: http://svn.apache.org/r1645444 > Log: > StandardContext doesn't implement authenticator so remove pointless test.
I think you are wrong here, though I do not know of a use case. Maybe it makes sense for some embedded scenario? StandardContext class is not final, and Authenticator is an interface. Some derived class may be an authenticator. Javadoc for Authenticator says "An <b>Authenticator</b> is a component (usually a Valve or Container)". > Modified: > tomcat/trunk/java/org/apache/catalina/core/StandardContext.java > > Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1645444&r1=1645443&r2=1645444&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original) > +++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Sun Dec > 14 12:00:28 2014 > @@ -977,9 +977,6 @@ public class StandardContext extends Con > > @Override > public Authenticator getAuthenticator() { > - if (this instanceof Authenticator) > - return (Authenticator) this; > - > Pipeline pipeline = getPipeline(); > if (pipeline != null) { > Valve basic = pipeline.getBasic(); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
