Tagging 7.0.54

2014-04-28 Thread Violeta Georgieva
Hi, I would like to start preparing 7.0.54 for voting this afternoon. If you want to add something to this release please reply here. Regards Violeta

Re: Time for 8.0.6

2014-04-28 Thread Mark Thomas
On 27/04/2014 12:28, Rémy Maucherat wrote: > 2014-04-27 0:41 GMT+02:00 Mark Thomas : > >> Agreed, but that it out of our control. However, I'm seeing some fairly >> consistent failures with NIO2 and TestCoyoteAdapter.testBug54928 that >> I'd like to get to the bottom of. >> >> It doesn't (usually)

Re: Time for 8.0.6

2014-04-28 Thread Rémy Maucherat
2014-04-28 11:12 GMT+02:00 Mark Thomas : > > This test never fails for me. However, the behavior is not identical to > > NIO (you need more output before getting an IOE, for some reason) so I > > added more wait. > > Oddly, it only fails for me on a VM. I'm still trying to get to the > bottom of t

svn commit: r1590604 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2014-04-28 Thread kkolinko
Author: kkolinko Date: Mon Apr 28 11:27:25 2014 New Revision: 1590604 URL: http://svn.apache.org/r1590604 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Reviewing r1587887: s/ attrs.getValue(i) / attributeValue / in the messages as well, so that the actual expression text that i

Reviewing EL processing fix (BZ 56334)

2014-04-28 Thread Konstantin Kolinko
Hi! I am reviewing the ELParser fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Those are in 7.0: http://svn.apache.org/viewvc?view=revision&revision=r1587887 in 6.0: 1). In java/org/apache/jasper/compiler/Validator.java There was replacement s/ attrs.getValue(i) / attributeVal

svn commit: r1590612 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Validator.java

2014-04-28 Thread kkolinko
Author: kkolinko Date: Mon Apr 28 11:51:52 2014 New Revision: 1590612 URL: http://svn.apache.org/r1590612 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Merged r1590604 from tomcat/trunk: Reviewing r1587887: s/ attrs.getValue(i) / attributeValue / in the messages as well, so tha

Re: Time for 8.0.6

2014-04-28 Thread Mark Thomas
On 28/04/2014 11:06, Rémy Maucherat wrote: > 2014-04-28 11:12 GMT+02:00 Mark Thomas : > >>> This test never fails for me. However, the behavior is not identical to >>> NIO (you need more output before getting an IOE, for some reason) so I >>> added more wait. >> >> Oddly, it only fails for me on a

svn commit: r1590635 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 13:43:25 2014 New Revision: 1590635 URL: http://svn.apache.org/r1590635 Log: Increase length of text written so expected exception is triggered on client disconnect with NIO2. Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Mod

svn commit: r1590638 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 13:54:47 2014 New Revision: 1590638 URL: http://svn.apache.org/r1590638 Log: Need even larger writes to keep test happy on Windows VM Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Modified: tomcat/trunk/test/org/apache/catalin

svn commit: r1590646 - in /tomcat/trunk/java/org/apache: catalina/core/AprLifecycleListener.java tomcat/jni/SSL.java

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 14:13:22 2014 New Revision: 1590646 URL: http://svn.apache.org/r1590646 Log: Fix Javadoc warnings Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java tomcat/trunk/java/org/apache/tomcat/jni/SSL.java Modified: tomcat/trunk/java/org

svn commit: r1590647 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2014-04-28 Thread remm
Author: remm Date: Mon Apr 28 14:16:01 2014 New Revision: 1590647 URL: http://svn.apache.org/r1590647 Log: Drop useless null checks. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http://

svn commit: r1590648 - /tomcat/trunk/test/org/apache/jasper/compiler/TestELParser.java

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 14:17:49 2014 New Revision: 1590648 URL: http://svn.apache.org/r1590648 Log: Clarify Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestELParser.java Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestELParser.java URL: http://svn.apache.org/vi

svn commit: r1590651 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/jasper/compiler/TestELParser.java

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 14:20:08 2014 New Revision: 1590651 URL: http://svn.apache.org/r1590651 Log: Clarify escaping Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestELParser.java Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1590652 - /tomcat/tc6.0.x/trunk/test/org/apache/jasper/compiler/TestELParser.java

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 14:21:24 2014 New Revision: 1590652 URL: http://svn.apache.org/r1590652 Log: Clarify Modified: tomcat/tc6.0.x/trunk/test/org/apache/jasper/compiler/TestELParser.java Modified: tomcat/tc6.0.x/trunk/test/org/apache/jasper/compiler/TestELParser.java URL: http://s

svn commit: r1590711 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 17:13:23 2014 New Revision: 1590711 URL: http://svn.apache.org/r1590711 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1590711&r1=1590710&r

svn commit: r1590712 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 17:14:45 2014 New Revision: 1590712 URL: http://svn.apache.org/r1590712 Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1590712&r1=1590711&r2=15

svn commit: r1590713 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 17:15:09 2014 New Revision: 1590713 URL: http://svn.apache.org/r1590713 Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1590713&r1=1590712&r2=15

svn commit: r1590717 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 17:25:57 2014 New Revision: 1590717 URL: http://svn.apache.org/r1590717 Log: More votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1590717&r1=1590716

Re: Reviewing EL processing fix (BZ 56334)

2014-04-28 Thread Violeta Georgieva
Hi, 2014-04-28 14:43 GMT+03:00 Konstantin Kolinko : > > Hi! > > I am reviewing the ELParser fix for > https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 > > Those are > in 7.0: > http://svn.apache.org/viewvc?view=revision&revision=r1587887 > in 6.0: > > 1). In java/org/apache/jasper/compile

svn commit: r1590745 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_54: ./ build.properties.default

2014-04-28 Thread violetagg
Author: violetagg Date: Mon Apr 28 18:48:46 2014 New Revision: 1590745 URL: http://svn.apache.org/r1590745 Log: Tag 7.0.54 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_54/ (props changed) - copied from r1590742, tomcat/tc7.0.x/trunk/ Modified: tomcat/tc7.0.x/tags/TOMCAT_7_0_54/build.prop

Re: Reviewing EL processing fix (BZ 56334)

2014-04-28 Thread Konstantin Kolinko
2014-04-28 21:37 GMT+04:00 Violeta Georgieva : > Hi, > >> >> 4) Validator$ValidateVisitor$XmlEscapeNonELVisitor.visit(Text) >> >> The code in ELParser.TextBuilder.visit(Text) was updated to apply >> "escapeLiteralExpression()", but the same method in >> XmlEscapeNonELVisitor has not been updated. >

[Bug 56334] Double Backslash Escaping in Attributes

2014-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 --- Comment #11 from Konstantin Kolinko --- Created attachment 31566 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31566&action=edit 2014-04-28_tc8_XmlEscapeNonELVisitor_tests.patch Additional tests and fix for Validator$Valid

[Bug 56334] Double Backslash Escaping in Attributes

2014-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|F

[Bug 56334] Double Backslash Escaping in Attributes

2014-04-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 --- Comment #12 from Konstantin Kolinko --- (In reply to Konstantin Kolinko from comment #11) 2) With fix in Comment 11 it also breaks TestParser.testBug55198() test case. It now generates HTML that contains (see bug55198.tagx) onclick="w

svn commit: r1590801 - in /tomcat/trunk/java/org/apache/jasper/compiler: Node.java Validator.java

2014-04-28 Thread kkolinko
Author: kkolinko Date: Mon Apr 28 21:17:08 2014 New Revision: 1590801 URL: http://svn.apache.org/r1590801 Log: Document JspAttribute.isDynamic() and correct wrong value of this flag for "omit" attribute of action. I think there were no observable consequences of this typo. The "dynamic" flag m

buildbot failure in ASF Buildbot on tomcat-trunk

2014-04-28 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/36 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stam

Re: Reviewing EL processing fix (BZ 56334)

2014-04-28 Thread Mark Thomas
On 28/04/2014 19:56, Konstantin Kolinko wrote: > 2014-04-28 21:37 GMT+04:00 Violeta Georgieva : >> Hi, >> >>> >>> 4) Validator$ValidateVisitor$XmlEscapeNonELVisitor.visit(Text) >>> >>> The code in ELParser.TextBuilder.visit(Text) was updated to apply >>> "escapeLiteralExpression()", but the same me

svn commit: r1590835 - in /tomcat/trunk: java/org/apache/el/parser/AstLiteralExpression.java test/org/apache/el/TestELEvaluation.java webapps/docs/changelog.xml

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 23:08:14 2014 New Revision: 1590835 URL: http://svn.apache.org/r1590835 Log: Correct the handling of back-slash escaping in the EL parser and no longer require that "\$" or "\#" must be followed by "{" in order for the back-slash escaping to take effect. Modified:

Re: svn commit: r1590835 - in /tomcat/trunk: java/org/apache/el/parser/AstLiteralExpression.java test/org/apache/el/TestELEvaluation.java webapps/docs/changelog.xml

2014-04-28 Thread Konstantin Kolinko
2014-04-29 3:08 GMT+04:00 : > Author: markt > Date: Mon Apr 28 23:08:14 2014 > New Revision: 1590835 > > URL: http://svn.apache.org/r1590835 > Log: > Correct the handling of back-slash escaping in the EL parser and no longer > require that "\$" or "\#" must be followed by "{" in order for the bac

Re: svn commit: r1590835 - in /tomcat/trunk: java/org/apache/el/parser/AstLiteralExpression.java test/org/apache/el/TestELEvaluation.java webapps/docs/changelog.xml

2014-04-28 Thread Mark Thomas
On 29/04/2014 00:16, Konstantin Kolinko wrote: > 2014-04-29 3:08 GMT+04:00 : >> Author: markt >> Date: Mon Apr 28 23:08:14 2014 >> New Revision: 1590835 >> >> URL: http://svn.apache.org/r1590835 >> Log: >> Correct the handling of back-slash escaping in the EL parser and no longer >> require that

svn commit: r1590838 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/parser/AstLiteralExpression.java test/org/apache/el/TestELEvaluation.java webapps/docs/changelog.xml

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 23:22:49 2014 New Revision: 1590838 URL: http://svn.apache.org/r1590838 Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/el/parser/AstLiteralExpression.java tomcat/tc7.0.x/trunk/test/org/apache/el/TestEL

svn propchange: r1590838 - svn:log

2014-04-28 Thread markt
Author: markt Revision: 1590838 Modified property: svn:log Modified: svn:log at Mon Apr 28 23:24:36 2014 -- --- svn:log (original) +++ svn:log Mon Apr 28 23:24:36 2014 @@ -0,0 +1 @@ +Correct the handling of back-slash esca

svn commit: r1590841 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-28 Thread markt
Author: markt Date: Mon Apr 28 23:25:22 2014 New Revision: 1590841 URL: http://svn.apache.org/r1590841 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1590841&r1=1590840&r

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-04-28 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/41 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1590842 - in /tomcat/trunk: java/org/apache/jasper/compiler/ test/org/apache/jasper/compiler/ test/webapp/bug5nnnn/ webapps/docs/

2014-04-28 Thread kkolinko
Author: kkolinko Date: Mon Apr 28 23:35:36 2014 New Revision: 1590842 URL: http://svn.apache.org/r1590842 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Additional tests and fixes Includes the following: 1. Allow '\' in xmlns attributes of UninterpretedTag. A test added. (Java

svn commit: r1590844 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Node.java java/org/apache/jasper/compiler/Validator.java

2014-04-28 Thread kkolinko
Author: kkolinko Date: Tue Apr 29 00:01:43 2014 New Revision: 1590844 URL: http://svn.apache.org/r1590844 Log: Merged r1590801 from tomcat/trunk: Document JspAttribute.isDynamic() and correct wrong value of this flag for "omit" attribute of action. I think there were no observable consequences

svn commit: r1590845 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AprLifecycleListener.java java/org/apache/tomcat/jni/SSL.java

2014-04-28 Thread kkolinko
Author: kkolinko Date: Tue Apr 29 00:05:03 2014 New Revision: 1590845 URL: http://svn.apache.org/r1590845 Log: Merged r1590646 from tomcat/trunk: Fix Javadoc warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.

svn commit: r1590848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ test/org/apache/jasper/compiler/ test/webapp-3.0/bug5nnnn/ webapps/docs/

2014-04-28 Thread kkolinko
Author: kkolinko Date: Tue Apr 29 00:19:33 2014 New Revision: 1590848 URL: http://svn.apache.org/r1590848 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56334 Merged r1590842 from tomcat/trunk: Additional tests and fixes Includes the following: 1. Allow '\' in xmlns attributes of Uni

svn commit: r1590851 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-28 Thread kkolinko
Author: kkolinko Date: Tue Apr 29 00:26:46 2014 New Revision: 1590851 URL: http://svn.apache.org/r1590851 Log: votes and proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1590851

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2014-04-28 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. Th

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2014-04-28 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This

Re: Reviewing EL processing fix (BZ 56334)

2014-04-28 Thread Violeta Georgieva
На вторник, 29 април 2014 г. Mark Thomas написа: > On 28/04/2014 19:56, Konstantin Kolinko wrote: >> 2014-04-28 21:37 GMT+04:00 Violeta Georgieva : >>> Hi, >>> 4) Validator$ValidateVisitor$XmlEscapeNonELVisitor.visit(Text) The code in ELParser.TextBuilder.visit(Text) was update

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2014-04-28 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. T

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2014-04-28 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i

svn commit: r1590875 - /tomcat/tc7.0.x/tags/TOMCAT_7_0_54/

2014-04-28 Thread violetagg
Author: violetagg Date: Tue Apr 29 06:00:03 2014 New Revision: 1590875 URL: http://svn.apache.org/r1590875 Log: Drop the tag in order to get additional fixes. Removed: tomcat/tc7.0.x/tags/TOMCAT_7_0_54/ - To unsubscribe, e-