https://issues.apache.org/bugzilla/show_bug.cgi?id=56334

--- Comment #11 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Created attachment 31566
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31566&action=edit
2014-04-28_tc8_XmlEscapeNonELVisitor_tests.patch

Additional tests and fix for Validator$ValidateVisitor$XmlEscapeNonELVisitor.

Without this fix the patched bug56334.jspx fails at run time:
[[[
org.apache.jasper.JasperException: /bug56334.jspx (line: 34, column: 45)
"05b$${&amp;${1+1}" contains invalid expression(s): javax.el.ELException:
Failed to parse the expression [05b$${&amp;${1+1}]
]]]

With this fix Java fails to compile the generated java file.
bug56334_jspx.java contains:
[[[
      out.write("<set data-value=\"05a\$\${&amp;\"/>");
      out.write("<set data-value=\"" + (java.lang.String)
org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate("05b\\$\\${&amp;${1+1}",
java.lang.String.class, (javax.servlet.jsp.PageContext)_jspx_page_context,
null) + "\"/>");
      out.write("<set data-value=\"" + (java.lang.String)
org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate("05c\\#\\#{&gt;${'hello'}&lt;",
java.lang.String.class, (javax.servlet.jsp.PageContext)_jspx_page_context,
null) + "\"/>");
]]]

In 05a the Java escaping is missing.
In 05b and 05c the Java escaping is OK.

Something else is missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to