svn commit: r1590801 - in /tomcat/trunk/java/org/apache/jasper/compiler: Node.java Validator.java

[kkolinko]

Author: kkolinko
Date: Mon Apr 28 21:17:08 2014
New Revision: 1590801

URL: http://svn.apache.org/r1590801
Log:
Document JspAttribute.isDynamic() and correct wrong value of this flag for 
"omit" attribute of <jsp:attribute> action.

I think there were no observable consequences of this typo. The "dynamic" flag 
makes sense only for attributes of a CustomTag.

Modified:
    tomcat/trunk/java/org/apache/jasper/compiler/Node.java
    tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/Node.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Node.java?rev=1590801&r1=1590800&r2=1590801&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/compiler/Node.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Node.java Mon Apr 28 21:17:08 
2014
@@ -2292,7 +2292,9 @@ abstract class Node implements TagConsta
         }
 
         /**
-         * XXX
+         * <code>true</code> if the attribute is a "dynamic" attribute of a
+         * custom tag that implements DynamicAttributes interface. That is,
+         * a random extra attribute that is not declared by the tag.
          */
         public boolean isDynamic() {
             return dynamic;

Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Validator.java?rev=1590801&r1=1590800&r2=1590801&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/compiler/Validator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Mon Apr 28 
21:17:08 2014
@@ -694,7 +694,7 @@ class Validator {
         public void visit(Node.NamedAttribute n) throws JasperException {
             JspUtil.checkAttributes("Attribute", n, attributeAttrs, err);
             n.setOmit(getJspAttribute(null, "omit", null, null, n
-                    .getAttributeValue("omit"), n, true));
+                    .getAttributeValue("omit"), n, false));
             visitBody(n);
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org