Re: [VOTE] Release build 6.0.23

On 15/01/2010 07:42, Rainer Jung wrote: > On 15.01.2010 08:22, jean-frederic clere wrote: >> On 01/14/2010 10:45 PM, Filip Hanik - Dev Lists wrote: >>> >>> if all we find wrong is line endings, then I would suggest >>> 1. fix the packaging script >>> 2. Add the fix to the tag >>> 3. rerun the scrip

svn commit: r899569 - in /tomcat/site/trunk: docs/resources.html xdocs/resources.xml

Author: markt Date: Fri Jan 15 09:08:16 2010 New Revision: 899569 URL: http://svn.apache.org/viewvc?rev=899569&view=rev Log: "Tomcat: The Definitive Guide" has a second edition Modified: tomcat/site/trunk/docs/resources.html tomcat/site/trunk/xdocs/resources.xml Modified: tomcat/site/tru

Re: JSP 2.2 & EL 2.2 implementation complete

On 01/14/2010 11:47 PM, Mark Thomas wrote: > The subject says it all really. Still no sign of the TCK so there are > probably some bugs in my understanding/interpretation of the spec. According to my tests: EL : 11 failures. (They looks similar I will have a closer look later). JSP : 1 failures. (

Re: JSP 2.2 & EL 2.2 implementation complete

On 01/15/2010 10:33 AM, jean-frederic clere wrote: > According to my tests: > EL : 11 failures. (They looks similar I will have a closer look later). java/javax/el/ArrayELResolver.java setValue exceptions are missing (Look in http://java.sun.com/javaee/6/docs/api/javax/el/ArrayELResolver.html I do

svn commit: r899593 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: jfclere Date: Fri Jan 15 11:01:49 2010 New Revision: 899593 URL: http://svn.apache.org/viewvc?rev=899593&view=rev Log: My votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

svn commit: r899601 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

Author: markt Date: Fri Jan 15 11:30:21 2010 New Revision: 899601 URL: http://svn.apache.org/viewvc?rev=899601&view=rev Log: Add the bug url Modified: tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java Modified: tomcat/trunk/java/org/apache/catalina/core/JreMem

Re: JSP 2.2 & EL 2.2 implementation complete

On 15/01/2010 10:24, jean-frederic clere wrote: > On 01/15/2010 10:33 AM, jean-frederic clere wrote: >> According to my tests: >> EL : 11 failures. (They looks similar I will have a closer look later). > > java/javax/el/ArrayELResolver.java setValue exceptions are missing (Look > in http://java.su

svn commit: r899606 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: jfclere Date: Fri Jan 15 12:17:22 2010 New Revision: 899606 URL: http://svn.apache.org/viewvc?rev=899606&view=rev Log: My vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=8

DO NOT REPLY [Bug 46337] real worker name is wrong

https://issues.apache.org/bugzilla/show_bug.cgi?id=46337 --- Comment #2 from Ryszard Łach 2010-01-15 04:47:33 UTC --- Hi. First, thanks for excellent work. I'm using mod_jk for quite a long time... I've just spent some time testing behaviour of retries directive of LB worker, I was very confused

DO NOT REPLY [Bug 46337] real worker name is wrong

https://issues.apache.org/bugzilla/show_bug.cgi?id=46337 --- Comment #3 from Rainer Jung 2010-01-15 05:22:27 UTC --- (In reply to comment #2) Please let us not discuss your idea here. It does not belong into this issue and should be discussed on the tomcat users list. One remark: mod_jk is able

svn commit: r899634 - in /tomcat/trunk: java/javax/el/MethodExpression.java java/org/apache/el/MethodExpressionImpl.java test/org/apache/el/TestMethodExpressionImpl.java

Author: markt Date: Fri Jan 15 14:10:11 2010 New Revision: 899634 URL: http://svn.apache.org/viewvc?rev=899634&view=rev Log: The spec has a spelling mistake. Align with the spec until it is fixed. Modified: tomcat/trunk/java/javax/el/MethodExpression.java tomcat/trunk/java/org/apache/el/M

svn commit: r899635 - in /tomcat/trunk/java/javax/servlet/jsp: JspContext.java JspException.java

Author: markt Date: Fri Jan 15 14:17:22 2010 New Revision: 899635 URL: http://svn.apache.org/viewvc?rev=899635&view=rev Log: Fix signature test failures in javax.servlet.jsp package Move deprecation javadoc to end of block Modified: tomcat/trunk/java/javax/servlet/jsp/JspContext.java tomc

Re: [VOTE] Release build 6.0.23

On 01/15/2010 12:22 AM, jean-frederic clere wrote: We have to fix the TCK failures +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 14.01.2010 21:21, ma...@apache.org wrote: Author: markt Date: Thu Jan 14 20:21:23 2010 New Revision: 899395 URL: http://svn.apache.org/viewvc?rev=899395&view=rev Log: zip is for non-windows platforms Hmmm, really? Until recently we didn't have the individual binary release zips for Window

Re: svn commit: r899634 - in /tomcat/trunk: java/javax/el/MethodExpression.java java/org/apache/el/MethodExpressionImpl.java test/org/apache/el/TestMethodExpressionImpl.java

On 15/01/2010 14:10, ma...@apache.org wrote: > Author: markt > Date: Fri Jan 15 14:10:11 2010 > New Revision: 899634 > > URL: http://svn.apache.org/viewvc?rev=899634&view=rev > Log: > The spec has a spelling mistake. Align with the spec until it is fixed. Raised as https://uel.dev.java.net/issues

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 15/01/2010 14:41, Rainer Jung wrote: > On 14.01.2010 21:21, ma...@apache.org wrote: >> Author: markt >> Date: Thu Jan 14 20:21:23 2010 >> New Revision: 899395 >> >> URL: http://svn.apache.org/viewvc?rev=899395&view=rev >> Log: >> zip is for non-windows platforms > > Hmmm, really? I believe so

svn commit: r899649 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Fri Jan 15 14:56:16 2010 New Revision: 899649 URL: http://svn.apache.org/viewvc?rev=899649&view=rev Log: Clarify vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev

svn commit: r899653 - in /tomcat/trunk/java: javax/servlet/jsp/el/ javax/servlet/jsp/tagext/ org/apache/jasper/el/

Author: markt Date: Fri Jan 15 15:00:50 2010 New Revision: 899653 URL: http://svn.apache.org/viewvc?rev=899653&view=rev Log: Fix the remaining TCK signature test failures. Modified: tomcat/trunk/java/javax/servlet/jsp/el/ELException.java tomcat/trunk/java/javax/servlet/jsp/el/ELParseExcep

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: Author: markt Date: Thu Jan 14 20:21:23 2010 New Revision: 899395 URL: http://svn.apache.org/viewvc?rev=899395&view=rev Log: zip is for non-windows platforms Hmmm, really? Until recently we didn't have th

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: I'd prefer keep the package-zip with CRLF (and ensure CRLF in package-deployer-zip too). Just to update. Since beginning of time httpd has x.x-win32-src.zip We could have something like that as well instea

svn commit: r899667 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Fri Jan 15 15:39:04 2010 New Revision: 899667 URL: http://svn.apache.org/viewvc?rev=899667&view=rev Log: Consensus is for crlf on .zip files Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0

svn commit: r899668 - /tomcat/trunk/dist.xml

Author: markt Date: Fri Jan 15 15:40:35 2010 New Revision: 899668 URL: http://svn.apache.org/viewvc?rev=899668&view=rev Log: revert r899395 Modified: tomcat/trunk/dist.xml Modified: tomcat/trunk/dist.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/dist.xml?rev=899668&r1=899667&r2=899668&

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 15/01/2010 15:13, Mladen Turk wrote: > On 01/15/2010 03:41 PM, Rainer Jung wrote: >> On 14.01.2010 21:21, ma...@apache.org wrote: >> >> I'd prefer keep the package-zip with CRLF (and ensure CRLF in >> package-deployer-zip too). >> > > Just to update. > Since beginning of time httpd has x.x-win3

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 01/15/2010 04:41 PM, Mark Thomas wrote: On 15/01/2010 15:13, Mladen Turk wrote: On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: I'd prefer keep the package-zip with CRLF (and ensure CRLF in package-deployer-zip too). Just to update. Since beginning

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 01/15/2010 08:41 AM, Mark Thomas wrote: On 15/01/2010 15:13, Mladen Turk wrote: On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: I'd prefer keep the package-zip with CRLF (and ensure CRLF in package-deployer-zip too). Just to update

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 15/01/2010 15:56, Mladen Turk wrote: > On 01/15/2010 04:41 PM, Mark Thomas wrote: >> On 15/01/2010 15:13, Mladen Turk wrote: >>> On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: I'd prefer keep the package-zip with CRLF (and ensure CRLF in >>

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 15.01.2010 16:06, Mladen Turk wrote: Although some platforms have broken(limited) default tar. Dunno if we are using very long paths that would break tar on Solaris (eg. +100 character path names) Yes, src, bin and fulldocs tarballs include longer path names then 100 chars. OTOH even the

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

On 01/15/2010 05:21 PM, Rainer Jung wrote: Also the tar produced by ant doesn't look at all like the one produced by gtar. Think the problem is that we should add all files at once during the build since it looks the tar has multiple header sections or something. I never had problems extracti

svn commit: r899737 - in /tomcat/trunk: java/org/apache/catalina/deploy/ java/org/apache/catalina/startup/ test/org/apache/ test/org/apache/catalina/deploy/ test/org/apache/catalina/startup/

Author: markt Date: Fri Jan 15 18:04:22 2010 New Revision: 899737 URL: http://svn.apache.org/viewvc?rev=899737&view=rev Log: Re-factoring. WebXml is a better fit in o.a.c.deploy Added: tomcat/trunk/java/org/apache/catalina/deploy/Constants.java (with props) tomcat/trunk/java/org/apache/

Re: JSP 2.2 & EL 2.2 implementation complete

On 15/01/2010 11:32, Mark Thomas wrote: > On 15/01/2010 10:24, jean-frederic clere wrote: >> On 01/15/2010 10:33 AM, jean-frederic clere wrote: >>> According to my tests: >>> EL : 11 failures. (They looks similar I will have a closer look later). >> >> java/javax/el/ArrayELResolver.java setValue ex

Re: JSP 2.2 & EL 2.2 implementation complete

Congratulations and thanks for all your great work on this! It's a big next step for Tomcat. -- Jason Brittain MuleSoft On Thu, Jan 14, 2010 at 2:47 PM, Mark Thomas wrote: > The subject says it all really. Still no sign of the TCK so there are > probably some bugs in

svn commit: r899769 - /tomcat/trunk/java/javax/el/ArrayELResolver.java

Author: markt Date: Fri Jan 15 19:22:12 2010 New Revision: 899769 URL: http://svn.apache.org/viewvc?rev=899769&view=rev Log: Fix TCK failure. Trying to assign an object of the wrong type to an array should throw a ClassCaseException. Modified: tomcat/trunk/java/javax/el/ArrayELResolver.java

svn commit: r899770 - /tomcat/trunk/java/javax/el/LocalStrings.properties

Author: markt Date: Fri Jan 15 19:22:42 2010 New Revision: 899770 URL: http://svn.apache.org/viewvc?rev=899770&view=rev Log: Fix TCK failure. Trying to assign an object of the wrong type to an array should throw a ClassCaseException. Modified: tomcat/trunk/java/javax/el/LocalStrings.properti

svn commit: r899783 - /tomcat/trunk/java/org/apache/el/lang/ELSupport.java

Author: markt Date: Fri Jan 15 19:37:46 2010 New Revision: 899783 URL: http://svn.apache.org/viewvc?rev=899783&view=rev Log: TCK failure. Make sure an ELException is throw if the conversion fails. Modified: tomcat/trunk/java/org/apache/el/lang/ELSupport.java Modified: tomcat/trunk/java/org/a

svn commit: r899788 - /tomcat/trunk/java/javax/el/ListELResolver.java

Author: markt Date: Fri Jan 15 19:44:14 2010 New Revision: 899788 URL: http://svn.apache.org/viewvc?rev=899788&view=rev Log: TCK failure. Invalid index should throw PNFE. Modified: tomcat/trunk/java/javax/el/ListELResolver.java Modified: tomcat/trunk/java/javax/el/ListELResolver.java URL: h

svn commit: r899792 - /tomcat/trunk/java/org/apache/el/parser/AstValue.java

Author: markt Date: Fri Jan 15 19:55:31 2010 New Revision: 899792 URL: http://svn.apache.org/viewvc?rev=899792&view=rev Log: TCK failure. Make sure we throw an ELException, not an IAE. Modified: tomcat/trunk/java/org/apache/el/parser/AstValue.java Modified: tomcat/trunk/java/org/apache/el/pa

DO NOT REPLY [Bug 48551] StringCache: Use entrySet() rather than keySet() + get()

https://issues.apache.org/bugzilla/show_bug.cgi?id=48551 --- Comment #1 from Sebb 2010-01-15 11:57:02 UTC --- Created an attachment (id=24849) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24849) Replace keySet() + get(key) with entrySet() -- Configure bugmail: https://issues.apach

svn commit: r899796 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default java/org/apache/tomcat/jdbc/pool/DataSource.java java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java java/org/apa

Author: fhanik Date: Fri Jan 15 20:02:36 2010 New Revision: 899796 URL: http://svn.apache.org/viewvc?rev=899796&view=rev Log: Make a distinction based on type=javax.sql.DataSource or type=javax.sql.XADataSource, some components, like JIRA actually do an instanceof on the object to determine what