On 15/01/2010 15:56, Mladen Turk wrote: > On 01/15/2010 04:41 PM, Mark Thomas wrote: >> On 15/01/2010 15:13, Mladen Turk wrote: >>> On 01/15/2010 03:41 PM, Rainer Jung wrote: >>>> On 14.01.2010 21:21, ma...@apache.org wrote: >>>> >>>> I'd prefer keep the package-zip with CRLF (and ensure CRLF in >>>> package-deployer-zip too). >>>> >>> >>> Just to update. >>> Since beginning of time httpd has x.x-win32-src.zip >>> We could have something like that as well instead relaying >>> on arch extension for CRLF type. >> >> Something to think about for Tomcat 7. >> > > Sure. > > Anyhow, I might just gave +1 prematurely on Rainer's > .zip == CRLF presumption. > > I see 6.0.20 has LF line endings in src.zip, so IMO > we should stick with that. Other would mean a sudden surprise > to the end users.
That is a bug we should have caught in 6.0.20 but didn't. Historically .zip has had CRLF line endings and .tar.gz LF. That worked if you built on Windows but didn't if you built on unix so when Remy switched from Windows to unix for the build stuff broke but we didn't catch all of it. There have been a series of changes recently to fix all of that and I think (once the current patches are applied) we should be in a position where you can build on Windows and unix and get the same result. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
