isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161659043
I merged the PR and tried to comment out the exclusion lines as agreed
above, but that breaks with a different error and does not allow to build.
I think that it's best to leave things
ChristopherSchultz commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161585676
My preference is for the ide-idea ant target to work for *most people*.
_Most people_ are not Tomcat developers, but people who have downloaded our
sources and are building them l
isapir merged PR #731:
URL: https://github.com/apache/tomcat/pull/731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160442520
The change we could make so that all opinions are generally satisfied are:
1. Move the exclusions from `res/ide-support/idea/compiler.xml` to
`res/ide-support/idea/tomcat.iml` commente
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160396222
> Since IDE support is
[configured](https://github.com/apache/tomcat/blob/main/build.xml#L3830) with
build.java.version, which currently is
[17](https://github.com/apache/tomcat/blob/main
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160286872
> IMO it is reasonable to expect a user that is developing on the latest
version of Tomcat, i.e. the main branch, to be using the latest Java SDK, which
will work with the Experimental featu
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2159528473
Thank you for your input on this @markt-asf - it makes sense to me, and is
consistent with my proposed solution.
> - Eclipse is configured to use the same Java version as the build (Jav
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2157847935
I'm not an Idea user so I have no strong view on this. I'd be happy with
whatever consensus the Idea users reach.
I am an Eclipse user and the approach I use there (which I think the
rmannibucau commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151570300
Assuming using uses the highest java version sounds okish but shouldnt
preview mode be enabled if the packages are not excluded, otherwise it leads to
the same output: it does not work i
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151559998
@dsoumis Tomcat 11 takes advantage of new technology. The build script
checks if the Java version is 22 and if so it compiles the Panama packages.
This is for a development environment
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151524740
@isapir My expectation was that "ant ide-intellij" should work out of the
box without requiring any adjustments.
Currently, to use an SDK version lower than 22, you must exclude
`/java/o
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2150273321
@dsoumis But now you are completely excluding
`/java/org/apache/tomcat/util/net/openssl/panama` and
`/java/org/apache/tomcat/util/openssl`? It might "work" on Java 17 but new
technology woul
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2149133573
On second thoughts, I believe ide-support should strictly follow build.xml
rules.
As build.xml
[excludes](https://github.com/apache/tomcat/blob/main/build.xml#L1014) openssl
and panama
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2145709893
Strange, I don't have those settings
But OK, I will revert the latest change. Feel
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144545354
@isapir It doesn't work for me. After pulling your patch I am getting errors
such as:
`java: java.lang.foreign.Arena is a preview API and is disabled by default.
(use --enable-preview
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144252838
@dsoumis I pushed a patch that sets the Language Level to Experimental:
https://github.com/apache/tomcat/commit/f8eecc13b53fdca998565455d3c27e9b9a6cd8dc
Can you pull it and check if
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144037801
@dsoumis I got it to work by setting the Project's `Language level` to "X -
Experimental features"
 to test this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142631865
22.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142625138
Hmm. Exactly which version of Java 22 are you using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142611198
@markt-asf
Compilation errors with Java22 (compile target is 22 as well as Java 22
being used):
>
>
/home/dsoumis/Programs/github/tomcat/java/org/apache/tomcat/util/net/openssl/pa
markt-asf commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142584248
I'm not an Idea user but I'd expect that code to compile using Java 22. Not
much help I know but those packages aren't showing any errors in Eclipse with
Java 22.
What is the error
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142552727
@dsoumis I agree that it's weird, but my concern is that it would break
other environments that work.
Let's wait for Remy/Mark/others to chime in as they are more familiar with
how thi
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142542693
@isapir It seemed weird to me, but even with Java 22 defined in Intellij the
compilation didn't succeed. Maybe something else is missing as well.
+1 For adding a comment in the output
--
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142532017
@dsoumis It won't compile if the Java version etc. are not compatible with
that code. This is not making it useless. Perhaps a better change would be to
add a comment about it in the output,
dsoumis commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142501404
Intellij won't compile the sources if those exclusions are not made, making
the "ant ide-intellij" step useless.
In case it's not the right thing to do, we should redefine the support for
isapir commented on PR #731:
URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142442782
These lines were commented out on purpose, so that they are available if you
need them but not enabled by default.
I am not sure that uncommenting them is the right thing to do. The fi
dsoumis opened a new pull request, #731:
URL: https://github.com/apache/tomcat/pull/731
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
28 matches
Mail list logo
