Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user fjodorver commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110630412
2,4,5) I use ant validate for checkstyle validation. Is it enough?
3) It looks like we need to rewrite AuthConfigFactory anyway (for example,
possible memory leaks,
Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110393102
1) I haven't reviewed the build.xml changes since I don't want to start
building this JAR until the API is correct.
2) Patch was incomplete. Applied along with addit
Github user fjodorver commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110251900
It's updated pull request.
1) Build.xml configuration in separate commit now
2) Fixed imports and formatting
3) Method refactoring has been made separately.
Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-109959429
OK. I've copied the Geronimo classes across and fixed the checkstyle and
compilation errors. I've now seen some additional issues that need to be
addressed.
1. Remo
GitHub user fjodorver opened a pull request:
https://github.com/apache/tomcat/pull/21
Add JASPIC API (JSR 196) to build process
I'd added jaspic api support in this commit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fjodorver
