Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110393102
1) I haven't reviewed the build.xml changes since I don't want to start
building this JAR until the API is correct.
2) Patch was incomplete. Applied along with additional patch for missing
elements.
3) I'm not convinced (yet) of the need for this refactoring. And it appears
to have broken the caching.
4) Patch was incomplete. Applied along with additional patch for missing
elements.
5) I'm not convinced. At least one commit contained tabs which checkstyle
would have rejected.
6) Look harder. For example. AuthConfigFactory has a number of additional
constants. I typically use javap against both Tomcat and the reference
implementation and diff the two results. I'll even go as far as re-ordering the
methods in Tomcat to remove changes from the diff. When I ran this against the
Geronimo classes there were a number of differences between Geronimo and the
reference implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
