Github user fjodorver commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110251900
It's updated pull request.
1) Build.xml configuration in separate commit now
2) Fixed imports and formatting
3) Method refactoring has been made separately. Geronimo uses OSGi stuff
to create this factory class, I see you had already fixed that.
Threre are two reasons why this refactoring required in my opinion: get rid
of extra final variable and get rid of extra indent.
4) removed version from javadoc
5) fixed checkstyle errors
6) What about JASPIC 1.1 changes in API, I don't see any changes between
this version. It looks like 1.1 changes is more like internal ones, and API
classes are still the same. Correct me if I am wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
