Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-109959429
OK. I've copied the Geronimo classes across and fixed the checkstyle and
compilation errors. I've now seen some additional issues that need to be
addressed.
1. Remove the @version lines from the Javadoc (and the whole comment if
that is the only Javadoc present)
2. Line length (80 for comments, 100 for code)
3. Use imports (particularly noticed in AuthConfigFactory)
And something I forgot in my comment on the commit, the integration into
build.xml should be a separate commit to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
