Re: JmxRemoteLifecycleListener and com.sun.security.auth.module.LdapLoginModule JMX authentification

2010-10-14 Thread Henri Gomez
> I see System.getProperty( ) there, so it is not hardcoded. It is just > a default value. passwordFile = System.getProperty( "com.sun.management.jmxremote.password.file", "jmxremote.password"); accessFile = System.ge

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Tim Whittington
No worries, I got to take a tour of the EL implementation anyway :) I was in the middle of replying to you when my loaner laptop died, so I called it a night. New laptop arrived today (after a 3 week 'incident at sea' hiatus) so should be back to full speed soon. cheers tim On Fri, Oct 15, 2010

Re: JmxRemoteLifecycleListener and com.sun.security.auth.module.LdapLoginModule JMX authentification

2010-10-14 Thread Konstantin Kolinko
2010/10/14 Henri Gomez : > We take a look in sources, > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java?view=markup > and see access and password are hardcode in source (line 160). > I see System.getProperty( ) there, so it is not hardcoded

Meetup during ApacheConNA2010

2010-10-14 Thread jean-frederic clere
Hi, We will have a meetup during the ApacheConNA2010 on Thursday 4th at 20h00. Meetups are free to attend and a opportunity to have short presentation and discussion about the new Tomcat 7 and the latest improvement done in the code. See http://wiki.apache.org/tomcat/TomcatAtApacheConNA2010 and re

svn commit: r1022695 - in /tomcat/trunk: java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/coyote/ActionCode.java webapps/docs/changelog.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 20:33:14 2010 New Revision: 1022695 URL: http://svn.apache.org/viewvc?rev=1022695&view=rev Log: Fix Javadoc warnings Modified: tomcat/trunk/java/org/apache/catalina/Context.java tomcat/trunk/java/org/apache/catalina/core/StandardContext.java tomcat/trunk

svn commit: r1022694 - /tomcat/trunk/build.properties.default

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 20:28:50 2010 New Revision: 1022694 URL: http://svn.apache.org/viewvc?rev=1022694&view=rev Log: Bump version Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.pr

svn commit: r1022637 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_4: ./ build.properties.default modules/

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 18:19:25 2010 New Revision: 1022637 URL: http://svn.apache.org/viewvc?rev=1022637&view=rev Log: Tag 7.0.4 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_4/ (props changed) - copied from r1022634, tomcat/trunk/ Removed: tomcat/tc7.0.x/tags/TOMCAT_7_0_4/modules

svn commit: r1022626 - /tomcat/trunk/webapps/docs/changelog.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 17:41:26 2010 New Revision: 1022626 URL: http://svn.apache.org/viewvc?rev=1022626&view=rev Log: Update Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/do

DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50078 --- Comment #2 from Mark Thomas 2010-10-14 13:40:24 EDT --- Thanks for the patch. I have fixed in this in trunk and that fix will be in 7.0.4 onwards. I added the ability to control the cache sizes. The patches have also been proposed for 6

svn commit: r1022624 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 17:38:54 2010 New Revision: 1022624 URL: http://svn.apache.org/viewvc?rev=1022624&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1022623 - in /tomcat/trunk: java/javax/el/BeanELResolver.java java/org/apache/el/lang/ExpressionBuilder.java webapps/docs/config/systemprops.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 17:37:20 2010 New Revision: 1022623 URL: http://svn.apache.org/viewvc?rev=1022623&view=rev Log: Enhance fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50078 Make cache sizes configurable Modified: tomcat/trunk/java/javax/el/BeanELResolver.java to

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Mark Thomas
On 14/10/2010 16:08, Mark Thomas wrote: > On 14/10/2010 09:44, Tim Whittington wrote: >> I can have a look at this. > > Tim, > > Any progress on this? I'd like to get something into Tomcat 7 before I > tag 7.0.4 later today. I'm happy to look at it if that doesn't fit your > schedule. As will so

svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 16:36:20 2010 New Revision: 1022606 URL: http://svn.apache.org/viewvc?rev=1022606&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50078 Thread safety in EL caches. Patch provided by Takayoshi Kimura Modified: tomcat/trunk/java/javax/el/Bean

DO NOT REPLY [Bug 50087] When metadata-complete="false" throw illegal JVM_CONSTANT_Class name

2010-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50087 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1022593 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 16:05:55 2010 New Revision: 1022593 URL: http://svn.apache.org/viewvc?rev=1022593&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50087 Catch ClassFormatErrors when scanning for annotations. Modified: tomcat/trunk/java/org/apache/catalina/st

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Mark Thomas
On 14/10/2010 09:44, Tim Whittington wrote: > I can have a look at this. Tim, Any progress on this? I'd like to get something into Tomcat 7 before I tag 7.0.4 later today. I'm happy to look at it if that doesn't fit your schedule. Mark > Is there a preferred way of making this configurable? >

DO NOT REPLY [Bug 49428] Fix WebDAV mounts from Windows Mini-Redirector clients

2010-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r1022570 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 15:06:48 2010 New Revision: 1022570 URL: http://svn.apache.org/viewvc?rev=1022570&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49428 Add a work-around for the known namespace issues for some Microsoft WebDAV clients. Based on the patch provid

svn commit: r1022560 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 14:53:34 2010 New Revision: 1022560 URL: http://svn.apache.org/viewvc?rev=1022560&view=rev Log: Code clean-up. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardCo

DO NOT REPLY [Bug 50066] Cannot compile recursive tag with ant if it uses a class from the webapp

2010-10-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50066 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1022557 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/jasper/compiler/TagFileProcessor.java webapps/docs/changelog.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 14:47:31 2010 New Revision: 1022557 URL: http://svn.apache.org/viewvc?rev=1022557&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50066 Compile recursive tag file if it depends on a JAR. Patch provided by Sylvain Laurent. Modified: tomcat/tc

[Tomcat Wiki] Update of "TomcatAtApacheConNA2010" by Ch ristopherSchultz

2010-10-14 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "TomcatAtApacheConNA2010" page has been changed by ChristopherSchultz. http://wiki.apache.org/tomcat/TomcatAtApacheConNA2010?action=diff&rev1=3&rev2=4 --

svn commit: r1022550 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 14:41:50 2010 New Revision: 1022550 URL: http://svn.apache.org/viewvc?rev=1022550&view=rev Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1022

JmxRemoteLifecycleListener and com.sun.security.auth.module.LdapLoginModule JMX authentification

2010-10-14 Thread Henri Gomez
Hi to all, I'm using JmxRemoteLifecycleListener since some of my servers are behind a firewall. It works great with auth/password files I tried to use JMX LDAP authentication, http://blogs.sun.com/alanb/entry/one_password_to_rule_them, but then it didn't works anymore. We take a look in sources,

svn commit: r1022478 - /tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 12:11:51 2010 New Revision: 1022478 URL: http://svn.apache.org/viewvc?rev=1022478&view=rev Log: Avoid NPE triggered when running TCK tests Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Modified: tomcat/trunk/java/org/apache/

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Remy Maucherat
On Thu, 2010-10-14 at 21:44 +1300, Tim Whittington wrote: > I can have a look at this. > Is there a preferred way of making this configurable? > Given the caches are static, it's either going to be system property, > or changing to using an instance cache retained somewhere appropriate > (at the mo

svn commit: r1022462 - /tomcat/trunk/webapps/docs/changelog.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 10:46:47 2010 New Revision: 1022462 URL: http://svn.apache.org/viewvc?rev=1022462&view=rev Log: Typo Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Mark Thomas
On 14/10/2010 09:44, Tim Whittington wrote: > I can have a look at this. > Is there a preferred way of making this configurable? > Given the caches are static, it's either going to be system property, > or changing to using an instance cache retained somewhere appropriate > (at the moment the build

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread Mark Thomas
On 14/10/2010 09:02, Konstantin Kolinko wrote: > OK. Looks that the patch is working. The snoop.jsp displays the full > original path as "Request URI" (aka request.getRequestURI()). > > Other things there > 1) Add http://svn.apache.org/viewvc?rev=1022389&view=rev +1 > 2) protected method CoyoteA

svn commit: r1022441 - in /tomcat/trunk/webapps: docs/manager-howto.xml host-manager/401.jsp host-manager/403.jsp manager/401.jsp manager/403.jsp

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 09:22:54 2010 New Revision: 1022441 URL: http://svn.apache.org/viewvc?rev=1022441&view=rev Log: Add some more info on CSRF protection for the manager and host manager applications Modified: tomcat/trunk/webapps/docs/manager-howto.xml tomcat/trunk/webapps/ho

svn commit: r1022435 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread kkolinko
Author: kkolinko Date: Thu Oct 14 09:11:44 2010 New Revision: 1022435 URL: http://svn.apache.org/viewvc?rev=1022435&view=rev Log: vote, update comment Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/S

svn commit: r1022428 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2010-10-14 Thread markt
Author: markt Date: Thu Oct 14 09:02:01 2010 New Revision: 1022428 URL: http://svn.apache.org/viewvc?rev=1022428&view=rev Log: Add some CSRF info to migration docs Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs/migra

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Tim Whittington
I can have a look at this. Is there a preferred way of making this configurable? Given the caches are static, it's either going to be system property, or changing to using an instance cache retained somewhere appropriate (at the moment the builders appear to be instantiated in a lot of places). Ju

Re: Recycling processors in Http11NioProtocol

2010-10-14 Thread Konstantin Kolinko
2010/10/14 Mark Thomas : > On 14/10/2010 01:01, Konstantin Kolinko wrote: >> Hi! >> >> Looking at the Http11NioProtocol.Http11ConnectionHandler.release(NioChannel >> socket) method in Http11NioProtocol.java,  it looks for me that like >> that method does in all other places before any call to >> "r

svn commit: r1022419 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread kkolinko
Author: kkolinko Date: Thu Oct 14 08:38:52 2010 New Revision: 1022419 URL: http://svn.apache.org/viewvc?rev=1022419&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

svn commit: r1022418 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-10-14 Thread timw
Author: timw Date: Thu Oct 14 08:38:37 2010 New Revision: 1022418 URL: http://svn.apache.org/viewvc?rev=1022418&view=rev Log: More backport votes. Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATU

svn commit: r1022415 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

2010-10-14 Thread kkolinko
Author: kkolinko Date: Thu Oct 14 08:32:59 2010 New Revision: 1022415 URL: http://svn.apache.org/viewvc?rev=1022415&view=rev Log: Improve recycling of processors in Http11NioProtocol Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Modified: tomcat/trunk/java/org/a

svn commit: r1022414 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread timw
Author: timw Date: Thu Oct 14 08:30:41 2010 New Revision: 1022414 URL: http://svn.apache.org/viewvc?rev=1022414&view=rev Log: More backport votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

Re: Recycling processors in Http11NioProtocol

2010-10-14 Thread Mark Thomas
On 14/10/2010 01:01, Konstantin Kolinko wrote: > Hi! > > Looking at the Http11NioProtocol.Http11ConnectionHandler.release(NioChannel > socket) method in Http11NioProtocol.java, it looks for me that like > that method does in all other places before any call to > "recycledProcessors.offer(result);

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread Konstantin Kolinko
2010/10/13 Mark Thomas : > On 13/10/2010 16:57, Konstantin Kolinko wrote: >> 2010/10/6  : >>> Author: markt >>> Date: Wed Oct  6 18:03:03 2010 >>> New Revision: 1005192 >>> >>> URL: http://svn.apache.org/viewvc?rev=1005192&view=rev >>> Log: >>> Proposal >>> >>> Modified: >>>    tomcat/tc6.0.x/trunk

Re: svn commit: r1022323 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

2010-10-14 Thread Mark Thomas
On 14/10/2010 00:25, kkoli...@apache.org wrote: > Author: kkolinko > Date: Wed Oct 13 23:25:47 2010 > New Revision: 1022323 > > URL: http://svn.apache.org/viewvc?rev=1022323&view=rev > Log: > Followup to r1022303 > I think that releasing the socket should be done before passing it away to a > pol

svn commit: r1022389 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2010-10-14 Thread kkolinko
Author: kkolinko Date: Thu Oct 14 07:06:01 2010 New Revision: 1022389 URL: http://svn.apache.org/viewvc?rev=1022389&view=rev Log: Followup to r946230 Do not fine-format integer values in debug output. Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomc