svn commit: r963599 - in /tomcat/trunk: java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2010-07-12 Thread kfujino
Author: kfujino Date: Tue Jul 13 04:44:25 2010 New Revision: 963599 URL: http://svn.apache.org/viewvc?rev=963599&view=rev Log: Avoid NullPointerException, when copyXML=true and META-INF/context.xml does not exist. Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java to

DO NOT REPLY [Bug 49570] The CompressionFilter example should support HTTP proxies to cache gzipped content better by sending Vary: Accept-Encoding header

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49570 --- Comment #2 from Thai Ha 2010-07-12 23:39:11 EDT --- The patch in SVN doesn't work for me because there is no method HttpServletResponse.getHeader() protected HttpServletResponse response = null; response.addHeader("Content-Encodi

Re: [taglibs] XPath support

2010-07-12 Thread Jeremy Boynes
On Jul 12, 2010, at 1:08 AM, Mark Thomas wrote: > On 12/07/2010 06:40, Jeremy Boynes wrote: >> Implementation seems to work but does not provide as much benefit as >> expected. Jasper tag pooling does not pool tags with the same attribute >> values so the select attribute is set every time causin

DO NOT REPLY [Bug 49589] Tag handlers with constant attribute values are always reinitialized

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49589 --- Comment #2 from Jeremy Boynes 2010-07-12 21:35:05 EDT --- Created an attachment (id=25758) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25758) Java source generated by Jasper ant task Relevant snippet from end // x:ou

DO NOT REPLY [Bug 49589] New: Tag handlers with constant attribute values are always reinitialized

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49589 Summary: Tag handlers with constant attribute values are always reinitialized Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: enhancemen

DO NOT REPLY [Bug 49589] Tag handlers with constant attribute values are always reinitialized

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49589 --- Comment #1 from Jeremy Boynes 2010-07-12 21:33:02 EDT --- Created an attachment (id=25757) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25757) Test JSP -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.

DO NOT REPLY [Bug 49582] Mapping a servlet to the root (/) doesn't work when accessing the root

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49582 --- Comment #4 from bozho 2010-07-12 13:36:41 EDT --- Sorry, my mistake. I tried , which is invalid according to the schema. So did it, instead. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You

Re: Tomcat 7 Maven Artifacts

2010-07-12 Thread Mark Thomas
On 04/07/2010 10:57, Mark Thomas wrote: > On 04/07/2010 11:43, Gurkan Erdogdu wrote: >> Hi folks, >> >> Our project OpenWebBeans has a dependency on Tomcat 7 artifacts. We >> are going to >> release OWB. Where is the Tomcat 7 Beta Maven artifacts? > > They haven't been uploaded yet. I should be a

DO NOT REPLY [Bug 49582] Mapping a servlet to the root (/) doesn't work when accessing the root

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49582 --- Comment #3 from Mark Thomas 2010-07-12 11:59:54 EDT --- Specifying and empty list *should* override the one in the default web.xml. If that isn't the case, that is a bug that needs fixing. If so, please open a separate bug for that and

DO NOT REPLY [Bug 49582] Mapping a servlet to the root (/) doesn't work when accessing the root

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49582 --- Comment #2 from bozho 2010-07-12 11:45:21 EDT --- I can't override the - I have to delete it from conf/web.xml, which is not good -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiv

Re: svn commit: r963273 - /tomcat/trunk/res/maven/mvn.properties.default

2010-07-12 Thread sebb
On 12 July 2010 14:02, wrote: > Author: markt > Date: Mon Jul 12 13:02:30 2010 > New Revision: 963273 > > URL: http://svn.apache.org/viewvc?rev=963273&view=rev > Log: > Prepare for the next release > > Modified: >    tomcat/trunk/res/maven/mvn.properties.default > > Modified: tomcat/trunk/res/mav

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Mark Thomas wrote: ... Before I read you latest e-mail, I was intending to tidy up the patch attached to bug 49268 and look at applying it to trunk. Right now that looks like rewarding behaviour I have no wish to encourage so I'll be spending my time on other things instead. I'll circle back to t

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 --- Comment #5 from Mark Thomas 2010-07-12 09:58:05 EDT --- I've converted the attached test case to a Tomcat 7 unit test and can reproduce the issue. Looking at it now... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs

svn commit: r963275 - in /tomcat/trunk/res/maven: mvn-pub.xml mvn.properties.default

2010-07-12 Thread markt
Author: markt Date: Mon Jul 12 13:17:01 2010 New Revision: 963275 URL: http://svn.apache.org/viewvc?rev=963275&view=rev Log: Hard code the snapshot version for 7.0. 7.0-SNAPSHOT will always point to the latest snapshot. I'll clean out the snapshot repo before I do the next update Modified: to

svn commit: r963273 - /tomcat/trunk/res/maven/mvn.properties.default

2010-07-12 Thread markt
Author: markt Date: Mon Jul 12 13:02:30 2010 New Revision: 963273 URL: http://svn.apache.org/viewvc?rev=963273&view=rev Log: Prepare for the next release Modified: tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn.apache.or

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Mark Thomas
On 12/07/2010 11:28, Marc Guillemot wrote: > Mark Thomas wrote: >> Taking a confrontational approach isn't going to win you any friends and >> isn't going to help you achieve the changes you want. > > I know, but it is a desperate step. I have tried following approaches: > - provide patches ready

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Konstantin Kolinko
2010/7/12 Marc Guillemot : > >> 2. There is NO consensus on @Version format. >> (...) > > if there is no consensus, then all commits concerning this should never have > occurred ;-) The consensus is that $Date$ is broken and must not be used. Nothing else. > > Why a 80 characters limit? Is this a

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Mark Thomas wrote: On 12/07/2010 09:39, Marc Guillemot wrote: I find interesting how some (Mark, you) seem to fight against introducing checkstyle and precisely defining what should be the rules although you make exactly this kind of changes. Then you completely mis-understand my position. r

DO NOT REPLY [Bug 49585] jsvc.tar.gz no longer in $CATALINA_HOME/bin

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49585 --- Comment #1 from Mark Thomas 2010-07-12 05:39:21 EDT --- It is in commons-daemon-native.tar.gz Yep, the docs need to be updated -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 --- Comment #4 from Pieter Libin 2010-07-12 05:26:27 EDT --- (In reply to comment #3) > Because at first glance the test case appears to be identical to the previous > bug you reported and there is no reference in it to doPost which you ref

DO NOT REPLY [Bug 49585] New: jsvc.tar.gz no longer in $CATALINA_HOME/bin

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49585 Summary: jsvc.tar.gz no longer in $CATALINA_HOME/bin Product: Tomcat 5 Version: 5.5.30 Platform: All OS/Version: All Status: NEW Severity: regression Priority

DO NOT REPLY [Bug 49584] New: Borrowers Getting Stuck

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49584 Summary: Borrowers Getting Stuck Product: Tomcat 7 Version: unspecified Platform: PC Status: NEW Severity: normal Priority: P2 Component: Modules: jdbc-pool

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Mark Thomas
On 12/07/2010 09:39, Marc Guillemot wrote: > I find interesting how some (Mark, you) seem to fight against > introducing checkstyle and precisely defining what should be the rules > although you make exactly this kind of changes. Then you completely mis-understand my position. My default preferen

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Hi Konstantin, 1. What is TabSpacePolicy? It is not listed at: http://checkstyle.sourceforge.net/availablechecks.html There is FileTabCharacter though. http://checkstyle.sourceforge.net/config_whitespace.html#FileTabCharacter of course this is the FileTabCharacter check. Interesting to see wh

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 --- Comment #3 from Mark Thomas 2010-07-12 04:40:25 EDT --- Because at first glance the test case appears to be identical to the previous bug you reported and there is no reference in it to doPost which you refer to in both the title and th

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 --- Comment #2 from Pieter Libin 2010-07-12 04:23:47 EDT --- (In reply to comment #1) > Looks like you attached the wrong test case to this report. Dear Mark, why do you think this is the wrong test case? Are you not able to reproduce the

Re: [taglibs] XPath support

2010-07-12 Thread Mark Thomas
On 12/07/2010 06:40, Jeremy Boynes wrote: > Implementation seems to work but does not provide as much benefit as > expected. Jasper tag pooling does not pool tags with the same attribute > values so the select attribute is set every time causing recompilation. The > time taken to iterate 1000 t