Hi Konstantin,
1. What is TabSpacePolicy? It is not listed at:
http://checkstyle.sourceforge.net/availablechecks.html
There is FileTabCharacter though.
http://checkstyle.sourceforge.net/config_whitespace.html#FileTabCharacter
of course this is the FileTabCharacter check. Interesting to see when
the "tab space policy" becomes the TabSpacePolicy check ;-)
2. There is NO consensus on @Version format.
Last time when it was discussed, about a year ago,
there was slight agreement to get rid of those tags at all.
http://marc.info/?t=124692531300003&r=1&w=2
Though, when I actually was performing the change recently I went for
a more safe route of just replacing $Date$ with $Id$.
One caveat with $Id$ that I noted in the last several months:
when filename is long, "@version $Id$" can occupy more than 80
characters and is wrapped when reformatting the file in IDE, thus
breaking this keyword. In several such cases I replaced $Id$ with
$Revision$.
if there is no consensus, then all commits concerning this should never
have occurred ;-)
I find interesting how some (Mark, you) seem to fight against
introducing checkstyle and precisely defining what should be the rules
although you make exactly this kind of changes.
Why a 80 characters limit? Is this a recognized style rule for Tomcat?
3. From message in "Re: r960104" thread:
http://markmail.org/message/rkznrp2cnfkd4eob:
FileTabCharacter -> currently 146 failures
In what packages are those files?
please apply the patch and look at the report. The information will be
fare better than what I can provide in this email.
Fixing them can be discussed and done first,
before enabling any checkstyle nags in the project.
for me it doesn't make sense. If you agree that tabs should not be used,
then the build should ensure that. If the build doesn't ensure that,
there is no guaranty that tabs won't be introduced again in the future
and therefore fixing them now is nearly lost time.
4. Is it possible to exclude some packages from checkstyle checks?
E.g., org.apache.tomcat.util.bcel ?
the ant task uses a fileset elements that can contain exclusion
http://checkstyle.sourceforge.net/anttask.html
5. Is there experience whether checkstyle checks run fast, or there
are noticeable delays?
The "Re: r960104" thread was about preventing commits that have wrong
whitespace. It probably means that checkstyle is run automatically
by IDE, or by the buildbot. Do others have positive experience with
such configurations?
checkstyle is fast (in fact it doesn't really matter for the build)
Plugins for the IDE are really nice as they highlight the problems and
need only to run on modified files.
Based on the above
[x] 0 : More discussion needed
I am +1 if someone else wants to add a separate "checkstyle" target to
build.xml.
it is the case of the proposed patch
I do not mind against checks that already succeed for the existing
code. Though if they always succeed they are not really useful.
wrong. Let's take IllegalImport as an example. It checks that some
imports (default to sun.* packages) are not used. It currently pass but
one error from one committer is enough to make them fail (and don't say
that it can't occur ;-)).
I'm impressed by the resistance of Tomcat committers against changes
that aim to improve the code quality. The current discussion remembers
me this patch:
"Run the unit tests as part of the build!!!"
(https://issues.apache.org/bugzilla/show_bug.cgi?id=47124)
My feeling is that you really have to wake up. We are in 2010! Tomcat's
large user base is surely enough to give you work until you retire but
if you have more ambitious goals, you surely should give a look at other
projects, like Jetty. In this case there is no discussion to determine
who is the winner concerning measures used to ensure code quality! :-(
Cheers,
Marc.
--
Blog: http://mguillem.wordpress.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
