+1 from me too.
I'm still not sold on bringing all history from JIRA into GH but that's what
Lucene did, so perhaps just doing the same (+ lessons learnt) is the smoothest
path.
Solr would in addition need to find a new process for security issues. But we
could just fall back on plain security@
All the blockers are now resolved and the latest build passes.
https://ci-builds.apache.org/job/Solr/job/Solr-check-9.1/209/
I'll proceed with the RC1 building shortly. Thanks to everyone!
On Fri, Oct 14, 2022 at 2:56 PM Jan Høydahl wrote:
> Created https://issues.apache.org/jira/browse/SOLR-164
Hi all,
I started, and Kevin pushed to completion
https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify our
assert logic.
It touches 330 files, all various tests…. I think it’s a great enhancement,
but before clicking merge, wanted to give a chance for someone to speak up o
I agree that these changes are good for the codebase. But, I am very much
disturbed by the changeset size. It will make backporting, working on
existing changes etc. a massive pain. I don't see the benefit enough to
outweigh the massive loss in productivity. Solr needs improvement in
efficiency, pe
Changeset size is ~300 files - much smaller than the thousands of files
touched by spotless.
The tangible benefits being that error messages are no longer "assertion
failed" but instead say what was different in the case of arrays the two
arrays or in the case of some equals the two values. This i
I'm trying to build the RC1 of 9.1 release.
Here are the errors I ran into:
* Where:
Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
* What went wrong:
Execution failed for task ':rat'.
> Detected license header issues (skip with -Pvalidation.rat.failOnError=
false):
Unknown license:
`out/` is a weird directory... I would remove the out directory and go from
there? It looks like maybe there are some old files under the git checkout?
I personally don't have an out directory in my Solr checkout.
Kevin Risden
On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
ichattopadhy
I see you also already committed the rat change to disable the check. The
license check from rat is very important to ASF releases so it shouldn't
just be removed.
Kevin Risden
On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden wrote:
> `out/` is a weird directory... I would remove the out director
I just did that in 9.1 branch (not planning to branch_9x), to see if things
work properly.
Thanks for the pointer on out/ directory. I'll try another fresh checkout
and try again.
On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden wrote:
> I see you also already committed the rat change to disable the
Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to
disable rat.
On Tue, Oct 18, 2022 at 9:41 PM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:
> I just did that in 9.1 branch (not planning to branch_9x), to see if
> things work properly.
> Thanks for the pointer on out
+1
If it gets merged both to main and branch_9x it will not cause backport pain at
all for 95% of the PRs.
Kudos for caring for the "boring" parts of open source!
Jan
> 18. okt. 2022 kl. 15:35 skrev Eric Pugh :
>
> Hi all,
>
> I started, and Kevin pushed to completion
> https://issues.apache
Agreed. I think this is good stuff, there are a lot of bad asserts in our
tests, and this will only help make debugging easier.
I'm going to try my best to get through the PR over the next few days.
- Houston
On Tue, Oct 18, 2022 at 12:50 PM Jan Høydahl wrote:
> +1
>
> If it gets merged both t
TIP: If you follow the Release Wizard tediously (and you always should), all RM
building will happen from a clean checkout under ~/.solr-releases/9.1.0/solr
Jan
> 18. okt. 2022 kl. 18:34 skrev Ishan Chattopadhyaya
> :
>
> Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to
> d
Right, indeed. I was testing out a recently failed test there (
https://issues.apache.org/jira/browse/SOLR-16425), in the wrong terminal
window, which left the release repo's checkout unclean.
On Tue, Oct 18, 2022 at 10:28 PM Jan Høydahl wrote:
> TIP: If you follow the Release Wizard tediously (
Ah, my ~/.solr-releases dir was symlinked to my dev repo, which caused this
:-D
ishan@x1extreme ~/code/solr (branch_9_1) $ ls ~/.solr-releases/9.1.0/ -la
total 16
drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:27 .
drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:10 ..
drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:2
15 matches
Mail list logo
