Agreed. I think this is good stuff, there are a lot of bad asserts in our tests, and this will only help make debugging easier.
I'm going to try my best to get through the PR over the next few days. - Houston On Tue, Oct 18, 2022 at 12:50 PM Jan Høydahl <jan....@cominvent.com> wrote: > +1 > > If it gets merged both to main and branch_9x it will not cause backport > pain at all for 95% of the PRs. > Kudos for caring for the "boring" parts of open source! > > Jan > > > 18. okt. 2022 kl. 15:35 skrev Eric Pugh <ep...@opensourceconnections.com > >: > > > > Hi all, > > > > I started, and Kevin pushed to completion > https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify > our assert logic. > > > > It touches 330 files, all various tests…. I think it’s a great > enhancement, but before clicking merge, wanted to give a chance for someone > to speak up on why these stylistic changes should be reverted! > > > > I’d like to get this merged this week. > > > > Eric > > > > _______________________ > > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com < > http://www.opensourceconnections.com/> | My Free/Busy < > http://tinyurl.com/eric-cal> > > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> > > > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > For additional commands, e-mail: dev-h...@solr.apache.org > >
