I agree that these changes are good for the codebase. But, I am very much disturbed by the changeset size. It will make backporting, working on existing changes etc. a massive pain. I don't see the benefit enough to outweigh the massive loss in productivity. Solr needs improvement in efficiency, performance, ease of use etc. most urgently. Stylistic changes like these don't contribute much there, rather hinder ongoing efforts in the right direction.
I'm -0 on this merge. On Tue, Oct 18, 2022 at 7:06 PM Eric Pugh <ep...@opensourceconnections.com> wrote: > Hi all, > > I started, and Kevin pushed to completion > https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify > our assert logic. > > It touches 330 files, all various tests…. I think it’s a great > enhancement, but before clicking merge, wanted to give a chance for someone > to speak up on why these stylistic changes should be reverted! > > I’d like to get this merged this week. > > Eric > > _______________________ > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com < > http://www.opensourceconnections.com/> | My Free/Busy < > http://tinyurl.com/eric-cal> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> > > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. > >
