Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to disable rat.
On Tue, Oct 18, 2022 at 9:41 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > I just did that in 9.1 branch (not planning to branch_9x), to see if > things work properly. > Thanks for the pointer on out/ directory. I'll try another fresh checkout > and try again. > > On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden <kris...@apache.org> wrote: > >> I see you also already committed the rat change to disable the check. The >> license check from rat is very important to ASF releases so it shouldn't >> just be removed. >> >> Kevin Risden >> >> >> On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden <kris...@apache.org> wrote: >> >> > `out/` is a weird directory... I would remove the out directory and go >> > from there? It looks like maybe there are some old files under the git >> > checkout? >> > >> > I personally don't have an out directory in my Solr checkout. >> > >> > Kevin Risden >> > >> > >> > On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya < >> > ichattopadhy...@gmail.com> wrote: >> > >> >> I'm trying to build the RC1 of 9.1 release. >> >> Here are the errors I ran into: >> >> * Where: >> >> Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78 >> >> >> >> * What went wrong: >> >> Execution failed for task ':rat'. >> >> > Detected license header issues (skip with >> -Pvalidation.rat.failOnError= >> >> false): >> >> Unknown license: >> >> >> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml >> >> Unknown license: >> >> /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml >> >> Unknown license: >> >> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml >> >> Unknown license: >> >> /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml >> >> Unknown license: >> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema- >> >> snippet-type.xml >> >> Unknown license: >> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema- >> >> snippet-field.xml >> >> Unknown license: >> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig- >> >> snippet-processor.xml >> >> >> >> >> >> https://termbin.com/rjui >> >> >> >> I fixed them locally (to add ASF license in the XML files), but then >> ran >> >> into various *.txt files that have tabs, not spaces. Clearly, these are >> >> all >> >> false alarms, and all the files here are last edited years ago. >> >> >> >> Should we add -Pvalidation.sourcePatterns.failOnError=false to the >> release >> >> script and move on? >> >> >> > >> >
