Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/14
Alright, let's move further discussion to JIRA
([LOG4NET-572](https://issues.apache.org/jira/browse/LOG4NET-572),
[LOG4NET-567](https://issues.apache.org/jira/browse/LOG4NET-567)). I
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/14
I'm pleased to say that I was able to merge large parts of your work into
the branch `feature/netstandard-2.0` and the build passed. Unfortunately the
tests are currently not run beca
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133930064
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133929485
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133929178
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133928541
--- Diff: Jenkinsfile ---
@@ -61,21 +61,14 @@ pipeline {
// run docker container
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133928219
--- Diff: src/Appender/AppenderSkeleton.cs ---
@@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133924628
--- Diff: src/Appender/FileAppender.cs ---
@@ -620,22 +620,23 @@ public class MinimalLock : LockingModelBase
private string
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133924926
--- Diff: src/Appender/FileAppender.cs ---
@@ -620,22 +620,23 @@ public class MinimalLock : LockingModelBase
private string
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133924767
--- Diff: src/Appender/FileAppender.cs ---
@@ -695,7 +704,10 @@ public override void ReleaseLock
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133924709
--- Diff: src/Appender/FileAppender.cs ---
@@ -671,7 +672,15 @@ public override Stream AcquireLock
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133924397
--- Diff: src/Appender/FileAppender.cs ---
@@ -620,22 +620,23 @@ public class MinimalLock : LockingModelBase
private string
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133923978
--- Diff: src/Appender/FileAppender.cs ---
@@ -695,7 +704,10 @@ public override void ReleaseLock
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/15#discussion_r133923889
--- Diff: src/Appender/FileAppender.cs ---
@@ -671,7 +672,15 @@ public override Stream AcquireLock
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133704161
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-http://schemas.microsoft.
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133700988
--- Diff: Jenkinsfile ---
@@ -61,21 +61,14 @@ pipeline {
// run docker container
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133703322
--- Diff: src/Util/PatternStringConverters/UserNamePatternConverter.cs ---
@@ -69,6 +69,12 @@ override protected void Convert(TextWriter writer
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133703847
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133703032
--- Diff: src/CompatibilityExtensions.cs ---
@@ -0,0 +1,53 @@
+#region Apache License
+//
+// Licensed to the Apache Software
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133701487
--- Diff: log4net.build ---
@@ -1748,48 +1748,64 @@ limitations under the License
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133702415
--- Diff: src/Appender/AppenderSkeleton.cs ---
@@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r130217035
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -240,13 +252,52 @@ public void RollingCombinedWithPreserveExtension
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r130216572
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -240,13 +252,52 @@ public void RollingCombinedWithPreserveExtension
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r130216751
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -155,7 +157,17 @@ private static void VerifyFileCount(int iExpectedCount
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r130215532
--- Diff: src/Appender/RollingFileAppender.cs ---
@@ -1488,7 +1488,8 @@ protected void RollOverRenameFiles(string
baseFileName
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r130216707
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -103,7 +104,8 @@ private static void ResetAndDeleteTestFiles
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r130216842
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -240,13 +252,52 @@ public void RollingCombinedWithPreserveExtension
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/13
Good catch and sorry for the juggling. Fixed in develop now.
Looks like the indentations were not only mixed tabs and spaces but there
existed space indentations that were both 4
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/13
It was fixed in develop and then merged into the feature branches. Please
base your changes on develop. It is up to you if you woukd like to create a
feature branch for your changes. It
Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/13#discussion_r129869327
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -239,13 +251,50 @@ public void RollingCombinedWithPreserveExtension
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/12
Merged with develop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/12
This is a test whether builds.a.o picks up this pull request
Ideally, this build should show up at
https://builds.apache.org/blue/organizations/jenkins/logging-log4net/pr
You can merge
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/6
This patch provides the same functionality as #9 does. Since this patch
affects the current behavior and I have a bad feeling about changing the
behavior of the rolling file appender, I see
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/10
The patch basically wraps the invocation to WindowsIdentity.GetCurrent()
into a provider that refreshes the identity in the background once every 15
seconds. Please discuss!
---
If your
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/10
Improve the performance of looking up the windows identity
This reopens the old pull request 45.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/9
With respect to #6 this patch is cleaner. Since this affects the current
behavior and I have a bad feeling about changing the behavior of the rolling
file appender, I see a unit test as a
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/9
Allow for dates that aren't necessarily in the -MM-dd format.
This reopens the old pull request 43. Please note that the old pull request
29 (reopened as #6) provides the
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/8
This is again a rather large patch that requires an ICLA from the original
author Harry Martyrossian.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/8
Implemented changes for the Util/AppenderAttachedImpl.cs class for calling
log4net appenders in parallel using .NET Task Parallel Library
This reopens the old pull request 40 and provides a
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/7
We need an ICLA from the author Peter Jas since this is a rather large
change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/7
Add log4net asp.net extension
This reopens the old pull request 32 and provides a place for discussion.
It would be nice to have some feedback from the author of the original patch.
You
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/6
Try and trap a date when looking for the next backup number.
This reopens the old pull request 29 and provides a place for discussion.
Please note that the old pull request 43 provides the
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/5
The patches available as attachments on issue LOG4NET-429 look more
sensible to me. This patch simply removes this feature and thus breaks current
behavior. In my eyes this is not a great
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/5
There is an issue for this too (LOG4NET-429).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/5
Removed the event properties in CreateCompositeProperties
In order to increase the speed up operations in almost x10 times of using
properties in the output when UserName and Identity
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/4
This patch can be merged into master. It lacks new test cases and therefore
we should do so iff it is a stable fix and does not break existing tests.
---
If your project is set up for it
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/4
Only look at relevant log files for backup size at initialization time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/logging
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/3
This is actually a great idea. With a few test cases this could make a
great improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/3
Support for types of non-parameterless constructors in XmlConfigurator.
The constructor parameters are taken from the corresponding values of
the child nodes.
You can add for
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/2
I wonder whether we would like to have this windows specific appender in
core. Do we need a separate assembly for appenders that are second class
citizens?
---
If your project is set up
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/2
First version of ProcMonAppender
Reopening this pull request, please discuss.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache
Github user dpsenner commented on the issue:
https://github.com/apache/logging-log4net/pull/1
After reading this patch I think we should provide a base class that has a
generic way to have customized mail messages. All the customizations (i.e. for
this code the log level to color
GitHub user dpsenner opened a pull request:
https://github.com/apache/logging-log4net/pull/1
add ColoredSmtpAppender. allow user send colorful log email.
Opening this branch as a pull request to give us a place for discussion.
You can merge this pull request into a Git repository
53 matches
Mail list logo
