Github user dpsenner commented on a diff in the pull request:

    https://github.com/apache/logging-log4net/pull/14#discussion_r133703322
  
    --- Diff: src/Util/PatternStringConverters/UserNamePatternConverter.cs ---
    @@ -69,6 +69,12 @@ override protected void Convert(TextWriter writer, 
object state)
     
                                writer.Write( SystemInfo.NotAvailableText );
                        }
    +#if NETSTANDARD2_0
    +                   catch(PlatformNotSupportedException)
    +                   {
    +                           writer.Write("WindowsIdentity is not available 
on this platform");
    --- End diff --
    
    Could this make use of `nameof(WindowsIdentity)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to