[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

[dpsenner]

Github user dpsenner commented on a diff in the pull request:

    https://github.com/apache/logging-log4net/pull/14#discussion_r133928541
  
    --- Diff: Jenkinsfile ---
    @@ -61,21 +61,14 @@ pipeline {
                                        // run docker container
                                        builder.inside {
                                                // compile
    -                                           sh "nant compile-netstandard"
    +                                           sh "dotnet build 
src/log4net.csproj -c Release -f netstandard1.3 -o ../bin/netstandard1.3"
    +                                           sh "dotnet build 
src/log4net.csproj -c Release -f netstandard2.0 -o ../bin/netstandard2.0"
    --- End diff --
    
    I just now realized why you had to change this. The docker microsoft/dotnet 
is now on debian stretch which does no longer include nant 
(https://packages.debian.org/search?suite=all&section=all&arch=any&searchon=names&keywords=nant).
 We probably should move away from nant entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---