Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133702415
--- Diff: src/Appender/AppenderSkeleton.cs ---
@@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent)
{
ErrorHandler.Error("Failed in
DoAppend", ex);
}
-#if !MONO && !NET_2_0 && !NETSTANDARD1_3
+#if !(MONO || NET_2_0 || NETSTANDARD1_3 || NETSTANDARD2_0)
--- End diff --
I see a naming scheme difference here. According to the conventions so far,
a underscore has been there before the version of a target. Thus
`NETSTANDARD1_3` should probably read `NETSTANDARD_1_3` and `NETSTANDARD2_0`
should become `NETSTANDARD_2_0`. Of course this has slipped through when
`netstandard-1.3` support was added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
