Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/491#discussion_r114672970
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionResultSender.java
---
@@ -214,16 +214,15 @@ public void
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/490#discussion_r114673640
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinator.java
---
@@ -46,22 +48,30
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/483#discussion_r114674582
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorTestBase.java
---
@@ -289,6 +289,13 @@ public void run() throws Exception
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/475#discussion_r114674893
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
---
@@ -253,12 +263,15 @@ protected void
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/475#discussion_r114674811
--- Diff: geode-core/src/main/java/org/apache/geode/cache/client/Pool.java
---
@@ -193,13 +193,23 @@
/**
* Returns an unmodifiable list of
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/467
I think you should the log statements to use Log4j2 loggers instead of
changing them to use a different getLogWriter() API. This work was started in
2014 and was never finished.
To convert
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/571#discussion_r121188448
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
---
@@ -478,9 +478,8 @@ private InternalLocator(int port
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/571#discussion_r121188665
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/logging/LogWriterFactory.java
---
@@ -87,19 +87,19 @@ public static InternalLogWriter
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/565#discussion_r121195985
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
---
@@ -2002,7 +2002,8 @@ void populateListForEquiJoin
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/560#discussion_r121197448
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
---
@@ -736,7 +736,7 @@ public Result exportData
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/557#discussion_r121198226
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java
---
@@ -0,0 +1,51
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/573
I just pulled this in to feature/GEODE-2558. I changed the git commit
message to:
GEODE-2622: Fix GMSMembershipManagerJUnitTest use of Mockito 2.7.11
- Fix 4 test failures in
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/573
Your PR is safely committed to feature/GEODE-2558. I also rebased
feature/GEODE-2558 on develop. Normally asfgit (an Apache bot) would close this
PR but it won't do that until I merge feature/
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/601
GEODE-3117: fix Gateway authentication with legacy security
* add GatewayLegacyAuthenticationRegressionTest to reproduce bug
* fix authentication of Gateway sender/receiver with
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/529
@davinash please rebase on develop to fix the new conflicts and I'll merge
to develop. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/601
@pdxrunner thanks for finding the commented out code! I fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/623
GEODE-3156: add AcceptanceTest gradle target and junit category
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/635#discussion_r127515789
--- Diff: geode-docs/configuring/running/running_the_locator.html.md.erb ---
@@ -35,7 +35,7 @@ You can run the locator standalone or embedded within
another
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/635#discussion_r127515650
--- Diff:
geode-docs/configuring/running/running_the_cacheserver.html.md.erb ---
@@ -31,7 +31,7 @@ The Geode server is used primarily for hosting long-lived
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/598#discussion_r128354400
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
---
@@ -14,6 +14,8
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/598#discussion_r128354422
--- Diff:
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
---
@@ -26,6 +26,8 @@
import java.util.function.Predicate
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/623
Pulling this PR in now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kirklund closed the pull request at:
https://github.com/apache/geode/pull/623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/450
I'll wrap up this PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user kirklund closed the pull request at:
https://github.com/apache/geode/pull/450
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129693128
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,54 @@ public void
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r129693040
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
@@ -173,36 +157,54 @@ public void
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129714136
--- Diff:
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
---
@@ -102,35 +107,52 @@ protected ProcessBuilder
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129712729
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java
---
@@ -0,0 +1,396
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129712972
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java
---
@@ -0,0 +1,396
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129713345
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java
---
@@ -0,0 +1,396
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129712861
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java
---
@@ -0,0 +1,396
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129713502
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java
---
@@ -0,0 +1,396
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/467
@davinash Sorry to take so long to respond! For the security logger you can
use this:
```java
private static Logger securityLogger =
LogService.getLogger(LogService.SECURITY_LOGGER_NAME
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/672#discussion_r130944162
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java
---
@@ -0,0 +1,311 @@
+/*
+ * Licensed
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/697
GEODE-3407: fix deadlock between JMX and Reconnect
Change InternalClientMembership to not synchronize on CacheFactory
by accepting Cache parameter from CacheServerBridge.
New regression
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/699
GEODE-3413: overhaul launcher and process classes and tests
This is primarily an overall of all ServerLauncher and LocatorLauncher
tests and org.apache.geode.internal.process tests. The main
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132299177
--- Diff:
geode-core/src/main/java/org/apache/geode/config/internal/ClusterConfigurationNotAvailableException.java
---
@@ -0,0 +1,29
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132305098
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,234
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132307026
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132308040
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132308711
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java
---
@@ -47,26 +50,21 @@
@Before
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132312206
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
---
@@ -0,0 +1,243
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321846
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321803
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321779
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321751
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321738
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132322055
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132323674
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132324550
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132324608
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132326281
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132532641
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
---
@@ -0,0 +1,243
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132532612
--- Diff:
geode-core/src/main/java/org/apache/geode/config/internal/ClusterConfigurationNotAvailableException.java
---
@@ -0,0 +1,29
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132532669
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,234
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132533643
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
---
@@ -31,7 +31,7 @@
import
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132535229
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -157,7 +162,7 @@ protected static Properties
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132541592
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -502,7 +507,7 @@ protected static Integer identifyPid
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132541795
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java
---
@@ -228,9 +230,9 @@ private void disconnect
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132541957
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1848,8 +1884,7 @@ public LocatorLauncher build
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542008
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderWindowsTest.java
---
@@ -0,0 +1,97
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542016
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,179
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542063
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542106
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542157
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542169
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542242
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1075,8 +1082,7 @@ private LocatorState stopWithWorkingDirectory
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542091
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542146
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542204
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542184
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/699
These tests have also now been overhauled or rewritten:
* LauncherMemberMXBeanIntegrationTest
* ServerLauncherWaitOnServerMultiThreadedTest
* ServerLauncherWithProviderIntegrationTest
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132545900
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java ---
@@ -810,9 +819,6 @@ public void setStatus(final String statusMessage
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132592102
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,182
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132592382
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalIntegrationTest.java
---
@@ -14,745 +14,270 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132598795
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -795,25 +785,25 @@ protected String toString(final Date
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132598899
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -104,6 +109,8 @@
helpMap.put("bind-ad
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599242
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1352,11 +1328,13 @@ protected void parseCommand(final String
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599333
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1781,8 +1782,8 @@ protected void validate() {
* @see
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599627
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/AttachProcessUtils.java
---
@@ -14,21 +14,28 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599768
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java
---
@@ -112,56 +119,43 @@ private void stop(final File
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599897
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java
---
@@ -96,33 +117,55 @@ void close() {
* @throws
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132600143
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java
---
@@ -96,33 +117,55 @@ void close() {
* @throws
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/699
Merged this PR to develop. Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kirklund closed the pull request at:
https://github.com/apache/geode/pull/699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/711
GEODE-3436: revert all commands refactorings
Revert these commits to return precheckin to GREEN:
commit d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51
Author: YehEmily
Date: Mon Aug 7
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/613
I think this sort of change should be proposed and discussed on the dev
list. This is effectively adding new User APIs and that requires more
discussion.
---
If your project is set up for it, you
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/720#discussion_r134003148
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
---
@@ -3091,4 +3068,22 @@ public void
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/720#discussion_r134004793
--- Diff:
geode-core/src/main/java/org/apache/geode/management/FunctionStatsMXBean.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/720#discussion_r134003423
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -3138,7 +3138,7 @@ public Pool determineDefaultPool
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/720#discussion_r134003701
--- Diff:
geode-core/src/main/java/org/apache/geode/management/FunctionStatsMXBean.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/724
GEODE-3469: prevent zero pid from AvailablePid for tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirklund/geode
GEODE-3469
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/724#discussion_r134077082
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePid.java
---
@@ -30,37 +30,88 @@
*/
public class AvailablePid
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/727
GEODE-3430: fix varargs usage
Also, general cleanup of ConnectCommandTest.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirklund/geode GEODE
Github user kirklund closed the pull request at:
https://github.com/apache/geode/pull/724
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/724
Already merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/729
GEODE-3461: increase test timeouts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirklund/geode GEODE-3461-increase-timeouts
Alternatively
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/729#discussion_r134352194
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
@@ -149,7 +147,7 @@ protected void
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/729
This PR should also fix GEODE-3505.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1 - 100 of 158 matches
Mail list logo
