Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/729#discussion_r134352194
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
@@ -149,7 +147,7 @@ protected void
givenStartedProcessWithStreamListeners(final Class<?> mainClass)
}
protected ConditionFactory await() {
- return
Awaitility.await().atMost(WAIT_FOR_READER_IS_RUNNING_TIMEOUT_MILLIS,
MILLISECONDS);
+ return Awaitility.await().atMost(2, MINUTES);
--- End diff --
WAIT_FOR_READER_IS_RUNNING_TIMEOUT_MILLIS was poorly named and is now
deleted --
replaced by (2, MINUTES) hardcoded into the await() method that various
tests use.
READER_JOIN_TIMEOUT_MILLIS still exists and is used only by the two tests
that perform Thread.join style calls on the Readers.
Both timeouts are now 2 minutes which should be more than enough even if
the test hits a GC pause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
