Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599242
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1352,11 +1328,13 @@ protected void parseCommand(final String... args) {
* @see
org.apache.geode.distributed.LocatorLauncher.Command#isCommand(String)
* @see #parseArguments(String...)
*/
- protected void parseMemberName(final String[] args) {
- for (String arg : args) {
- if (!(arg.startsWith(OPTION_PREFIX) || Command.isCommand(arg))) {
- setMemberName(arg);
- break;
+ protected void parseMemberName(final String... args) {
+ if (args != null) {
+ for (String arg : args) {
+ if (!(arg.startsWith(OPTION_PREFIX) || Command.isCommand(arg))) {
--- End diff --
We need to refactor these classes a lot more. I only copied line 1332 from
ServerLauncher which then indented the rest of the lines. I made sure that
everything was more consistent. LocatorLauncher threw NPE if args was null but
ServerLauncher was ok with null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
