GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/699
GEODE-3413: overhaul launcher and process classes and tests
This is primarily an overall of all ServerLauncher and LocatorLauncher
tests and org.apache.geode.internal.process tests. The main classes in
org.apachage.geode.internal.process package are also cleaned up.
In addition, several bugs involving these classes and tests are fixed.
Here is the complete list of tickets that are resolved in this overhaul:
* GEODE-1229: LocatorLauncherRemoteJUnitTest.testStartOverwritesStalePidFile
* GEODE-2791:
LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero
fails intermittently with AssertionError
* GEODE-1308: CI failure:
LocatorLauncherTest.testSetBindAddressToNonLocalHost
* GEODE-1309: CI failure:
ServerLauncherTest.testSetServerBindAddressToNonLocalHost
* GEODE-3193: locator pid file is removed even if there was a problem while
shutting down
* GEODE-3413: Overhaul launcher tests and process tests
* GEODE-3414: Cleanup org.apache.geode.internal.process package
Note I moved all useful tests from LocatorLauncherAssemblyIntegrationTest
into the other launcher tests in geode-core.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirklund/geode GEODE-3183-3413-3414
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/699.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #699
----
commit 69cdd5cbc7423577b0a5fcde5f8da486437fa387
Author: Kirk Lund <[email protected]>
Date: 2017-07-10T19:30:09Z
GEODE-3413: overhaul launcher and process classes and tests
This is primarily an overall of all ServerLauncher and LocatorLauncher
tests and org.apache.geode.internal.process tests. The main classes in
org.apachage.geode.internal.process package are also cleaned up.
In addition, several bugs involving these classes and tests are fixed.
Here is the complete list of tickets that are resolved in this overhaul:
* GEODE-1229: LocatorLauncherRemoteJUnitTest.testStartOverwritesStalePidFile
* GEODE-2791:
LocatorLauncherAssemblyIntegrationTest.testLocatorStopsWhenJmxPortIsNonZero
fails intermittently with AssertionError
* GEODE-1308: CI failure:
LocatorLauncherTest.testSetBindAddressToNonLocalHost
* GEODE-1309: CI failure:
ServerLauncherTest.testSetServerBindAddressToNonLocalHost
* GEODE-3193: locator pid file is removed even if there was a problem while
shutting down
* GEODE-3413: Overhaul launcher tests and process tests
* GEODE-3414: Cleanup org.apache.geode.internal.process package
Note I moved all useful tests from LocatorLauncherAssemblyIntegrationTest
into the other launcher tests in geode-core.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
