Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/440
Looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/488
This looks good. Pull it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/464
This change looks good. I noticed travis CI failed with the following. But
it looks like isExpiration was removed in some other commit so it is not clear
to me why this one got the
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/443
I think this pull request should be closed. GEODE-1887 will be updated with
a plan for doing it without breaking backwards compatibility.
---
If your project is set up for it, you can
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/495
The xsd you are looking for is:
geode-core/build/resources/main/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
However you should not modify this one since it has
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/488#discussion_r115331983
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java ---
@@ -1702,6 +1702,8 @@ public Set entrySet(boolean
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/488#discussion_r115331671
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/QRegion.java ---
@@ -321,7 +321,7 @@ public void destroyRegion(Object
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/488#discussion_r115331529
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java
---
@@ -388,7 +388,7 @@ public Set keySetOnServer
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/488#discussion_r115332259
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java
---
@@ -187,7 +187,7 @@ public void destroyRegion
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/488#discussion_r115331339
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java
---
@@ -187,7 +187,7 @@ public void destroyRegion
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/495
Yes. I think it is just xsd (not dtd) changes and the java changes needed
when adding a new xsd.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/504
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/504
Yes, pull it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/525#discussion_r118057642
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
@@ -485,9 +485,14 @@ public
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/515
This looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/507#discussion_r118060767
--- Diff:
geode-junit/src/main/java/org/apache/geode/test/junit/rules/UseJacksonForJsonPathRule.java
---
@@ -14,19 +14,18
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/507
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/525
Your diffs now show 51 files changed. It now shows a removal of deprecated
FunctionService API. Perhaps you are picking this up from changes others made?
You might need to close this PR
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/559#discussion_r120222821
--- Diff:
geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb ---
@@ -276,8 +276,83 @@ find the reason
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/559#discussion_r120224399
--- Diff:
geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb ---
@@ -276,8 +276,83 @@ find the reason
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/577#discussion_r121742105
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/577#discussion_r121751707
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/577#discussion_r121776319
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java
---
@@ -0,0 +1,133
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/577#discussion_r124134874
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/610#discussion_r124667734
--- Diff:
geode-docs/developing/partitioned_regions/set_join_redundancy_recovery.html.md.erb
---
@@ -19,23 +19,38 @@ See the License for the
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/627
This looks good. I will pull it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/677#discussion_r131003885
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -1208,6 +1208,9 @@ private void initialize
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/320
After looking over this fix we decided that it is too simple to have a
reasonable unit test.
I will pull it in
---
If your project is set up for it, you can reply to this email and
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/423
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/315
I think you should continue to remove code that was only used by
ReliableMessageQueueFactoryImpl. This included the following:
1. LocalizedStrings that this class used.
2
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/320
We need a unit test for GEODE-1969 that reproduces that failure. Then apply
your fix and the unit test should pass. The unit test should be made part of
this pull request. Hope fully Oplog
31 matches
Mail list logo
